1374007 - Firefox adds a gray opacity for an html5 video tag poster image

Status: VERIFIED FIXED

(Toolkit :: Video/Audio Controls, defect, P1)

Description

[Zurd]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:54.0) Gecko/20100101 Firefox/54.0
Build ID: 20170616092053

Steps to reproduce:

Go to
http://www.tutorialrepublic.com/codelab.php?topic=html5&file=video-element


Actual results:

The poster image on top of the video will be "grayed", there is some kind of opacity on it.


Expected results:

There should not be any opacity. Chrome and Edge works fine (use them to compare the image). This opacity problem doesn't look nice.

Problems happens in Firefox in Linux and Windows.

Comment 1

[Jean-Yves Avenard [:jya]]

This isn't an audio playback issue. It's a design one. It's a matter of guess I guess.

The video isn't playing.

Comment 2

[Zurd]

Yes, it's a design issue, not about playback.

Here's an image that shows Chrome, Edge and Firefox, I think it looks much better in Chrome and Edge.
https://s23.postimg.org/pg5pch2u3/firefox-chrome-edge-html5-video-image-poster.jpg

Haven't found a way to remove this opacity, looks like it's built-in into Firefox.

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

ralin, can you investigate this? I have seen in on occasion too but I don't have reliable STR.

Comment 4

[Ray Lin[:ralin]]

The grey overlay is by design for the visual refresh[1], but I think it's fine to make it transparent and behave like Chrome and Edge.


[1] http://searchfox.org/mozilla-central/rev/2c9a5993ac40ec1db8450e3e0a85702fa291b9e2/toolkit/themes/shared/media/videocontrols.css#84-86

Comment 5

[Ray Lin[:ralin]]

Attachment: Bug 1374007 - Remove grey overlay of media controls before media start to play.

Review commit: https://reviewboard.mozilla.org/r/180138/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/180138/

Comment 6

[Ray Lin[:ralin]]

Hi Gijs,

Could you help me to review this patch? Thanks.

Comment 7

[Jean-Yves Avenard [:jya]]

Comment on attachment 8908479 [details]
Bug 1374007 - Remove grey overlay of media controls before media start to play.

https://reviewboard.mozilla.org/r/180138/#review185302

::: commit-message-831e9:1
(Diff revision 1)
> +Bug 1374007 - Remove grey overlay of medai controls before media start to play. r=Gijs

nit:
s/medai/media

Comment 8

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8908479 [details]
Bug 1374007 - Remove grey overlay of media controls before media start to play.

https://reviewboard.mozilla.org/r/180138/#review185304

Comment 9

[Ray Lin[:ralin]]

Comment on attachment 8908479 [details]
Bug 1374007 - Remove grey overlay of media controls before media start to play.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/180138/diff/1-2/

Comment 10

[Ray Lin[:ralin]]

Thank you Jared, :jya

typo fixed.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Autoland can't push this until all pending issues in MozReview are marked as resolved.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2125fac068a6
Remove grey overlay of media controls before media start to play. r=jaws

Comment 13

[Ray Lin[:ralin]]

Thanks again :jya

Comment 14

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/2125fac068a6

Comment 15

[Hani Yacoub, Desktop QA]

Build ID: 20170919220202
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0

Verified as fixed on Firefox Nightly 57.0a1 on Windows 10 x 64, Mac OS X 10.12 and Ubuntu 16.04 x64.