1374042 - [Devtools] Network monitor permanent scrollbar

Status: VERIFIED FIXED

(DevTools :: Netmonitor, defect, P2)

Description

[Franck (Wip)]

Attachment: netmonitor dark theme

Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:55.0) Gecko/20100101 Firefox/55.0
BuildID: 20170615070049

Steps to reproduce:
 - start Firefox DevEdition or 55 Beta 2 with a new profile
 - open a new empty tab
 - open developer tools (F12 or menu)
 - select "Network" tab

Actual results:
 the network view is "empty" (as there is no request captured yet) but a scroll bar is visible, spanning from the column headers to the footer

Expected results:
 no scroll bar should appear

This scroll bar is visible with the dark and light theme but not the firebug one.
Scroll seems to be a few pixels worth, looks like a bug.

This permanent scroll bar prevents grabbing the content's one when available.

Comment 1

[Franck (Wip)]

Attachment: netmonitor light theme

Comment 2

[Franck (Wip)]

Attachment: double scrollbars bug

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Attachment: Bug 1374042 - Fix vertical scrollbar;

Review commit: https://reviewboard.mozilla.org/r/150392/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/150392/

Comment 4

[Tim Nguyen :ntim]

Comment on attachment 8879067 [details]
Bug 1374042 - Fix vertical scrollbar;

https://reviewboard.mozilla.org/r/150392/#review155010

Setting overflow: hidden instead of overflow-x: hidden on .request-list-container seems to fix the issue (without breaking scrolling).

It seems like a more elegant solution too.

Comment 5

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8879067 [details]
Bug 1374042 - Fix vertical scrollbar;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/150392/diff/1-2/

Comment 6

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Thanks for the review Tim, patch updated!

Honza

Comment 7

[Tim Nguyen :ntim]

Comment on attachment 8879067 [details]
Bug 1374042 - Fix vertical scrollbar;

https://reviewboard.mozilla.org/r/150392/#review155082

LGTM!

Comment 8

[Jan Honza Odvarko [:Honza] (always need-info? me)]

We should file request for uplift as soon as the fix is verified in Nightly.

Honza

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/36765be3ecb6
Fix vertical scrollbar; r=ntim

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/36765be3ecb6

Comment 11

[Md.Tarikul Islam Oashi]

I have reproduced this bug with nightly 56.0a1 (2017-06-18) on "Linux Mint 18.1 Serena"(64 Bit).

The bug's fix is now verified on Latest Nightly 56.0a1

Build ID 	20170620100236
User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:56.0) Gecko/20100101 Firefox/56.0

[Bugday-20170621]

Comment 12

[Md. Rahimul Islam]

I have successfully reproduced this bug with Nightly 56.0a1 (2017-06-18) (32-bit)  on windows 10(32bit)

this bug is verified fix with  latest Nightly 56.0a1 (2017-06-20) (32-bit)

Build ID: 20170620030208
Mozilla/5.0 (Windows NT 10.0; rv:56.0) Gecko/20100101 Firefox/56.0

Comment 13

[Md.Tarikul Islam Oashi]

As per Comment 11 & Comment 12, I am marking this bug as verified fixed

Comment 14

[Tim Nguyen :ntim]

Comment on attachment 8879067 [details]
Bug 1374042 - Fix vertical scrollbar;

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1360458
[User impact if declined]: Useless scrollbars in netmonitor, see screenshots
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: I don't think there are any
[Is the change risky?]: No
[Why is the change risky/not risky?]: Small CSS fix
[String changes made/needed]: no

Comment 15

[Johann Hofmann [:johannh]]

Screenshots:

https://screenshots.mattn.ca/compare/?oldProject=mozilla-central&oldRev=72346a4d6afcc17504f911190dbf470100e879ec&newProject=mozilla-central&newRev=bc9e028dbdc5c2f989175e6816dc864159133aee&filter=netmonitor

Comment 16

[Julien Cristau [:jcristau]]

Comment on attachment 8879067 [details]
Bug 1374042 - Fix vertical scrollbar;

netmonitor css fix, verified in nightly, beta55+

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/9a69034f6243