Closed Bug 1374042 Opened 2 years ago Closed 2 years ago

[Devtools] Network monitor permanent scrollbar

Categories

(DevTools :: Netmonitor, defect, P2, trivial)

55 Branch
defect

Tracking

(firefox54 unaffected, firefox55 fixed, firefox56 verified)

VERIFIED FIXED
Firefox 56
Tracking Status
firefox54 --- unaffected
firefox55 --- fixed
firefox56 --- verified

People

(Reporter: wip.the.gruik, Assigned: Honza)

Details

Attachments

(4 files)

Attached image netmonitor dark theme
Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:55.0) Gecko/20100101 Firefox/55.0
BuildID: 20170615070049

Steps to reproduce:
 - start Firefox DevEdition or 55 Beta 2 with a new profile
 - open a new empty tab
 - open developer tools (F12 or menu)
 - select "Network" tab

Actual results:
 the network view is "empty" (as there is no request captured yet) but a scroll bar is visible, spanning from the column headers to the footer

Expected results:
 no scroll bar should appear

This scroll bar is visible with the dark and light theme but not the firebug one.
Scroll seems to be a few pixels worth, looks like a bug.

This permanent scroll bar prevents grabbing the content's one when available.
Attached image netmonitor light theme
Attached image double scrollbars bug
Severity: normal → trivial
Status: UNCONFIRMED → NEW
Has STR: --- → yes
Ever confirmed: true
OS: Windows 7 → All
Hardware: x86_64 → All
Priority: -- → P2
Assignee: nobody → odvarko
Status: NEW → ASSIGNED
Comment on attachment 8879067 [details]
Bug 1374042 - Fix vertical scrollbar;

https://reviewboard.mozilla.org/r/150392/#review155010

Setting overflow: hidden instead of overflow-x: hidden on .request-list-container seems to fix the issue (without breaking scrolling).

It seems like a more elegant solution too.
Attachment #8879067 - Flags: review?(ntim.bugs)
Thanks for the review Tim, patch updated!

Honza
Comment on attachment 8879067 [details]
Bug 1374042 - Fix vertical scrollbar;

https://reviewboard.mozilla.org/r/150392/#review155082

LGTM!
Attachment #8879067 - Flags: review?(ntim.bugs) → review+
We should file request for uplift as soon as the fix is verified in Nightly.

Honza
https://hg.mozilla.org/mozilla-central/rev/36765be3ecb6
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
I have reproduced this bug with nightly 56.0a1 (2017-06-18) on "Linux Mint 18.1 Serena"(64 Bit).

The bug's fix is now verified on Latest Nightly 56.0a1

Build ID 	20170620100236
User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:56.0) Gecko/20100101 Firefox/56.0

[Bugday-20170621]
I have successfully reproduced this bug with Nightly 56.0a1 (2017-06-18) (32-bit)  on windows 10(32bit)

this bug is verified fix with  latest Nightly 56.0a1 (2017-06-20) (32-bit)

Build ID: 20170620030208
Mozilla/5.0 (Windows NT 10.0; rv:56.0) Gecko/20100101 Firefox/56.0
QA Whiteboard: Bugday-20170621]
As per Comment 11 & Comment 12, I am marking this bug as verified fixed
Status: RESOLVED → VERIFIED
Comment on attachment 8879067 [details]
Bug 1374042 - Fix vertical scrollbar;

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1360458
[User impact if declined]: Useless scrollbars in netmonitor, see screenshots
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: I don't think there are any
[Is the change risky?]: No
[Why is the change risky/not risky?]: Small CSS fix
[String changes made/needed]: no
Attachment #8879067 - Flags: approval-mozilla-beta?
Comment on attachment 8879067 [details]
Bug 1374042 - Fix vertical scrollbar;

netmonitor css fix, verified in nightly, beta55+
Attachment #8879067 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.