Stop using the :not(:target) selector in urlbar-star.svg and urlbar-tab.svg

RESOLVED FIXED in Firefox 56

Status

()

defect
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jwatt, Assigned: jwatt)

Tracking

(Blocks 1 bug, {perf})

unspecified
Firefox 56
Points:
---

Firefox Tracking Flags

(firefox56 fixed)

Details

Attachments

(2 attachments)

Comment hidden (empty)
(Assignee)

Comment 3

2 years ago
I should note that Dao told me that urlbar-star.svg references should be replaced with bookmark.svg references.

Comment 4

2 years ago
mozreview-review
Comment on attachment 8878932 [details]
Bug 1374099, part 1 - Remove chrome://browser/skin/urlbar-star.svg in favor of the context-fill using chrome://browser/skin/bookmark.svg.

https://reviewboard.mozilla.org/r/150162/#review155648

Hm, this and most of the surrounding code could live in shared/autocomplete.inc.css, but I guess that's not what this bug is about. Maybe I'll find the time to look into de-duping that one day.
Attachment #8878932 - Flags: review?(jhofmann) → review+

Comment 5

2 years ago
mozreview-review
Comment on attachment 8878933 [details]
Bug 1374099, part 2 - Convert chrome://browser/skin/urlbar-tab.svg and its consumers to use SVG image context paint.

https://reviewboard.mozilla.org/r/150164/#review155654

Thanks! :)

::: browser/themes/shared/urlbar-tab.svg:8
(Diff revision 1)
> -
> -  <path id="tab" d="M14,9.5V6c0-1.7-1.3-3-3-3H5C3.3,3,2,4.3,2,6v3.5C2,10.3,1.3,11,0.5,11h0C0.2,11,0,11.2,0,11.5v1 C0,12.8,0.2,13,0.5,13h15c0.3,0,0.5-0.2,0.5-0.5v-1c0-0.3-0.2-0.5-0.5-0.5h0C14.7,11,14,10.3,14,9.5z"/>
> -  <path id="tab-inverted" d="M14,9.5V6c0-1.7-1.3-3-3-3H5C3.3,3,2,4.3,2,6v3.5C2,10.3,1.3,11,0.5,11h0C0.2,11,0,11.2,0,11.5v1 C0,12.8,0.2,13,0.5,13h15c0.3,0,0.5-0.2,0.5-0.5v-1c0-0.3-0.2-0.5-0.5-0.5h0C14.7,11,14,10.3,14,9.5z"/>
> -
>  </svg>
> +

Nit: no newline at the end of the file, please :)
Attachment #8878933 - Flags: review?(jhofmann) → review+

Comment 6

2 years ago
Pushed by jwatt@jwatt.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0bba0577d825
part 1 - Remove chrome://browser/skin/urlbar-star.svg in favor of the context-fill using chrome://browser/skin/bookmark.svg. r=johannh
https://hg.mozilla.org/integration/mozilla-inbound/rev/c26eae4bee1f
part 2 - Convert chrome://browser/skin/urlbar-tab.svg and its consumers to use SVG image context paint. r=johannh

Comment 7

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/0bba0577d825
https://hg.mozilla.org/mozilla-central/rev/c26eae4bee1f
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
You need to log in before you can comment on or make changes to this bug.