Closed Bug 1374126 Opened 4 years ago Closed 4 years ago

EffectCompositor::RequestRestyle does unnecessary hashtable lookups

Categories

(Core :: DOM: Animation, enhancement, P2)

Product:
Core
Component:
DOM: Animation
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla56
Tracking Flags:
Tracking Status
firefox56 --- fixed

People

(Reporter: mats, Assigned: mats)

References

Details

(Keywords: perf)

Attachments

(1 file)

Use LookupForAdd instead of Contains+Put to avoid unnecessary hashtable lookups
1.22 KB, patch
froydnj
: review+
Details | Diff | Splinter Review 
Pushed by mpalmgren@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1cea8a8c16a5
Use LookupForAdd instead of Contains+Put to avoid unnecessary hashtable lookups.  r=froydnj
Sorry, I pushed this prematurely.  It's a fairly trivial change though,
so I'll leave it in for now and address any review comments retroactively.
Attachment #8879024 - Flags: review?(nfroyd) → review+
https://hg.mozilla.org/mozilla-central/rev/1cea8a8c16a5
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.