Closed Bug 1374173 Opened 3 years ago Closed 2 years ago

Refactor MediaCacheStream::Read and Seek

Categories

(Core :: Audio/Video: Playback, enhancement, P3)

55 Branch
enhancement

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: gerald, Assigned: gerald)

References

Details

Attachments

(2 files)

MediaCacheStream::Read and Seek are only used internally by ReadAt, so they could be made private&internal.

Also, Seek is only used internally to perform a SEEK_SET, so we can remove everything else.
Comment on attachment 8879000 [details]
Bug 1374173 - Make MediaCacheStream::Seek and Read internal -

https://reviewboard.mozilla.org/r/150284/#review154932
Attachment #8879000 - Flags: review?(jwwang) → review+
Comment on attachment 8879001 [details]
Bug 1374173 - SeekInternal is only used to SEEK_SET -

https://reviewboard.mozilla.org/r/150286/#review154934
Attachment #8879001 - Flags: review?(jwwang) → review+
Pushed by gsquelart@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/876aa3618a72
Make MediaCacheStream::Seek and Read internal - r=jwwang
https://hg.mozilla.org/integration/autoland/rev/1bfb595e6629
SeekInternal is only used to SEEK_SET - r=jwwang
https://hg.mozilla.org/mozilla-central/rev/876aa3618a72
https://hg.mozilla.org/mozilla-central/rev/1bfb595e6629
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Depends on: 1374441
Backed out in bug 1374441 ( https://hg.mozilla.org/mozilla-central/rev/a1ef8b483090 ) for intermittent MediaCache assertion failures.

See bug 1374441 comment 25 for some details, pointing the finger at the first part (Make MediaCacheStream::Seek and Read internal), which makes little sense as this should be a simple refactoring that doesn't change the behavior! To be investigated...

But it was a nice-to-have bug, so there is no hurry to get it done.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Bug 1415766 does the same thing as part 2 here, so if someone comes back to this bug, only part 1 will need to be re-done.
Depends on: 1415766
Bug 1428242 is taking care of this bug's part 1, so we can close this bug. Thank you JW.
Status: REOPENED → RESOLVED
Closed: 3 years ago2 years ago
Depends on: 1428242
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.