Closed
Bug 1374184
Opened 7 years ago
Closed 7 years ago
Merge MediaDecoder::NotifyDataArrived and NotifyDownloadProgressed
Categories
(Core :: Audio/Video: Playback, enhancement, P3)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: jwwang, Assigned: jwwang)
References
Details
Attachments
(3 files)
The same reason as bug 1373595. It is confusing to SourceBuffer to call these 2 similar functions in a row. We should combine them and leave NotifyDataArrived() only. http://searchfox.org/mozilla-central/rev/7cc377ce3f0a569c5c9b362d589705cd4fecc0ac/dom/media/mediasource/SourceBuffer.cpp#450-453
Assignee | ||
Updated•7 years ago
|
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Attachment #8879377 -
Flags: review?(gsquelart)
Attachment #8879378 -
Flags: review?(gsquelart)
Attachment #8879379 -
Flags: review?(gsquelart)
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8879377 [details] Bug 1374184. P1 - add NotifyDataArrivedInternal() and let ResourceCallback call it. https://reviewboard.mozilla.org/r/150686/#review155412
Attachment #8879377 -
Flags: review?(gsquelart) → review+
Comment 5•7 years ago
|
||
mozreview-review |
Comment on attachment 8879378 [details] Bug 1374184. P2 - merge NotifyDataArrived() and NotifyDownloadProgressed(). https://reviewboard.mozilla.org/r/150688/#review155414
Attachment #8879378 -
Flags: review?(gsquelart) → review+
Comment 6•7 years ago
|
||
mozreview-review |
Comment on attachment 8879379 [details] Bug 1374184. P3 - rename NotifyDownloadProgressed to DownloadProgressed for it is used internally by MediaDecoder and fix the comment. https://reviewboard.mozilla.org/r/150690/#review155416
Attachment #8879379 -
Flags: review?(gsquelart) → review+
Assignee | ||
Comment 7•7 years ago
|
||
Thanks!
Pushed by jwwang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7f999427c1db P1 - add NotifyDataArrivedInternal() and let ResourceCallback call it. r=gerald https://hg.mozilla.org/integration/autoland/rev/4d27d17b8fa5 P2 - merge NotifyDataArrived() and NotifyDownloadProgressed(). r=gerald https://hg.mozilla.org/integration/autoland/rev/51d001d733bb P3 - rename NotifyDownloadProgressed to DownloadProgressed for it is used internally by MediaDecoder and fix the comment. r=gerald
Comment 9•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/7f999427c1db https://hg.mozilla.org/mozilla-central/rev/4d27d17b8fa5 https://hg.mozilla.org/mozilla-central/rev/51d001d733bb
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•