Closed Bug 1374210 Opened 7 years ago Closed 7 years ago

Cancel drain request on shutdown

Categories

(Core :: Audio/Video: Playback, defect)

Product:
Core
Component:
Audio/Video: Playback
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla56
Tracking Flags:
Tracking Status
firefox55 --- fixed
firefox56 --- fixed

People

(Reporter: jya, Assigned: jya)

References

Details

Attachments

(1 file)

Bug 1374210: Reject/Cancel any pending operations.
59 bytes, text/x-review-board-request
mozbugz
: review+
lizzard
: approval-mozilla-beta+
Details 
An oversight in bug 1374068.

The drain request should be cancelled on shutdown.

Not much of a problem as Flush is always called first, but just in case.
Assignee: nobody → jyavenard
Comment on attachment 8879050 [details]
Bug 1374210: Reject/Cancel any pending operations.

https://reviewboard.mozilla.org/r/150374/#review155006
Attachment #8879050 - Flags: review?(gsquelart) → review+
Pushed by jyavenard@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/aeba107c84c5
Reject/Cancel any pending operations. r=gerald
Backed out for crashing mediasource-activesourcebuffers.html in non-e10s mode and timing out in e10s mode:

https://hg.mozilla.org/integration/autoland/rev/83857d05edbd84ee38eba97f04c0f9f8c01581fb

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=aeba107c84c5c563a65ea4ee6afc7d5093c6f420&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
Failure log crash: https://treeherder.mozilla.org/logviewer.html#?job_id=108155208&repo=autoland

[task 2017-06-19T10:39:24.512841Z] 10:39:24     INFO - TEST-START | /media-source/mediasource-activesourcebuffers.html
[task 2017-06-19T10:39:24.513241Z] 10:39:24     INFO - Clearing pref media.mediasource.enabled
[task 2017-06-19T10:39:24.751673Z] 10:39:24     INFO - PID 4442 | ExceptionHandler::GenerateDump cloned child ExceptionHandler::WaitForContinueSignal waiting for continue signal...
[task 2017-06-19T10:39:24.751958Z] 10:39:24     INFO - PID 4442 | 4585
[task 2017-06-19T10:39:24.752280Z] 10:39:24     INFO - PID 4442 | ExceptionHandler::SendContinueSignalToChild sent continue signal to child
[task 2017-06-19T10:39:24.893923Z] 10:39:24     INFO - mozcrash Downloading symbols from: https://queue.taskcluster.net/v1/task/cf-P3AAvSBe5EaHrDU65dg/artifacts/public/build/target.crashreporter-symbols.zip
[task 2017-06-19T10:39:30.644847Z] 10:39:30     INFO - mozcrash Copy/paste: /usr/local/bin/linux64-minidump_stackwalk /tmp/tmpQliqpi.mozrunner/minidumps/2fcd1ad7-4f23-11e4-f8c5-077d0efdb547.dmp /tmp/tmpUdyLXe
[task 2017-06-19T10:39:38.006525Z] 10:39:38     INFO - mozcrash Saved minidump as /home/worker/workspace/build/blobber_upload_dir/2fcd1ad7-4f23-11e4-f8c5-077d0efdb547.dmp
[task 2017-06-19T10:39:38.006891Z] 10:39:38     INFO - mozcrash Saved app info as /home/worker/workspace/build/blobber_upload_dir/2fcd1ad7-4f23-11e4-f8c5-077d0efdb547.extra
[task 2017-06-19T10:39:38.071070Z] 10:39:38     INFO - PROCESS-CRASH | /media-source/mediasource-activesourcebuffers.html | application crashed [@ mozilla::H264Converter::DecodeFirstSample(mozilla::MediaRawData*)::{lambda(nsTArray<RefPtr<mozilla::MediaData> > const&)#1}::operator()(nsTArray<RefPtr<mozilla::MediaData> > const&) const + 0x64]
[task 2017-06-19T10:39:38.071173Z] 10:39:38     INFO - Crash dump filename: /tmp/tmpQliqpi.mozrunner/minidumps/2fcd1ad7-4f23-11e4-f8c5-077d0efdb547.dmp
[task 2017-06-19T10:39:38.071421Z] 10:39:38     INFO - Operating system: Linux
[task 2017-06-19T10:39:38.071691Z] 10:39:38     INFO -                   0.0.0 Linux 3.13.0-112-generic #159-Ubuntu SMP Fri Mar 3 15:26:07 UTC 2017 x86_64
[task 2017-06-19T10:39:38.072039Z] 10:39:38     INFO - CPU: amd64
[task 2017-06-19T10:39:38.072401Z] 10:39:38     INFO -      family 6 model 62 stepping 4
[task 2017-06-19T10:39:38.072813Z] 10:39:38     INFO -      4 CPUs
[task 2017-06-19T10:39:38.072933Z] 10:39:38     INFO - 
[task 2017-06-19T10:39:38.073195Z] 10:39:38     INFO - GPU: UNKNOWN
[task 2017-06-19T10:39:38.073470Z] 10:39:38     INFO - 
[task 2017-06-19T10:39:38.073799Z] 10:39:38     INFO - Crash reason:  SIGSEGV
[task 2017-06-19T10:39:38.074326Z] 10:39:38     INFO - Crash address: 0x60
[task 2017-06-19T10:39:38.074372Z] 10:39:38     INFO - Process uptime: not available
[task 2017-06-19T10:39:38.074553Z] 10:39:38     INFO - 
[task 2017-06-19T10:39:38.074882Z] 10:39:38     INFO - Thread 55 (crashed)
[task 2017-06-19T10:39:38.075528Z] 10:39:38     INFO -  0  libxul.so!mozilla::H264Converter::DecodeFirstSample(mozilla::MediaRawData*)::{lambda(nsTArray<RefPtr<mozilla::MediaData> > const&)#1}::operator()(nsTArray<RefPtr<mozilla::MediaData> > const&) const + 0x64
[task 2017-06-19T10:39:38.075695Z] 10:39:38     INFO -     rax = 0x00007f1560929994   rdx = 0x00007f156092998c
[task 2017-06-19T10:39:38.075831Z] 10:39:38     INFO -     rcx = 0x00007f1560929994   rbx = 0x00007f152981cac8
[task 2017-06-19T10:39:38.076243Z] 10:39:38     INFO -     rsi = 0x00007f1560929994   rdi = 0x00007f1529886638
[task 2017-06-19T10:39:38.076623Z] 10:39:38     INFO -     rbp = 0x00007f154d5bca40   rsp = 0x00007f154d5bc9e0
[task 2017-06-19T10:39:38.076939Z] 10:39:38     INFO -      r8 = 0x00007f156092998c    r9 = 0x00007f156b000248
[task 2017-06-19T10:39:38.077101Z] 10:39:38     INFO -     r10 = 0x00007f1529900950   r11 = 0x00007f156b000178
[task 2017-06-19T10:39:38.077187Z] 10:39:38     INFO -     r12 = 0x00007f1529886400   r13 = 0x00007f152981ca90
[task 2017-06-19T10:39:38.077785Z] 10:39:38     INFO -     r14 = 0x00007f153272cde8   r15 = 0x0000000000000000
[task 2017-06-19T10:39:38.077944Z] 10:39:38     INFO -     rip = 0x00007f155d0b57b4
[task 2017-06-19T10:39:38.078001Z] 10:39:38     INFO -     Found by: given as instruction pointer in context
[task 2017-06-19T10:39:38.078200Z] 10:39:38     INFO -  1  libxul.so!mozilla::MozPromise<nsTArray<RefPtr<mozilla::MediaData> >, mozilla::MediaResult, true>::ThenValue<mozilla::H264Converter::DecodeFirstSample(mozilla::MediaRawData*)::<lambda(const DecodedData&)>, mozilla::H264Converter::DecodeFirstSample(mozilla::MediaRawData*)::<lambda(const mozilla::MediaResult&)> >::DoResolveOrRejectInternal [MozPromise.h:aeba107c84c5 : 517 + 0x5]
[task 2017-06-19T10:39:38.078571Z] 10:39:38     INFO -     rbx = 0x00007f152992b940   rbp = 0x00007f154d5bcab0
[task 2017-06-19T10:39:38.078860Z] 10:39:38     INFO -     rsp = 0x00007f154d5bca50   r12 = 0x00007f1529c18f60
[task 2017-06-19T10:39:38.079196Z] 10:39:38     INFO -     r13 = 0x00007f152981ca90   r14 = 0x00007f153272cde8
[task 2017-06-19T10:39:38.079840Z] 10:39:38     INFO -     r15 = 0x00007f15295e7bd0   rip = 0x00007f155d0b5ac4
[task 2017-06-19T10:39:38.079937Z] 10:39:38     INFO -     Found by: call frame info
[task 2017-06-19T10:39:38.080201Z] 10:39:38     INFO -  2  libxul.so!mozilla::MozPromise<nsTArray<RefPtr<mozilla::MediaData> >, mozilla::MediaResult, true>::ThenValueBase::ResolveOrRejectRunnable::Run [MozPromise.h:aeba107c84c5 : 494 + 0x6]
[task 2017-06-19T10:39:38.080322Z] 10:39:38     INFO -     rbx = 0x00007f152992b940   rbp = 0x00007f154d5bcae0
[task 2017-06-19T10:39:38.080671Z] 10:39:38     INFO -     rsp = 0x00007f154d5bcac0   r12 = 0x00007f152981ca90
[task 2017-06-19T10:39:38.081026Z] 10:39:38     INFO -     r13 = 0x00007f1529c18f20   r14 = 0x00007f153272cde8
[task 2017-06-19T10:39:38.081693Z] 10:39:38     INFO -     r15 = 0x00007f15295e7bd0   rip = 0x00007f155cf09a76
[task 2017-06-19T10:39:38.081749Z] 10:39:38     INFO -     Found by: call frame info
[task 2017-06-19T10:39:38.081944Z] 10:39:38     INFO -  3  libxul.so!mozilla::TaskQueue::Runner::Run [TaskQueue.cpp:aeba107c84c5 : 246 + 0x7]
[task 2017-06-19T10:39:38.082199Z] 10:39:38     INFO -     rbx = 0x00007f154d5bcaf0   rbp = 0x00007f154d5bcba0
[task 2017-06-19T10:39:38.082508Z] 10:39:38     INFO -     rsp = 0x00007f154d5bcaf0   r12 = 0x00007f15293139a0
[task 2017-06-19T10:39:38.083098Z] 10:39:38     INFO -     r13 = 0x00007f152992b940   r14 = 0x00007f153272cde8
[task 2017-06-19T10:39:38.083166Z] 10:39:38     INFO -     r15 = 0x00007f15295e7bd0   rip = 0x00007f155b679faa
[task 2017-06-19T10:39:38.083368Z] 10:39:38     INFO -     Found by: call frame info
[task 2017-06-19T10:39:38.083903Z] 10:39:38     INFO -  4  libxul.so!nsThreadPool::Run [nsThreadPool.cpp:aeba107c84c5 : 225 + 0x6]
[task 2017-06-19T10:39:38.083970Z] 10:39:38     INFO -     rbx = 0x00007f15325214d0   rbp = 0x00007f154d5bcc70
[task 2017-06-19T10:39:38.084185Z] 10:39:38     INFO -     rsp = 0x00007f154d5bcbb0   r12 = 0x0000000000000000
[task 2017-06-19T10:39:38.084450Z] 10:39:38     INFO -     r13 = 0x00007f15325214f8   r14 = 0x0000000000000000
[task 2017-06-19T10:39:38.084662Z] 10:39:38     INFO -     r15 = 0x00007f1532521558   rip = 0x00007f155b67f5a5
[task 2017-06-19T10:39:38.084910Z] 10:39:38     INFO -     Found by: call frame info
[task 2017-06-19T10:39:38.085276Z] 10:39:38     INFO -  5  libxul.so!nsThread::ProcessNextEvent [nsThread.cpp:aeba107c84c5 : 1428 + 0x6]
[task 2017-06-19T10:39:38.085604Z] 10:39:38     INFO -     rbx = 0x00007f152b22c200   rbp = 0x00007f154d5bcd80
[task 2017-06-19T10:39:38.085960Z] 10:39:38     INFO -     rsp = 0x00007f154d5bcc80   r12 = 0x0000000000000001
[task 2017-06-19T10:39:38.086216Z] 10:39:38     INFO -     r13 = 0x0000000000000000   r14 = 0x00007f152b22c200
[task 2017-06-19T10:39:38.086495Z] 10:39:38     INFO -     r15 = 0x00007f154d5bcd9f   rip = 0x00007f155b685dc1
[task 2017-06-19T10:39:38.086826Z] 10:39:38     INFO -     Found by: call frame info
[task 2017-06-19T10:39:38.087104Z] 10:39:38     INFO -  6  libxul.so!NS_ProcessNextEvent [nsThreadUtils.cpp:aeba107c84c5 : 475 + 0xd]
[task 2017-06-19T10:39:38.087615Z] 10:39:38     INFO -     rbx = 0x0000000000000001   rbp = 0x00007f154d5bcdb0
[task 2017-06-19T10:39:38.087734Z] 10:39:38     INFO -     rsp = 0x00007f154d5bcd90   r12 = 0x00007f152b10f280
[task 2017-06-19T10:39:38.087939Z] 10:39:38     INFO -     r13 = 0x0000000000000000   r14 = 0x00007f152b22c200
[task 2017-06-19T10:39:38.088175Z] 10:39:38     INFO -     r15 = 0x00007f152b10f2a0   rip = 0x00007f155b683cad
[task 2017-06-19T10:39:38.088484Z] 10:39:38     INFO -     Found by: call frame info
[task 2017-06-19T10:39:38.088738Z] 10:39:38     INFO -  7  libxul.so!mozilla::ipc::MessagePumpForNonMainThreads::Run [MessagePump.cpp:aeba107c84c5 : 368 + 0xd]
[task 2017-06-19T10:39:38.088947Z] 10:39:38     INFO -     rbx = 0x00007f152b22c540   rbp = 0x00007f154d5bce10
[task 2017-06-19T10:39:38.089156Z] 10:39:38     INFO -     rsp = 0x00007f154d5bcdc0   r12 = 0x00007f152b10f280
[task 2017-06-19T10:39:38.089361Z] 10:39:38     INFO -     r13 = 0x0000000000000000   r14 = 0x00007f152b22c200
[task 2017-06-19T10:39:38.089565Z] 10:39:38     INFO -     r15 = 0x00007f152b10f2a0   rip = 0x00007f155baa7ad0
[task 2017-06-19T10:39:38.089759Z] 10:39:38     INFO -     Found by: call frame info
[task 2017-06-19T10:39:38.089977Z] 10:39:38     INFO -  8  libxul.so!MessageLoop::Run [message_loop.cc:aeba107c84c5 : 318 + 0x5]
[task 2017-06-19T10:39:38.090177Z] 10:39:38     INFO -     rbx = 0x00007f152b22c200   rbp = 0x00007f154d5bce40
[task 2017-06-19T10:39:38.090381Z] 10:39:38     INFO -     rsp = 0x00007f154d5bce20   r12 = 0x00007f154d5bce80
[task 2017-06-19T10:39:38.090586Z] 10:39:38     INFO -     r13 = 0x00007f152b22c220   r14 = 0x00007f152b22c540
[task 2017-06-19T10:39:38.090789Z] 10:39:38     INFO -     r15 = 0x00007f154d5bd670   rip = 0x00007f155ba7aed2
[task 2017-06-19T10:39:38.090983Z] 10:39:38     INFO -     Found by: call frame info
[task 2017-06-19T10:39:38.091197Z] 10:39:38     INFO -  9  libxul.so!nsThread::ThreadFunc [nsThread.cpp:aeba107c84c5 : 503 + 0x8]
[task 2017-06-19T10:39:38.091423Z] 10:39:38     INFO -     rbx = 0x00007f152b22c200   rbp = 0x00007f154d5bcec0
[task 2017-06-19T10:39:38.091766Z] 10:39:38     INFO -     rsp = 0x00007f154d5bce50   r12 = 0x00007f154d5bce80
[task 2017-06-19T10:39:38.092137Z] 10:39:38     INFO -     r13 = 0x00007f152b22c220   r14 = 0x00007f152b22c540
[task 2017-06-19T10:39:38.092505Z] 10:39:38     INFO -     r15 = 0x00007f154d5bd670   rip = 0x00007f155b6845e0
[task 2017-06-19T10:39:38.092868Z] 10:39:38     INFO -     Found by: call frame info
[task 2017-06-19T10:39:38.093240Z] 10:39:38     INFO - 10  libnspr4.so!_pt_root [ptthread.c:aeba107c84c5 : 216 + 0x7]
[task 2017-06-19T10:39:38.093607Z] 10:39:38     INFO -     rbx = 0x00007f1532527940   rbp = 0x00007f154d5bcf10
[task 2017-06-19T10:39:38.093977Z] 10:39:38     INFO -     rsp = 0x00007f154d5bced0   r12 = 0x0000000000000000
[task 2017-06-19T10:39:38.094335Z] 10:39:38     INFO -     r13 = 0x00000000000011ad   r14 = 0x00007f154d5bd700
[task 2017-06-19T10:39:38.094703Z] 10:39:38     INFO -     r15 = 0x00007f154d5bd670   rip = 0x00007f156aacd9f1
[task 2017-06-19T10:39:38.095064Z] 10:39:38     INFO -     Found by: call frame info
[task 2017-06-19T10:39:38.095420Z] 10:39:38     INFO - 11  libpthread-2.23.so + 0x76ba
[task 2017-06-19T10:39:38.095790Z] 10:39:38     INFO -     rbx = 0x0000000000000000   rbp = 0x0000000000000000
[task 2017-06-19T10:39:38.096137Z] 10:39:38     INFO -     rsp = 0x00007f154d5bcf20   r12 = 0x0000000000000000
[task 2017-06-19T10:39:38.096506Z] 10:39:38     INFO -     r13 = 0x00007ffeb583f01f   r14 = 0x00007f154d5bd9c0
[task 2017-06-19T10:39:38.096867Z] 10:39:38     INFO -     r15 = 0x00007f1532527940   rip = 0x00007f156c21b6ba
[task 2017-06-19T10:39:38.097225Z] 10:39:38     INFO -     Found by: call frame info
[task 2017-06-19T10:39:38.097591Z] 10:39:38     INFO - 12  libc-2.23.so + 0x10682d
[task 2017-06-19T10:39:38.097956Z] 10:39:38     INFO -     rsp = 0x00007f154d5bcfc0   rip = 0x00007f156b2a482d
[task 2017-06-19T10:39:38.098258Z] 10:39:38     INFO -     Found by: stack scanning
Flags: needinfo?(jyavenard)
Depends on: 1374296
oh so it did crash thing :)

cool, I opened bug 1374296 to fix it..

too late by the look of things.
Flags: needinfo?(jyavenard)
Pushed by jyavenard@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/51fd9a7e155c
Reject/Cancel any pending operations. r=gerald
https://hg.mozilla.org/mozilla-central/rev/51fd9a7e155c
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Marking this affected for 55 so that we will know to uplift it along with the work in bug 1374210.
status-firefox55: --- → affected
Comment on attachment 8879050 [details]
Bug 1374210: Reject/Cancel any pending operations.

Please uplift for 55 beta 5, along with the patch from bug 1374068; should fix an issue with Twitter video playback. If there are any regressions from this please back both patches out.
Attachment #8879050 - Flags: approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: