Closed Bug 1374248 Opened 5 years ago Closed 5 years ago

LUL: remove stack scanning

Categories

(Core :: Gecko Profiler, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: jseward, Assigned: jseward)

Details

Attachments

(1 file)

LUL, which currently provides native unwinding for the Gecko profiler on 32-
and 64-bit x86 Linux, has the ability to recover stack frames heuristically
using stack scanning.

Stack scanning was added in an attempt to have functional parity with the
Breakpad unwinder, which preceded LUL in this role.  However, the profiler
calls LUL with a parameter which limits the number of scan-recovered frames
to zero -- in other words it is disabled.  Previous experimentation with
stack scanning shows that it often recovers incorrect frames and so throws
unwinding off the trail completely.  It seems more suited to an
unwind-after-crash scenario -- where we want to get as much information as
we can, accepting the risk that it might be wrong -- and less suited to a
profiling scenario, where we prefer to have incomplete stacks rather than
incorrect ones.

So this bug proposes to remove stack scanning from LUL.  Given that it's
not currently used, there will be zero visible functional changes.
Assignee: nobody → jseward
Attachment #8879433 - Flags: review?(n.nethercote)
Attachment #8879433 - Flags: review?(n.nethercote) → review+
https://hg.mozilla.org/mozilla-central/rev/5860160aa255
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.