Closed Bug 1374263 Opened 3 years ago Closed 3 years ago

./mach web-platform-tests is looking for geckodriver in the wrong directory on OSX

Categories

(Testing :: geckodriver, defect, P3)

Unspecified
macOS
defect

Tracking

(firefox58 fixed)

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: automatedtester, Assigned: automatedtester)

Details

Attachments

(1 file)

When I build the Firefox and geckodriver with `ac_add_options --enable-geckodriver`

it is looking for geckodriver in 

./obj-ff-dbg.noindex/dist/Nightly.app/Contents/MacOS/geckodriver 

and it is in 

./obj-ff-dbg.noindex/dist/Nightly.app/Contents/Resources/geckodriver
Version: Version 3 → unspecified
OS: Unspecified → Mac OS X
Summary: ./mach web-platform-tests is looking for geckodriver in the wrong directory → ./mach web-platform-tests is looking for geckodriver in the wrong directory on OSX
So it would appear that certutil gets placed in Contents/MacOS/certutil, which we would expect.  This means that wptrunner is looking for the binary in the correct place, but that mozbuild is linking it to the wrong objdir directory.
(In reply to Andreas Tolfsen ‹:ato› from comment #1)
> that mozbuild is linking it to the wrong objdir directory.

What do the steps of a build log that deals with geckodriver look like?
Flags: needinfo?(dburns)
A not so helpful build output for around geckodriver was

50:51.24     case 1: options->flag_name_substring_search = true;
50:51.24     ^
50:51.24     break;
50:51.52 1 warning generated.
50:51.52 In file included from /Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/media/webrtc/trunk/third_party/gflags/gflags_gflags/Unified_cpp_third_party_gflags0.cpp:2:
50:51.53 /Users/dburns/development/mozilla-central/media/webrtc/trunk/third_party/gflags/src/gflags.cc:281:53: warning: unused typedef 'true_false_equal' [-Wunused-local-typedef]
50:51.53     COMPILE_ASSERT(sizeof(kTrue) == sizeof(kFalse), true_false_equal);
50:51.53                                                     ^
50:51.92 libnssdbm.a.desc
50:52.89 logalloc-replay
50:54.78 libmedia_mtransport_test.a.desc
50:55.20 3 warnings generated.
50:55.21 libgflags.a.desc
50:56.17 TestArguments
50:56.17 TestBlockingProcess
50:56.41 TestPRIntN
50:56.64 TestQuickReturn
50:56.84 host_ListCSSProperties
50:56.86 TestUnicodeArguments
50:57.01 clang: warning: libstdc++ is deprecated; move to libc++ with a minimum deployment target of OS X 10.9
50:57.55 rapl
51:00.78 libecc.a.desc
51:02.99 org.mozilla.updater
51:03.65 TestAUSHelper
51:03.65 TestAUSReadStrings
51:04.28 updater-xpcshell
51:05.17 force-cargo-program-build
51:06.57    Compiling geckodriver v0.17.0 (file:///Users/dburns/development/mozilla-central/testing/geckodriver)
51:06.59 minidump-analyzer
51:06.81 libxpcomglue.a
51:08.15 warning: unknown warning option '-Wno-discarded-qualifiers'; did you mean '-Wno-ignored-qualifiers'? [-Wunknown-warning-option]
51:08.15 warning: unknown warning option '-Wno-maybe-uninitialized'; did you mean '-Wno-uninitialized'? [-Wunknown-warning-option]
51:08.26 2 warnings generated.
51:08.29 warning: unknown warning option '-Wno-discarded-qualifiers'; did you mean '-Wno-ignored-qualifiers'? [-Wunknown-warning-option]
51:08.29 warning: unknown warning option '-Wno-maybe-uninitialized'; did you mean '-Wno-uninitialized'? [-Wunknown-warning-option]
51:08.42 2 warnings generated.
51:08.44 warning: unknown warning option '-Wno-discarded-qualifiers'; did you mean '-Wno-ignored-qualifiers'? [-Wunknown-warning-option]
51:08.45 warning: unknown warning option '-Wno-maybe-uninitialized'; did you mean '-Wno-uninitialized'? [-Wunknown-warning-option]
51:08.81 2 warnings generated.
51:08.84 warning: unknown warning option '-Wno-discarded-qualifiers'; did you mean '-Wno-ignored-qualifiers'? [-Wunknown-warning-option]
Flags: needinfo?(dburns)
I think I now have the right amount of log for what you need

45:37.39 ../../../../../config/nsinstall -L /Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/toolkit/mozapps/update/updater/updater-xpcshell -m 755 'updater-xpcshell' '../../../../../_tests/xpcshell/toolkit/mozapps/update/tests'
45:37.41 /usr/bin/clang++ -std=gnu++11 -o TestIntegerPrintfMacros.o -c  -fvisibility=hidden -fvisibility-inlines-hidden -DNDEBUG=1 -DTRIMMED=1 -DIMPL_MFBT -I/Users/dburns/development/mozilla-central/mfbt/tests -I/Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/mfbt/tests  -I/Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/dist/include  -I/Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/dist/include/testing -I/Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/dist/include/nspr -I/Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/dist/include/nss       -fPIC  -DMOZILLA_CLIENT -include /Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/mozilla-config.h -MD -MP -MF .deps/TestIntegerPrintfMacros.o.pp -Qunused-arguments   -Qunused-arguments -Wall -Wc++11-compat -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wloop-analysis -Wc++11-compat-pedantic -Wc++14-compat -Wc++14-compat-pedantic -Wc++1z-compat -Wimplicit-fallthrough -Wstring-conversion -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wformat -Wno-gnu-zero-variadic-macro-arguments -Wformat-security -Wno-unknown-warning-option -Wno-return-type-c-linkage -fno-exceptions -fno-strict-aliasing -stdlib=libc++ -fno-rtti -fno-exceptions -fno-math-errno -pthread -pipe  -g -O3 -fno-omit-frame-pointer   -Wno-error=shadow  /Users/dburns/development/mozilla-central/mfbt/tests/TestIntegerPrintfMacros.cpp
45:37.78 force-cargo-program-build
45:37.78 env   RUSTFLAGS=' '  CARGO_TARGET_DIR=. RUSTC=/Users/dburns/.cargo/bin/rustc MOZ_SRC=/Users/dburns/development/mozilla-central MOZ_DIST=/Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/dist LIBCLANG_PATH="" CLANG_PATH="" PKG_CONFIG_ALLOW_CROSS=1 RUST_BACKTRACE=1 MOZ_TOPOBJDIR=/Users/dburns/development/mozilla-central/obj-ff-dbg.noindex MOZ_CARGO_WRAP_LDFLAGS="-Wl,-executable_path,/Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/dist/bin -Wl,-dead_strip" MOZ_CARGO_WRAP_LD=" /usr/bin/clang -std=gnu99" CARGO_TARGET_X86_64_APPLE_DARWIN_LINKER=/Users/dburns/development/mozilla-central/build/cargo-linker /Users/dburns/.cargo/bin/cargo build  --release --frozen --manifest-path /Users/dburns/development/mozilla-central/testing/geckodriver/Cargo.toml --color=always --bin geckodriver --target=x86_64-apple-darwin
45:38.68 dump_syms
45:38.68 /Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/_virtualenv/bin/python /Users/dburns/development/mozilla-central/config/expandlibs_exec.py -- /usr/local/bin/ccache /usr/bin/clang++ -std=gnu++11 -o dump_syms  -MD -MP -MF .deps/dump_syms.pp -O3 -DNDEBUG=1 -DTRIMMED=1 -O2 -g -pthread -stdlib=libc++  host_dump_syms_tool.o ../../../../../../../toolkit/crashreporter/google-breakpad/src/common/mac/libhost_breakpad_mac_common_s.a ../../../../../../../toolkit/crashreporter/google-breakpad/src/common/libhost_breakpad_common_s.a ../../../../../../../toolkit/crashreporter/google-breakpad/src/common/dwarf/libhost_breakpad_dwarf_s.a
45:38.99 clang: warning: argument unused during compilation: '-pthread'
45:39.01 ../../../../../../../config/nsinstall -L /Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/toolkit/crashreporter/google-breakpad/src/tools/mac/dump_syms -m 755 'dump_syms' '../../../../../../../dist/host/bin'
45:39.05 /usr/bin/clang++ -std=gnu++11 -o FileUtils.o -c  -fvisibility=hidden -fvisibility-inlines-hidden -DNDEBUG=1 -DTRIMMED=1 -DXPCOM_GLUE -I/Users/dburns/development/mozilla-central/xpcom/glue/standalone -I/Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/xpcom/glue/standalone -I/Users/dburns/development/mozilla-central/xpcom/build -I/Users/dburns/development/mozilla-central/xpcom/threads -I/Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/dist/include  -I/Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/dist/include/nspr -I/Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/dist/include/nss       -fPIC  -DMOZILLA_CLIENT -include /Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/mozilla-config.h -MD -MP -MF .deps/FileUtils.o.pp -Qunused-arguments   -Qunused-arguments -Wall -Wc++11-compat -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wloop-analysis -Wc++11-compat-pedantic -Wc++14-compat -Wc++14-compat-pedantic -Wc++1z-compat -Wimplicit-fallthrough -Wstring-conversion -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wformat -Wno-gnu-zero-variadic-macro-arguments -Wformat-security -Wno-unknown-warning-option -Wno-return-type-c-linkage -fno-exceptions -fno-strict-aliasing -stdlib=libc++ -fno-rtti -fno-exceptions -fno-math-errno -pthread -pipe  -g -O3 -fno-omit-frame-pointer     /Users/dburns/development/mozilla-central/xpcom/glue/FileUtils.cpp
45:39.40 /usr/bin/clang++ -std=gnu++11 -o nsXPCOMGlue.o -c  -fvisibility=hidden -fvisibility-inlines-hidden -DNDEBUG=1 -DTRIMMED=1 -DXPCOM_GLUE -I/Users/dburns/development/mozilla-central/xpcom/glue/standalone -I/Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/xpcom/glue/standalone -I/Users/dburns/development/mozilla-central/xpcom/build -I/Users/dburns/development/mozilla-central/xpcom/threads -I/Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/dist/include  -I/Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/dist/include/nspr -I/Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/dist/include/nss       -fPIC  -DMOZILLA_CLIENT -include /Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/mozilla-config.h -MD -MP -MF .deps/nsXPCOMGlue.o.pp -Qunused-arguments   -Qunused-arguments -Wall -Wc++11-compat -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wloop-analysis -Wc++11-compat-pedantic -Wc++14-compat -Wc++14-compat-pedantic -Wc++1z-compat -Wimplicit-fallthrough -Wstring-conversion -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wformat -Wno-gnu-zero-variadic-macro-arguments -Wformat-security -Wno-unknown-warning-option -Wno-return-type-c-linkage -fno-exceptions -fno-strict-aliasing -stdlib=libc++ -fno-rtti -fno-exceptions -fno-math-errno -pthread -pipe  -g -O3 -fno-omit-frame-pointer     /Users/dburns/development/mozilla-central/xpcom/glue/standalone/nsXPCOMGlue.cpp
45:39.52    Compiling geckodriver v0.17.0 (file:///Users/dburns/development/mozilla-central/testing/geckodriver)
45:40.64 minidump-analyzer
45:40.65 /Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/_virtualenv/bin/python /Users/dburns/development/mozilla-central/config/expandlibs_exec.py --uselist --  /usr/bin/clang++ -std=gnu++11 -o minidump-analyzer -Qunused-arguments   -Qunused-arguments -Wall -Wc++11-compat -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wloop-analysis -Wc++11-compat-pedantic -Wc++14-compat -Wc++14-compat-pedantic -Wc++1z-compat -Wimplicit-fallthrough -Wstring-conversion -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wformat -Wno-gnu-zero-variadic-macro-arguments -Wformat-security -Wno-unknown-warning-option -Wno-return-type-c-linkage -fno-exceptions -fno-strict-aliasing -stdlib=libc++ -fno-rtti -fno-exceptions -fno-math-errno -pthread -pipe  -g -O3 -fno-omit-frame-pointer   Unified_cpp_minidump-analyzer0.o   -framework Cocoa -lobjc -framework AudioToolbox  -framework ExceptionHandling  -Wl,-executable_path,/Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/dist/bin -Wl,-dead_strip  ../../../toolkit/crashreporter/google-breakpad/src/processor/libbreakpad_processor.a ../../../toolkit/components/jsoncpp/src/lib_json/libjsoncpp.a
45:40.77 libxpcomglue.a
45:40.77 rm -f libxpcomglue.a libxpcomglue.a.desc
45:40.77 /Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/_virtualenv/bin/python /Users/dburns/development/mozilla-central/config/expandlibs_exec.py --extract -- ar crs libxpcomglue.a FileUtils.o nsXPCOMGlue.o ../../../memory/fallible/libfallible.a
45:40.91 ../../../config/nsinstall -L /Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/toolkit/crashreporter/minidump-analyzer -m 755 'minidump-analyzer' '../../../dist/bin/crashreporter.app/Contents/MacOS'
45:40.92 /usr/bin/clang++ -std=gnu++11 -o TestIntegerRange.o -c  -fvisibility=hidden -fvisibility-inlines-hidden -DNDEBUG=1 -DTRIMMED=1 -DIMPL_MFBT -I/Users/dburns/development/mozilla-central/mfbt/tests -I/Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/mfbt/tests  -I/Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/dist/include  -I/Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/dist/include/testing -I/Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/dist/include/nspr -I/Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/dist/include/nss       -fPIC  -DMOZILLA_CLIENT -include /Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/mozilla-config.h -MD -MP -MF .deps/TestIntegerRange.o.pp -Qunused-arguments   -Qunused-arguments -Wall -Wc++11-compat -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wloop-analysis -Wc++11-compat-pedantic -Wc++14-compat -Wc++14-compat-pedantic -Wc++1z-compat -Wimplicit-fallthrough -Wstring-conversion -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wformat -Wno-gnu-zero-variadic-macro-arguments -Wformat-security -Wno-unknown-warning-option -Wno-return-type-c-linkage -fno-exceptions -fno-strict-aliasing -stdlib=libc++ -fno-rtti -fno-exceptions -fno-math-errno -pthread -pipe  -g -O3 -fno-omit-frame-pointer   -Wno-error=shadow  /Users/dburns/development/mozilla-central/mfbt/tests/TestIntegerRange.cpp
45:40.97 /usr/bin/clang++ -std=gnu++11 -o TestJSONWriter.o -c  -fvisibility=hidden -fvisibility-inlines-hidden -DNDEBUG=1 -DTRIMMED=1 -DIMPL_MFBT -I/Users/dburns/development/mozilla-central/mfbt/tests -I/Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/mfbt/tests  -I/Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/dist/include  -I/Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/dist/include/testing -I/Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/dist/include/nspr -I/Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/dist/include/nss       -fPIC  -DMOZILLA_CLIENT -include /Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/mozilla-config.h -MD -MP -MF .deps/TestJSONWriter.o.pp -Qunused-arguments   -Qunused-arguments -Wall -Wc++11-compat -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wloop-analysis -Wc++11-compat-pedantic -Wc++14-compat -Wc++14-compat-pedantic -Wc++1z-compat -Wimplicit-fallthrough -Wstring-conversion -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wformat -Wno-gnu-zero-variadic-macro-arguments -Wformat-security -Wno-unknown-warning-option -Wno-return-type-c-linkage -fno-exceptions -fno-strict-aliasing -stdlib=libc++ -fno-rtti -fno-exceptions -fno-math-errno -pthread -pipe  -g -O3 -fno-omit-frame-pointer   -Wno-error=shadow  /Users/dburns/development/mozilla-central/mfbt/tests/TestJSONWriter.cpp
45:42.28 /usr/bin/clang -std=gnu99 -o allcodecs.o -c  -DNDEBUG=1 -DTRIMMED=1 -DHAVE_AV_CONFIG_H -DASSERT_LEVEL=1 -I/Users/dburns/development/mozilla-central/media/ffvpx/libavcodec -I/Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/media/ffvpx/libavcodec -I/Users/dburns/development/mozilla-central/media/ffvpx -I/Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/dist/include  -I/Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/dist/include/nspr -I/Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/dist/include/nss       -fPIC  -include /Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/mozilla-config.h -DMOZILLA_CLIENT -MD -MP -MF .deps/allcodecs.o.pp -Qunused-arguments   -Qunused-arguments -Wall -Wempty-body -Wignored-qualifiers -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wclass-varargs -Wloop-analysis -Wstring-conversion -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wformat -Wno-gnu-zero-variadic-macro-arguments -Wformat-security -fno-strict-aliasing -fno-math-errno -pthread -pipe  -g -O3 -fno-omit-frame-pointer  -Wno-parentheses -Wno-pointer-sign -Wno-sign-compare -Wno-switch -Wno-type-limits -Wno-unused-function -Wno-deprecated-declarations -Wno-discarded-qualifiers -Wno-maybe-uninitialized -Wno-incompatible-pointer-types-discards-qualifiers -Wno-logical-op-parentheses -include libavutil_visibility.h  /Users/dburns/development/mozilla-central/media/ffvpx/libavcodec/allcodecs.c
45:42.30 warning: unknown warning option '-Wno-discarded-qualifiers'; did you mean '-Wno-ignored-qualifiers'? [-Wunknown-warning-option]
45:42.31 warning: unknown warning option '-Wno-maybe-uninitialized'; did you mean '-Wno-uninitialized'? [-Wunknown-warning-option]
45:42.33 warning: unused import: `CookieResponse`
45:42.33   --> /Users/dburns/development/mozilla-central/testing/geckodriver/src/marionette.rs:43:56
45:42.33    |
45:42.33 43 | use webdriver::response::{CloseWindowResponse, Cookie, CookieResponse, CookiesResponse,
45:42.33    |                                                        ^^^^^^^^^^^^^^
45:42.33    |
45:42.33    = note: #[warn(unused_imports)] on by default
45:42.33
45:42.41 2 warnings generated.
45:42.42 /usr/bin/clang -std=gnu99 -o audioconvert.o -c  -DNDEBUG=1 -DTRIMMED=1 -DHAVE_AV_CONFIG_H -DASSERT_LEVEL=1 -I/Users/dburns/development/mozilla-central/media/ffvpx/libavcodec -I/Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/media/ffvpx/libavcodec -I/Users/dburns/development/mozilla-central/media/ffvpx -I/Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/dist/include  -I/Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/dist/include/nspr -I/Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/dist/include/nss       -fPIC  -include /Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/mozilla-config.h -DMOZILLA_CLIENT -MD -MP -MF .deps/audioconvert.o.pp -Qunused-arguments   -Qunused-arguments -Wall -Wempty-body -Wignored-qualifiers -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wclass-varargs -Wloop-analysis -Wstring-conversion -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wformat -Wno-gnu-zero-variadic-macro-arguments -Wformat-security -fno-strict-aliasing -fno-math-errno -pthread -pipe  -g -O3 -fno-omit-frame-pointer  -Wno-parentheses -Wno-pointer-sign -Wno-sign-compare -Wno-switch -Wno-type-limits -Wno-unused-function -Wno-deprecated-declarations -Wno-discarded-qualifiers -Wno-maybe-uninitialized -Wno-incompatible-pointer-types-discards-qualifiers -Wno-logical-op-parentheses -include libavutil_visibility.h  /Users/dburns/development/mozilla-central/media/ffvpx/libavcodec/audioconvert.c
45:42.44 warning: unknown warning option '-Wno-discarded-qualifiers'; did you mean '-Wno-ignored-qualifiers'? [-Wunknown-warning-option]
45:42.44 warning: unknown warning option '-Wno-maybe-uninitialized'; did you mean '-Wno-uninitialized'? [-Wunknown-warning-option]
45:42.56 2 warnings generated.
45:42.57 /usr/bin/clang -std=gnu99 -o avpacket.o -c  -DNDEBUG=1 -DTRIMMED=1 -DHAVE_AV_CONFIG_H -DASSERT_LEVEL=1 -I/Users/dburns/development/mozilla-central/media/ffvpx/libavcodec -I/Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/media/ffvpx/libavcodec -I/Users/dburns/development/mozilla-central/media/ffvpx -I/Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/dist/include  -I/Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/dist/include/nspr -I/Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/dist/include/nss       -fPIC  -include /Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/mozilla-config.h -DMOZILLA_CLIENT -MD -MP -MF .deps/avpacket.o.pp -Qunused-arguments   -Qunused-arguments -Wall -Wempty-body -Wignored-qualifiers -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wclass-varargs -Wloop-analysis -Wstring-conversion -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wformat -Wno-gnu-zero-variadic-macro-arguments -Wformat-security -fno-strict-aliasing -fno-math-errno -pthread -pipe  -g -O3 -fno-omit-frame-pointer  -Wno-parentheses -Wno-pointer-sign -Wno-sign-compare -Wno-switch -Wno-type-limits -Wno-unused-function -Wno-deprecated-declarations -Wno-discarded-qualifiers -Wno-maybe-uninitialized -Wno-incompatible-pointer-types-discards-qualifiers -Wno-logical-op-parentheses -include libavutil_visibility.h  /Users/dburns/development/mozilla-central/media/ffvpx/libavcodec/avpacket.c
45:42.59 warning: unknown warning option '-Wno-discarded-qualifiers'; did you mean '-Wno-ignored-qualifiers'? [-Wunknown-warning-option]
45:42.59 warning: unknown warning option '-Wno-maybe-uninitialized'; did you mean '-Wno-uninitialized'? [-Wunknown-warning-option]
45:42.88 2 warnings generated.
45:42.89 /usr/bin/clang -std=gnu99 -o avpicture.o -c  -DNDEBUG=1 -DTRIMMED=1 -DHAVE_AV_CONFIG_H -DASSERT_LEVEL=1 -I/Users/dburns/development/mozilla-central/media/ffvpx/libavcodec -I/Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/media/ffvpx/libavcodec -I/Users/dburns/development/mozilla-central/media/ffvpx -I/Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/dist/include  -I/Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/dist/include/nspr -I/Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/dist/include/nss       -fPIC  -include /Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/mozilla-config.h -DMOZILLA_CLIENT -MD -MP -MF .deps/avpicture.o.pp -Qunused-arguments   -Qunused-arguments -Wall -Wempty-body -Wignored-qualifiers -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wclass-varargs -Wloop-analysis -Wstring-conversion -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wformat -Wno-gnu-zero-variadic-macro-arguments -Wformat-security -fno-strict-aliasing -fno-math-errno -pthread -pipe  -g -O3 -fno-omit-frame-pointer  -Wno-parentheses -Wno-pointer-sign -Wno-sign-compare -Wno-switch -Wno-type-limits -Wno-unused-function -Wno-deprecated-declarations -Wno-discarded-qualifiers -Wno-maybe-uninitialized -Wno-incompatible-pointer-types-discards-qualifiers -Wno-logical-op-parentheses -include libavutil_visibility.h  /Users/dburns/development/mozilla-central/media/ffvpx/libavcodec/avpicture.c
45:42.90 warning: unknown warning option '-Wno-discarded-qualifiers'; did you mean '-Wno-ignored-qualifiers'? [-Wunknown-warning-option]
45:42.91 warning: unknown warning option '-Wno-maybe-uninitialized'; did you mean '-Wno-uninitialized'? [-Wunknown-warning-option]
45:42.99 2 warnings generated.
45:43.00 /usr/bin/clang -std=gnu99 -o bitstream.o -c  -DNDEBUG=1 -DTRIMMED=1 -DHAVE_AV_CONFIG_H -DASSERT_LEVEL=1 -I/Users/dburns/development/mozilla-central/media/ffvpx/libavcodec -I/Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/media/ffvpx/libavcodec -I/Users/dburns/development/mozilla-central/media/ffvpx -I/Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/dist/include  -I/Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/dist/include/nspr -I/Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/dist/include/nss       -fPIC  -include /Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/mozilla-config.h -DMOZILLA_CLIENT -MD -MP -MF .deps/bitstream.o.pp -Qunused-arguments   -Qunused-arguments -Wall -Wempty-body -Wignored-qualifiers -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wclass-varargs -Wloop-analysis -Wstring-conversion -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wformat -Wno-gnu-zero-variadic-macro-arguments -Wformat-security -fno-strict-aliasing -fno-math-errno -pthread -pipe  -g -O3 -fno-omit-frame-pointer  -Wno-parentheses -Wno-pointer-sign -Wno-sign-compare -Wno-switch -Wno-type-limits -Wno-unused-function -Wno-deprecated-declarations -Wno-discarded-qualifiers -Wno-maybe-uninitialized -Wno-incompatible-pointer-types-discards-qualifiers -Wno-logical-op-parentheses -include libavutil_visibility.h  /Users/dburns/development/mozilla-central/media/ffvpx/libavcodec/bitstream.c
45:43.02 warning: unknown warning option '-Wno-discarded-qualifiers'; did you mean '-Wno-ignored-qualifiers'? [-Wunknown-warning-option]
45:43.02 warning: unknown warning option '-Wno-maybe-uninitialized'; did you mean '-Wno-uninitialized'? [-Wunknown-warning-option]
45:43.31 2 warnings generated.
45:43.32 /usr/bin/clang -std=gnu99 -o codec_desc.o -c  -DNDEBUG=1 -DTRIMMED=1 -DHAVE_AV_CONFIG_H -DASSERT_LEVEL=1 -I/Users/dburns/development/mozilla-central/media/ffvpx/libavcodec -I/Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/media/ffvpx/libavcodec -I/Users/dburns/development/mozilla-central/media/ffvpx -I/Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/dist/include  -I/Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/dist/include/nspr -I/Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/dist/include/nss       -fPIC  -include /Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/mozilla-config.h -DMOZILLA_CLIENT -MD -MP -MF .deps/codec_desc.o.pp -Qunused-arguments   -Qunused-arguments -Wall -Wempty-body -Wignored-qualifiers -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wclass-varargs -Wloop-analysis -Wstring-conversion -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wformat -Wno-gnu-zero-variadic-macro-arguments -Wformat-security -fno-strict-aliasing -fno-math-errno -pthread -pipe  -g -O3 -fno-omit-frame-pointer  -Wno-parentheses -Wno-pointer-sign -Wno-sign-compare -Wno-switch -Wno-type-limits -Wno-unused-function -Wno-deprecated-declarations -Wno-discarded-qualifiers -Wno-maybe-uninitialized -Wno-incompatible-pointer-types-discards-qualifiers -Wno-logical-op-parentheses -include libavutil_visibility.h  /Users/dburns/development/mozilla-central/media/ffvpx/libavcodec/codec_desc.c
45:43.34 warning: unknown warning option '-Wno-discarded-qualifiers'; did you mean '-Wno-ignored-qualifiers'? [-Wunknown-warning-option]
45:43.34 warning: unknown warning option '-Wno-maybe-uninitialized'; did you mean '-Wno-uninitialized'? [-Wunknown-warning-option]
45:43.47 2 warnings generated.
45:43.48 /usr/bin/clang -std=gnu99 -o dummy_funcs.o -c  -DNDEBUG=1 -DTRIMMED=1 -DHAVE_AV_CONFIG_H -DASSERT_LEVEL=1 -I/Users/dburns/development/mozilla-central/media/ffvpx/libavcodec -I/Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/media/ffvpx/libavcodec -I/Users/dburns/development/mozilla-central/media/ffvpx -I/Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/dist/include  -I/Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/dist/include/nspr -I/Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/dist/include/nss       -fPIC  -include /Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/mozilla-config.h -DMOZILLA_CLIENT -MD -MP -MF .deps/dummy_funcs.o.pp -Qunused-arguments   -Qunused-arguments -Wall -Wempty-body -Wignored-qualifiers -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wclass-varargs -Wloop-analysis -Wstring-conversion -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wformat -Wno-gnu-zero-variadic-macro-arguments -Wformat-security -fno-strict-aliasing -fno-math-errno -pthread -pipe  -g -O3 -fno-omit-frame-pointer  -Wno-parentheses -Wno-pointer-sign -Wno-sign-compare -Wno-switch -Wno-type-limits -Wno-unused-function -Wno-deprecated-declarations -Wno-discarded-qualifiers -Wno-maybe-uninitialized -Wno-incompatible-pointer-types-discards-qualifiers -Wno-logical-op-parentheses -include libavutil_visibility.h  /Users/dburns/development/mozilla-central/media/ffvpx/libavcodec/dummy_funcs.c
45:43.48 /usr/bin/clang++ -std=gnu++11 -o SSE.o -c  -fvisibility=hidden -fvisibility-inlines-hidden -DNDEBUG=1 -DTRIMMED=1 -DIMPL_MFBT -DMOZ_HAS_MOZGLUE -I/Users/dburns/development/mozilla-central/mozglue/build -I/Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/mozglue/build  -I/Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/dist/include  -I/Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/dist/include/nspr -I/Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/dist/include/nss       -fPIC  -DMOZILLA_CLIENT -include /Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/mozilla-config.h -MD -MP -MF .deps/SSE.o.pp -Qunused-arguments   -Qunused-arguments -Wall -Wc++11-compat -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wloop-analysis -Wc++11-compat-pedantic -Wc++14-compat -Wc++14-compat-pedantic -Wc++1z-compat -Wimplicit-fallthrough -Wstring-conversion -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wformat -Wno-gnu-zero-variadic-macro-arguments -Wformat-security -Wno-unknown-warning-option -Wno-return-type-c-linkage -fno-exceptions -fno-strict-aliasing -stdlib=libc++ -fno-rtti -fno-exceptions -fno-math-errno -pthread -pipe  -g -O3 -fno-omit-frame-pointer     /Users/dburns/development/mozilla-central/mozglue/build/SSE.cpp
45:43.50 warning: unknown warning option '-Wno-discarded-qualifiers'; did you mean '-Wno-ignored-qualifiers'? [-Wunknown-warning-option]
45:43.50 warning: unknown warning option '-Wno-maybe-uninitialized'; did you mean '-Wno-uninitialized'? [-Wunknown-warning-option]
45:43.54 libmozglue.dylib
45:43.54 rm -f libmozglue.dylib
45:43.55 /Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/_virtualenv/bin/python /Users/dburns/development/mozilla-central/config/expandlibs_exec.py --uselist --  /usr/bin/clang++ -std=gnu++11 -Qunused-arguments   -Qunused-arguments -Wall -Wc++11-compat -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wloop-analysis -Wc++11-compat-pedantic -Wc++14-compat -Wc++14-compat-pedantic -Wc++1z-compat -Wimplicit-fallthrough -Wstring-conversion -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wformat -Wno-gnu-zero-variadic-macro-arguments -Wformat-security -Wno-unknown-warning-option -Wno-return-type-c-linkage -fno-exceptions -fno-strict-aliasing -stdlib=libc++ -fno-rtti -fno-exceptions -fno-math-errno -pthread -pipe  -g -O3 -fno-omit-frame-pointer   -fPIC  -o libmozglue.dylib  SSE.o   -framework Cocoa -lobjc -framework AudioToolbox  -framework ExceptionHandling -Wl,-U,_replace_init -Wl,-U,_replace_get_bridge -Wl,-U,_replace_malloc -Wl,-U,_replace_posix_memalign -Wl,-U,_replace_aligned_alloc -Wl,-U,_replace_calloc -Wl,-U,_replace_realloc -Wl,-U,_replace_free -Wl,-U,_replace_memalign -Wl,-U,_replace_valloc -Wl,-U,_replace_malloc_usable_size -Wl,-U,_replace_malloc_good_size -Wl,-U,_replace_jemalloc_stats -Wl,-U,_replace_jemalloc_purge_freed_pages -Wl,-U,_replace_jemalloc_free_dirty_pages -Wl,-U,_replace_jemalloc_thread_local_arena  -flat_namespace -Wl,-weak_library,../../memory/replace/dummy/libdummy_replace_malloc.dylib -Wl,-bind_at_load -Wl,-executable_path,/Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/dist/bin -Wl,-dead_strip  ../../memory/mozalloc/libmemory_mozalloc.a ../../memory/build/libmemory.a ../../mozglue/misc/libmozglue_misc.a ../../mfbt/libmfbt.a   -dynamiclib -install_name @executable_path/libmozglue.dylib -compatibility_version 1 -current_version 1 -single_module
45:43.63 2 warnings generated.
45:43.63 /usr/bin/clang -std=gnu99 -o flac.o -c  -DNDEBUG=1 -DTRIMMED=1 -DHAVE_AV_CONFIG_H -DASSERT_LEVEL=1 -I/Users/dburns/development/mozilla-central/media/ffvpx/libavcodec -I/Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/media/ffvpx/libavcodec -I/Users/dburns/development/mozilla-central/media/ffvpx -I/Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/dist/include  -I/Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/dist/include/nspr -I/Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/dist/include/nss       -fPIC  -include /Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/mozilla-config.h -DMOZILLA_CLIENT -MD -MP -MF .deps/flac.o.pp -Qunused-arguments   -Qunused-arguments -Wall -Wempty-body -Wignored-qualifiers -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wclass-varargs -Wloop-analysis -Wstring-conversion -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wformat -Wno-gnu-zero-variadic-macro-arguments -Wformat-security -fno-strict-aliasing -fno-math-errno -pthread -pipe  -g -O3 -fno-omit-frame-pointer  -Wno-parentheses -Wno-pointer-sign -Wno-sign-compare -Wno-switch -Wno-type-limits -Wno-unused-function -Wno-deprecated-declarations -Wno-discarded-qualifiers -Wno-maybe-uninitialized -Wno-incompatible-pointer-types-discards-qualifiers -Wno-logical-op-parentheses -include libavutil_visibility.h  /Users/dburns/development/mozilla-central/media/ffvpx/libavcodec/flac.c
45:43.66 warning: unknown warning option '-Wno-discarded-qualifiers'; did you mean '-Wno-ignored-qualifiers'? [-Wunknown-warning-option]
45:43.66 warning: unknown warning option '-Wno-maybe-uninitialized'; did you mean '-Wno-uninitialized'? [-Wunknown-warning-option]
45:43.84 2 warnings generated.
45:43.85 /usr/bin/clang -std=gnu99 -o flac_parser.o -c  -DNDEBUG=1 -DTRIMMED=1 -DHAVE_AV_CONFIG_H -DASSERT_LEVEL=1 -I/Users/dburns/development/mozilla-central/media/ffvpx/libavcodec -I/Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/media/ffvpx/libavcodec -I/Users/dburns/development/mozilla-central/media/ffvpx -I/Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/dist/include  -I/Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/dist/include/nspr -I/Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/dist/include/nss       -fPIC  -include /Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/mozilla-config.h -DMOZILLA_CLIENT -MD -MP -MF .deps/flac_parser.o.pp -Qunused-arguments   -Qunused-arguments -Wall -Wempty-body -Wignored-qualifiers -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wclass-varargs -Wloop-analysis -Wstring-conversion -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wformat -Wno-gnu-zero-variadic-macro-arguments -Wformat-security -fno-strict-aliasing -fno-math-errno -pthread -pipe  -g -O3 -fno-omit-frame-pointer  -Wno-parentheses -Wno-pointer-sign -Wno-sign-compare -Wno-switch -Wno-type-limits -Wno-unused-function -Wno-deprecated-declarations -Wno-discarded-qualifiers -Wno-maybe-uninitialized -Wno-incompatible-pointer-types-discards-qualifiers -Wno-logical-op-parentheses -include libavutil_visibility.h  /Users/dburns/development/mozilla-central/media/ffvpx/libavcodec/flac_parser.c
45:43.87 warning: unknown warning option '-Wno-discarded-qualifiers'; did you mean '-Wno-ignored-qualifiers'? [-Wunknown-warning-option]
45:43.87 warning: unknown warning option '-Wno-maybe-uninitialized'; did you mean '-Wno-uninitialized'? [-Wunknown-warning-option]
45:43.93 /usr/bin/clang++ -std=gnu++11 -o TestLinkedList.o -c  -fvisibility=hidden -fvisibility-inlines-hidden -DNDEBUG=1 -DTRIMMED=1 -DIMPL_MFBT -I/Users/dburns/development/mozilla-central/mfbt/tests -I/Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/mfbt/tests  -I/Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/dist/include  -I/Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/dist/include/testing -I/Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/dist/include/nspr -I/Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/dist/include/nss       -fPIC  -DMOZILLA_CLIENT -include /Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/mozilla-config.h -MD -MP -MF .deps/TestLinkedList.o.pp -Qunused-arguments   -Qunused-arguments -Wall -Wc++11-compat -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wloop-analysis -Wc++11-compat-pedantic -Wc++14-compat -Wc++14-compat-pedantic -Wc++1z-compat -Wimplicit-fallthrough -Wstring-conversion -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wformat -Wno-gnu-zero-variadic-macro-arguments -Wformat-security -Wno-unknown-warning-option -Wno-return-type-c-linkage -fno-exceptions -fno-strict-aliasing -stdlib=libc++ -fno-rtti -fno-exceptions -fno-math-errno -pthread -pipe  -g -O3 -fno-omit-frame-pointer   -Wno-error=shadow  /Users/dburns/development/mozilla-central/mfbt/tests/TestLinkedList.cpp
45:44.16 2 warnings generated.
45:44.17 /usr/bin/clang -std=gnu99 -o flacdata.o -c  -DNDEBUG=1 -DTRIMMED=1 -DHAVE_AV_CONFIG_H -DASSERT_LEVEL=1 -I/Users/dburns/development/mozilla-central/media/ffvpx/libavcodec -I/Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/media/ffvpx/libavcodec -I/Users/dburns/development/mozilla-central/media/ffvpx -I/Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/dist/include  -I/Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/dist/include/nspr -I/Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/dist/include/nss       -fPIC  -include /Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/mozilla-config.h -DMOZILLA_CLIENT -MD -MP -MF .deps/flacdata.o.pp -Qunused-arguments   -Qunused-arguments -Wall -Wempty-body -Wignored-qualifiers -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wclass-varargs -Wloop-analysis -Wstring-conversion -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wformat -Wno-gnu-zero-variadic-macro-arguments -Wformat-security -fno-strict-aliasing -fno-math-errno -pthread -pipe  -g -O3 -fno-omit-frame-pointer  -Wno-parentheses -Wno-pointer-sign -Wno-sign-compare -Wno-switch -Wno-type-limits -Wno-unused-function -Wno-deprecated-declarations -Wno-discarded-qualifiers -Wno-maybe-uninitialized -Wno-incompatible-pointer-types-discards-qualifiers -Wno-logical-op-parentheses -include libavutil_visibility.h  /Users/dburns/development/mozilla-central/media/ffvpx/libavcodec/flacdata.c
45:44.19 warning: unknown warning option '-Wno-discarded-qualifiers'; did you mean '-Wno-ignored-qualifiers'? [-Wunknown-warning-option]
45:44.19 warning: unknown warning option '-Wno-maybe-uninitialized'; did you mean '-Wno-uninitialized'? [-Wunknown-warning-option]
45:44.27 chmod +x libmozglue.dylib
45:44.28 ../../config/nsinstall -L /Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/mozglue/build -m 644 'libmozglue.dylib' '../../dist/bin'
45:44.30 2 warnings generated.
45:44.30 /usr/bin/clang++ -std=gnu++11 -o TestMacroArgs.o -c  -fvisibility=hidden -fvisibility-inlines-hidden -DNDEBUG=1 -DTRIMMED=1 -DIMPL_MFBT -I/Users/dburns/development/mozilla-central/mfbt/tests -I/Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/mfbt/tests  -I/Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/dist/include  -I/Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/dist/include/testing -I/Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/dist/include/nspr -I/Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/dist/include/nss       -fPIC  -DMOZILLA_CLIENT -include /Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/mozilla-config.h -MD -MP -MF .deps/TestMacroArgs.o.pp -Qunused-arguments   -Qunused-arguments -Wall -Wc++11-compat -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wloop-analysis -Wc++11-compat-pedantic -Wc++14-compat -Wc++14-compat-pedantic -Wc++1z-compat -Wimplicit-fallthrough -Wstring-conversion -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wformat -Wno-gnu-zero-variadic-macro-arguments -Wformat-security -Wno-unknown-warning-option -Wno-return-type-c-linkage -fno-exceptions -fno-strict-aliasing -stdlib=libc++ -fno-rtti -fno-exceptions -fno-math-errno -pthread -pipe  -g -O3 -fno-omit-frame-pointer   -Wno-error=shadow  /Users/dburns/development/mozilla-central/mfbt/tests/TestMacroArgs.cpp


Full log available at https://gist.github.com/AutomatedTester/9035a9a250c8ae8ed438eea24afeeff8
Nathan,

Do you need any more info, this is still happening for me.
Flags: needinfo?(nfroyd)
Priority: -- → P3
From the log in comment 4:

46:55.85 ../../config/nsinstall -L /Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/testing/geckodriver -m 755 'x86_64-apple-darwin/release/geckodriver' '../../dist/bin'

so that part is correct, at least.  And for certutil:

47:58.28 ../../../../../config/nsinstall -L /Users/dburns/development/mozilla-central/obj-ff-dbg.noindex/security/nss/cmd/certutil/certutil_certutil -m 755 'certutil' '../../../../../dist/bin'

it is getting put in the same place.  I *think* we need to add geckodriver (for --enable-geckodriver builds, of course) to:

http://dxr.mozilla.org/mozilla-central/source/browser/app/macbuild/Contents/MacOS-files.in#3

which I am assuming is how certutil winds up in the appropriate place.  I think we'd need to add a check for CONFIG['ENABLE_GECKODRIVER'] to define MOZ_ENABLE_GECKODRIVER right around here:

http://dxr.mozilla.org/mozilla-central/source/browser/app/moz.build#106

or add a set_define for 'ENABLE_GECKODRIVER' to:

http://dxr.mozilla.org/mozilla-central/source/toolkit/moz.configure#1144

David, are you willing to try that?
Flags: needinfo?(nfroyd)
Comment on attachment 8916757 [details]
Bug 1374263 - Make sure build places geckodriver binary in correct directory.

https://reviewboard.mozilla.org/r/187832/#review192882

So glad this works.  A few comments below.

::: browser/app/macbuild/Contents/MacOS-files.in:5
(Diff revision 1)
>  /*.app/***
>  /*.dylib
>  /certutil
>  /firefox-bin
> +/geckodriver

This should be:

```
#if defined(ENABLE_GECKODRIVER)
/geckodriver
#endif
```

(or whatever we decide the appropriate define should be), correct?

::: toolkit/moz.configure:1146
(Diff revision 1)
>  
>          if automation and compile_env and not broken_platforms:
>              return True
>  
>  set_config('ENABLE_GECKODRIVER', geckodriver)
> -
> +set_define('ENABLE_GECKODRIVER', geckodriver)

It looks like we don't actually use this in this patch? :)

We have two options here:

1) Remove this line, and add the following code to `browser/app/Makefile.in`:

```
if CONFIG['ENABLE_GECKODRIVER']:
    DEFINES['MOZ_GECKODRIVER'] = True
```

and then use `MOZ_GECKODRIVER` in the condition in MacOS-files.in, as discussed above.

2) Just use `ENABLE_GECKODRIVER` in MacOS-files.in, as discussed above.

I have a slight preference for the first option, as the second option would put something like `-DENABLE_GECKODRIVER` on every compiler command line we invoke, and a number of other ones besides.  That seems rather wasteful for a define we use in just one place on just one platform.
Attachment #8916757 - Flags: review?(nfroyd)
Comment on attachment 8916757 [details]
Bug 1374263 - Make sure build places geckodriver binary in correct directory.

https://reviewboard.mozilla.org/r/187832/#review193174

::: browser/app/Makefile.in:49
(Diff revision 2)
> +if CONFIG['ENABLE_GECKODRIVER']:
> +    DEFINES['MOZ_GECKODRIVER'] = True

Mmm, this bit should be in the moz.build file, not in the Makefile.in
Attachment #8916757 - Flags: review?(nfroyd)
I have no idea how that passed try! :)
Comment on attachment 8916757 [details]
Bug 1374263 - Make sure build places geckodriver binary in correct directory.

https://reviewboard.mozilla.org/r/187832/#review193674

Yay!  I assume that you have spot-checked this on your own machine?
Attachment #8916757 - Flags: review?(nfroyd) → review+
Comment on attachment 8916757 [details]
Bug 1374263 - Make sure build places geckodriver binary in correct directory.

https://reviewboard.mozilla.org/r/187832/#review193674

yup, clobber build and it was where I expected
Pushed by dburns@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1435d1f7db3b
Make sure build places geckodriver binary in correct directory. r=froydnj
https://hg.mozilla.org/mozilla-central/rev/1435d1f7db3b
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Assignee: nobody → dburns
You need to log in before you can comment on or make changes to this bug.