Closed
Bug 1374278
Opened 7 years ago
Closed 7 years ago
Crash in mozilla::layers::CompositorManagerChild::Init
Categories
(Core :: Graphics, enhancement, P3)
Core
Graphics
Tracking
()
RESOLVED
FIXED
mozilla56
| Tracking | Status | |
|---|---|---|
| firefox-esr52 | --- | unaffected |
| firefox54 | --- | unaffected |
| firefox55 | --- | unaffected |
| firefox56 | --- | fixed |
People
(Reporter: aosmond, Assigned: aosmond)
References
Details
(Keywords: topcrash, Whiteboard: gfx-noted)
Crash Data
Attachments
(1 file)
Looks like we can reinit before the CompositorManagerChild actor gets torn down: https://crash-stats.mozilla.com/report/index/78513a1a-93dc-4e7b-be6e-e39d60170619 https://crash-stats.mozilla.com/report/index/29a8eb65-0af1-4006-ae69-87d120170619
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → aosmond
Blocks: 1365927
Status: NEW → ASSIGNED
Crash Signature: [@ mozilla::layers::CompositorManagerChild::Init ]
Priority: -- → P3
Whiteboard: gfx-noted
|
|
Assignee | |
Updated•7 years ago
|
Crash Signature: [@ mozilla::layers::CompositorManagerChild::Init ] → [@ mozilla::layers::CompositorManagerChild::Init ]
[@ mozilla::layers::CompositorBridgeParent::InitSameProcess ]
|
|
Assignee | |
Comment 1•7 years ago
|
||
I think this should put the nail in the coffin for the restart-related crashes we are seeing. try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3e48e32a4c712a15a656a4a389e26e1c060d2caf
Attachment #8880402 -
Flags: review?(dvander)
|
|
Assignee | |
Comment 2•7 years ago
|
||
I should also note that the previous race between CompositorBridgeChild::ActorDestroy and GPUChild::ActorDestroy also existed prior to bug 1373540. However since it always created a new top-level protocol for each compositor, it wasn't a problem, since it didn't care about the previous state. With CompositorManagerChild, we *do* care, and that's where the problems arose from.
|
||
Comment 3•7 years ago
|
||
Adding topcrash keyword. After 20170621102301 and the fix for Bug 1373540 there are still a few hundred crashes, so that puts this signature at the top part of crash-stats.
Keywords: topcrash
Attachment #8880402 -
Flags: review?(dvander) → review+
Pushed by aosmond@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/b59e819dfaa5 Fix a race condition between GPUChild and CompositorManagerChild when the GPU process crashes. r=dvander
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/b59e819dfaa5
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
|
||
Updated•7 years ago
|
status-firefox54:
--- → unaffected
status-firefox55:
--- → unaffected
status-firefox-esr52:
--- → unaffected
You need to log in
before you can comment on or make changes to this bug.
Description
•