Closed Bug 1374317 Opened 4 years ago Closed 4 years ago

Mark layers-specific reftests as random-if with webrender

Categories

(Core :: Graphics: WebRender, enhancement, P3)

Other Branch
enhancement

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: kats, Assigned: kats)

References

Details

(Whiteboard: [gfx-noted])

Attachments

(1 file)

There are a variety of reftests that test things specific to layers (e.g. certain layers are opaque, or certain elements end up on the same layer). With WebRender enabled these tests aren't really valid because we layerize things a lot more and will continue to do so. For the most part any failures in these types of tests are going to be WONTFIX because we don't care to keep the same layerization as in the non-webrender codepath.

Therefore, I'd like to mark these tests as random-if(webrender). That way we still catch *crash* regressions on these tests, but allow any other result as a pass.
Comment on attachment 8879180 [details]
Bug 1374317 - Mark some layers-specific tests as random-if when WebRender is enabled.

https://reviewboard.mozilla.org/r/150522/#review155238

::: layout/reftests/invalidation/reftest.list:56
(Diff revision 1)
> -fails-if(webrender) != nudge-to-integer-invalidation.html about:blank
> -fails-if(webrender) != nudge-to-integer-invalidation.html?reverse about:blank
> -fails-if(webrender) skip-if(styloVsGecko) != clipped-animated-transform-1.html about:blank # Bug 1352628 (styloVsGecko)
> -fails-if(webrender) != paintedlayer-recycling-1.html about:blank
> -fails-if(webrender) != paintedlayer-recycling-2.html about:blank
> -pref(layers.single-tile.enabled,false) fails-if(webrender) != paintedlayer-recycling-3.html about:blank
> +random-if(webrender) != inactive-layertree-visible-region-1.html about:blank
> +random-if(webrender) != inactive-layertree-visible-region-2.html about:blank
> +random-if(webrender) != transform-floating-point-invalidation.html about:blank
> +random-if(webrender) != transform-floating-point-invalidation.html?reverse about:blank
> +random-if(webrender) != nudge-to-integer-invalidation.html about:blank
> +random-if(webrender) != nudge-to-integer-invalidation.html?reverse about:blank

reftest-no-paint tests are still meaningful with webrender, aren't they?
Attachment #8879180 - Flags: review?(mstange) → review+
Comment on attachment 8879180 [details]
Bug 1374317 - Mark some layers-specific tests as random-if when WebRender is enabled.

https://reviewboard.mozilla.org/r/150522/#review155238

> reftest-no-paint tests are still meaningful with webrender, aren't they?

Hm, yeah, that's true. Ok, I'll restore those tests back to fails-if.
Comment on attachment 8879180 [details]
Bug 1374317 - Mark some layers-specific tests as random-if when WebRender is enabled.

https://reviewboard.mozilla.org/r/150522/#review155238

> Hm, yeah, that's true. Ok, I'll restore those tests back to fails-if.

Actually I guess in some cases (e.g. paintedlayer-recycling-1.html) the test assumes that certain content will end up in a painted layer. That may not be the case with WR because we might put it in one of the advanced layer types that is destroyed and recreated cheaply.
The updated patch keeps fails-if for most of the things in layout/reftests/invalidation/ but uses random-if for the paintedlayer-recycling-* and the layer-splitting-* tests because those I'm fairly sure are assuming things about content going into painted layers. The rest I'm not too sure about so I erred on the side of caution for now.
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b754da0e673a
Mark some layers-specific tests as random-if when WebRender is enabled. r=mstange
https://hg.mozilla.org/mozilla-central/rev/b754da0e673a
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.