Closed
Bug 1374319
Opened 7 years ago
Closed 7 years ago
Bug 1366837 broke about:support on non-Windows OSes
Categories
(Core :: Disability Access APIs, enhancement)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
mozilla56
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | fixed |
People
(Reporter: jld, Assigned: eeejay)
References
Details
Attachments
(1 file)
|
1.12 KB,
patch
|
gasolin
:
review+
|
Details | Diff | Splinter Review |
There's a small bug in the patch for bug 1366837: the <td id="a11y-handler-used"> exists only on Windows, but the script tries to access it everywhere. This throws an exception because `null` doesn't have a textContent property, and then none of the formatters after "accessibility" are called (e.g., "sandbox").
|
Assignee | |
Comment 2•7 years ago
|
||
Attachment #8879190 -
Flags: review?(gasolin)
|
||
Comment 3•7 years ago
|
||
Comment on attachment 8879190 [details] [diff] [review] Check if #a11y-handler-used is in about:support before assigning text to it. r?gasolin thanks!
Attachment #8879190 -
Flags: review?(gasolin) → review+
Pushed by eisaacson@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/58c906e6bb42 Check if #a11y-handler-used is in about:support before assigning text to it. r=gasolin
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/58c906e6bb42
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•