1374351 - Update platform names for cross-compiled OSX builds

Status: RESOLVED FIXED

(Release Engineering :: General, enhancement, P2)

Description

[Chris AtLee [:catlee]]

Attachment: osx-cross.diff

We should use something like "OS X Cross Compiled" and "osx-cross" for the platform names instead of "OS X 10.7" or osx-10.7.

Comment 1

[Chris AtLee [:catlee]]

Attachment: PR for updating treeherder with new names

Comment 2

[Cameron Dawson [:camd]]

Comment on attachment 8879244 [details]
PR for updating treeherder with new names

Please let me know if you need me to merge this.  Otherwise, please feel free to do so yourself.  :)

Comment 3

[GitHub Autolander Bot]

Attachment: [treeherder] catlee:patch-1 > mozilla:master

Comment 4

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/8a43fa9a0c0101ab7250211087de60ea2528c710
Bug 1374351 - Add platform names for cross compiled OSX builds (#2578)

Comment 5

[Ed Morley [:emorley]]

(In reply to Cameron Dawson [:camd] from comment #2)
> Please let me know if you need me to merge this.  Otherwise, please feel
> free to do so yourself.  :)

95% of the time, if someone isn't a core-dev they (by design) won't have push access to the repo. The list of people with permissions is available here:
https://github.com/orgs/mozilla/teams/treeherder/members

I've merged this now (also fixed up the commit message to include the bug number via the github squash+merge message edit feature). It will be on stage within a few minutes, and prod as of the next deploy (few days to a week depending on what else is going on).

Thank you for the PR :-)

Comment 6

[Chris AtLee [:catlee]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d8db54bbe627

Comment 7

[Chris AtLee [:catlee]]

(In reply to Treeherder Bugbot from comment #4)
> Commit pushed to master at https://github.com/mozilla/treeherder
> 
> https://github.com/mozilla/treeherder/commit/
> 8a43fa9a0c0101ab7250211087de60ea2528c710
> Bug 1374351 - Add platform names for cross compiled OSX builds (#2578)

Ed, can you let me know when this is deployed to production?

Comment 8

[Ed Morley [:emorley]]

I've started a production deploy now, CI and subsequent build should finish shortly (watch for heroku bot announcement in #treeherder).

Comment 9

[Chris AtLee [:catlee]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=df484502f2b7

Comment 10

[Chris AtLee [:catlee]]

Attachment: Bug 1374351: Update platform names for cross-compiled OSX builds

Review commit: https://reviewboard.mozilla.org/r/154218/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/154218/

Comment 11

[Justin Wood (:Callek)]

Comment on attachment 8883319 [details]
Bug 1374351: Update platform names for cross-compiled OSX builds

https://reviewboard.mozilla.org/r/154218/#review159600

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/77acba0717ca
Update platform names for cross-compiled OSX builds r=Callek

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/77acba0717ca