Closed Bug 1374389 Opened 6 years ago Closed 6 years ago

fatal error C1128: number of sections exceeded object file format limit: compile with /bigobj

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox56 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla56
Tracking Flags:
Tracking Status
firefox56 --- fixed

People

(Reporter: jya, Assigned: jya)

References

Details

Attachments

(1 file)

Bug 1374389: Prevent compilation error due to object size being too big.
59 bytes, text/x-review-board-request
glandium
: review+
Details 
Attempting to compile my current tree (with local changes).

64 bits build, debug

0:42.83 c:\Users\jyavenard\Work\Mozilla\obj-ff-dbg\dom\media\Unified_cpp_dom_media1.cpp : fatal error C1128: number of sections exceeded object file format limit: compile with /bigobj
 0:42.83 mozmake.EXE[5]: *** [c:/Users/jyavenard/Work/Mozilla/mozilla-central/config/rules.mk:1012: Unified_cpp_dom_media1.obj] Error 1
 0:42.83 mozmake.EXE[4]: *** [c:/Users/jyavenard/Work/Mozilla/mozilla-central/config/recurse.mk:73: dom/media/target] Error 2
 0:42.83 mozmake.EXE[4]: *** Waiting for unfinished jobs....
Comment on attachment 8879288 [details]
Bug 1374389: Prevent compilation error due to object size being too big.

https://reviewboard.mozilla.org/r/150570/#review155504

::: dom/media/moz.build:335
(Diff revision 2)
>  if CONFIG['_MSC_VER']:
>      # This is intended as a temporary workaround to unblock compilation
>      # on VS2015 in warnings as errors mode.
> -    CXXFLAGS += ['-wd4312']
> +    CXXFLAGS += [
> +        '-wd4312',
> +        '-bigobj',

Other than the fact that this needs its own comment as for why it's there (and be desolidarized from the warning flag), this brings the question whether this just doesn't mean we should reduce the number of files in unified compiles in this directory. (i.e. setting FILES_PER_UNIFIED_FILE to a value smaller than 16)
Attachment #8879288 - Flags: review?(mh+mozilla)
Assignee: nobody → jyavenard
Comment on attachment 8879288 [details]
Bug 1374389: Prevent compilation error due to object size being too big.

https://reviewboard.mozilla.org/r/150570/#review155512
Attachment #8879288 - Flags: review?(mh+mozilla) → review+
Pushed by jyavenard@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/370492d1bc69
Prevent compilation error due to object size being too big. r=glandium
Backout by cbook@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6e1ff77dd9a1
Backed out changeset 370492d1bc69 for bustage
jya: very sorry for this, but this had also to be backed out for bustage like https://treeherder.mozilla.org/logviewer.html#?job_id=108459918&repo=autoland
Flags: needinfo?(jyavenard)
yes, working on it, in bug 1374596
Flags: needinfo?(jyavenard)
Pushed by jyavenard@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/80c24b58dde8
Prevent compilation error due to object size being too big. r=glandium
https://hg.mozilla.org/mozilla-central/rev/80c24b58dde8
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Depends on: 1375398
Product: Core → Firefox Build System
Blocks: 1649540
You need to log in before you can comment on or make changes to this bug.