Closed Bug 1374453 Opened 4 years ago Closed 4 years ago

Turn HSTS priming on in Beta for 56

Categories

(Core :: DOM: Security, defect, P1)

56 Branch
defect

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: kmckinley, Assigned: kmckinley)

References

Details

(Whiteboard: [domsecurity-active])

Attachments

(1 file)

Flip the relevant preferences to default true in Beta, but not release for 56.

security.mixed_content.send_hsts_priming
security.mixed_content.use_hsts
Comment on attachment 8879312 [details]
Bug 1374453 - turn HSTS priming on in Beta

https://reviewboard.mozilla.org/r/150594/#review155526

r-me
Attachment #8879312 - Flags: review?(ckerschb) → review+
Priority: -- → P1
Whiteboard: [domsecurity-active]
Pushed by kmckinley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d1baa480be09
turn HSTS priming on in Beta r=ckerschb
https://hg.mozilla.org/mozilla-central/rev/d1baa480be09
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
AFAIK the RELEASE macro is never defined so this patch will end up enabling hsts priming in 56 release.  (beta and release use the same configuration, though you can use EARLY_BETA_OR_EARLIER which is defined in the first few weeks of beta).
Flags: needinfo?(kmckinley)
(In reply to Julien Cristau [:jcristau] from comment #6)
> AFAIK the RELEASE macro is never defined so this patch will end up enabling
> hsts priming in 56 release.  (beta and release use the same configuration,
> though you can use EARLY_BETA_OR_EARLIER which is defined in the first few
> weeks of beta).

Ah, great catch and thanks for catching that - Kate, we need to update that ASAP.
Created Bug 1385035 for the fix.
Depends on: 1385035
Flags: needinfo?(kmckinley)
You need to log in before you can comment on or make changes to this bug.