1374457 - Key cached manifest data by add-on version

Status: RESOLVED FIXED

(WebExtensions :: General, enhancement)

Comment 1

[Kris Maglione [:kmag]]

Attachment: Bug 1374457: Key cached manifest and locale data by add-on version.

Review commit: https://reviewboard.mozilla.org/r/150598/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/150598/

Comment 2

[Robert Helmer [:rhelmer]]

Comment on attachment 8879315 [details]
Bug 1374457: Key cached manifest and locale data by add-on version.

https://reviewboard.mozilla.org/r/150598/#review155346

lgtm - is there/should there be a test though?

Comment 3

[Kris Maglione [:kmag]]

Comment on attachment 8879315 [details]
Bug 1374457: Key cached manifest and locale data by add-on version.

https://reviewboard.mozilla.org/r/150598/#review155346

I don't think so. In general, I prefer to test behavior rather than implementation, and given that we try to flush add-on cache data whenever the version changes, anyway, this shouldn't have any external effects that we can test.

Comment 4

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d1970a5ac27cda1be85e82494281850a93d03091
Bug 1374457: Key cached manifest and locale data by add-on version. r=rhelmer

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d1970a5ac27c

Comment 6

[Kris Maglione [:kmag]]

Comment on attachment 8879315 [details]
Bug 1374457: Key cached manifest and locale data by add-on version.

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1368152
[User impact if declined]: This issue causes unpredictable problems when side-loaded and bundled system extensions are updated between browser sessions.
[Is this code covered by automated tests?]: Yes.
[Has the fix been verified in Nightly?]: No.
[Needs manual test from QE? If yes, steps to reproduce]: The Screenshots team should verify, though they have a separate workaround now.
[List of other uplifts needed for the feature/fix]: None.
[Is the change risky?]: No.
[Why is the change risky/not risky?]: It simply adds another element to a cache key to ensure data consistency.
[String changes made/needed]: None.

Comment 7

[Julien Cristau [:jcristau]]

Comment on attachment 8879315 [details]
Bug 1374457: Key cached manifest and locale data by add-on version.

add add-on version to cache key, beta55+

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/bd2df31d88f0