Closed Bug 1374457 Opened 4 years ago Closed 4 years ago

Key cached manifest data by add-on version

Categories

(WebExtensions :: General, enhancement)

enhancement
Not set
normal

Tracking

(firefox55 fixed, firefox56 fixed)

RESOLVED FIXED
mozilla56
Tracking Status
firefox55 --- fixed
firefox56 --- fixed

People

(Reporter: kmag, Assigned: kmag)

Details

Attachments

(1 file)

No description provided.
Comment on attachment 8879315 [details]
Bug 1374457: Key cached manifest and locale data by add-on version.

https://reviewboard.mozilla.org/r/150598/#review155346

lgtm - is there/should there be a test though?
Attachment #8879315 - Flags: review?(rhelmer) → review+
Comment on attachment 8879315 [details]
Bug 1374457: Key cached manifest and locale data by add-on version.

https://reviewboard.mozilla.org/r/150598/#review155346

I don't think so. In general, I prefer to test behavior rather than implementation, and given that we try to flush add-on cache data whenever the version changes, anyway, this shouldn't have any external effects that we can test.
https://hg.mozilla.org/integration/mozilla-inbound/rev/d1970a5ac27cda1be85e82494281850a93d03091
Bug 1374457: Key cached manifest and locale data by add-on version. r=rhelmer
https://hg.mozilla.org/mozilla-central/rev/d1970a5ac27c
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Comment on attachment 8879315 [details]
Bug 1374457: Key cached manifest and locale data by add-on version.

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1368152
[User impact if declined]: This issue causes unpredictable problems when side-loaded and bundled system extensions are updated between browser sessions.
[Is this code covered by automated tests?]: Yes.
[Has the fix been verified in Nightly?]: No.
[Needs manual test from QE? If yes, steps to reproduce]: The Screenshots team should verify, though they have a separate workaround now.
[List of other uplifts needed for the feature/fix]: None.
[Is the change risky?]: No.
[Why is the change risky/not risky?]: It simply adds another element to a cache key to ensure data consistency.
[String changes made/needed]: None.
Attachment #8879315 - Flags: approval-mozilla-beta?
Comment on attachment 8879315 [details]
Bug 1374457: Key cached manifest and locale data by add-on version.

add add-on version to cache key, beta55+
Attachment #8879315 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.