Closed
Bug 1374457
Opened 7 years ago
Closed 7 years ago
Key cached manifest data by add-on version
Categories
(WebExtensions :: General, enhancement)
WebExtensions
General
Tracking
(firefox55 fixed, firefox56 fixed)
RESOLVED
FIXED
mozilla56
People
(Reporter: kmag, Assigned: kmag)
Details
Attachments
(1 file)
59 bytes,
text/x-review-board-request
|
rhelmer
:
review+
jcristau
:
approval-mozilla-beta+
|
Details |
No description provided.
Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8879315 [details] Bug 1374457: Key cached manifest and locale data by add-on version. https://reviewboard.mozilla.org/r/150598/#review155346 lgtm - is there/should there be a test though?
Attachment #8879315 -
Flags: review?(rhelmer) → review+
Assignee | ||
Comment 3•7 years ago
|
||
mozreview-review-reply |
Comment on attachment 8879315 [details] Bug 1374457: Key cached manifest and locale data by add-on version. https://reviewboard.mozilla.org/r/150598/#review155346 I don't think so. In general, I prefer to test behavior rather than implementation, and given that we try to flush add-on cache data whenever the version changes, anyway, this shouldn't have any external effects that we can test.
Assignee | ||
Comment 4•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/d1970a5ac27cda1be85e82494281850a93d03091 Bug 1374457: Key cached manifest and locale data by add-on version. r=rhelmer
Comment 5•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/d1970a5ac27c
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Assignee | ||
Comment 6•7 years ago
|
||
Comment on attachment 8879315 [details] Bug 1374457: Key cached manifest and locale data by add-on version. Approval Request Comment [Feature/Bug causing the regression]: Bug 1368152 [User impact if declined]: This issue causes unpredictable problems when side-loaded and bundled system extensions are updated between browser sessions. [Is this code covered by automated tests?]: Yes. [Has the fix been verified in Nightly?]: No. [Needs manual test from QE? If yes, steps to reproduce]: The Screenshots team should verify, though they have a separate workaround now. [List of other uplifts needed for the feature/fix]: None. [Is the change risky?]: No. [Why is the change risky/not risky?]: It simply adds another element to a cache key to ensure data consistency. [String changes made/needed]: None.
Attachment #8879315 -
Flags: approval-mozilla-beta?
Comment 7•7 years ago
|
||
Comment on attachment 8879315 [details] Bug 1374457: Key cached manifest and locale data by add-on version. add add-on version to cache key, beta55+
Attachment #8879315 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 8•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/bd2df31d88f0
status-firefox55:
--- → fixed
Updated•6 years ago
|
Product: Toolkit → WebExtensions
You need to log in
before you can comment on or make changes to this bug.
Description
•