Closed
Bug 1374463
Opened 7 years ago
Closed 7 years ago
Identity drop down not shown on newtab or home page overrides
Categories
(WebExtensions :: Frontend, defect, P3)
WebExtensions
Frontend
Tracking
(firefox57 verified, firefox58 verified)
VERIFIED
FIXED
mozilla57
People
(Reporter: andy+bugzilla, Assigned: mstriemer)
References
Details
(Whiteboard: [triaged])
Attachments
(4 files)
In bug 1266012 we populated the identity drop down with information about the add-on. This doesn't work if you override the newtab page or home. As an example, I've attached a picture of the top-sites example WebExtension: https://github.com/mdn/webextensions-examples/tree/master/top-sites Ideally we should get this working before finishing bug 1372996.
Reporter | ||
Updated•7 years ago
|
Whiteboard: [triaged]
Reporter | ||
Updated•7 years ago
|
Assignee: nobody → mstriemer
Comment hidden (mozreview-request) |
Assignee | ||
Comment 2•7 years ago
|
||
Assignee | ||
Comment 3•7 years ago
|
||
I couldn't find any tests closer to browser.js that test the identity area, so I just added the test next to the extensions code that was testing it.
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8903627 [details] Bug 1374463 - Show extension identity when controlling newtab https://reviewboard.mozilla.org/r/175394/#review180538 r+ if my comment is not an issue. ::: browser/base/content/browser.js:2768 (Diff revision 1) > } catch (ex) { > value = "about:blank"; > } > } > > - valid = !isBlankPageURL(uri.spec); > + valid = !isBlankPageURL(uri.spec) || uri.schemeIs("moz-extension"); Have you looked to see if other uses of isBlankPageURL also need to be special cased for moz-extension? If so, maybe do the check inside isBlankPageURL.
Attachment #8903627 -
Flags: review?(mixedpuppy) → review+
Assignee | ||
Comment 5•7 years ago
|
||
mozreview-review-reply |
Comment on attachment 8903627 [details] Bug 1374463 - Show extension identity when controlling newtab https://reviewboard.mozilla.org/r/175394/#review180538 > Have you looked to see if other uses of isBlankPageURL also need to be special cased for moz-extension? If so, maybe do the check inside isBlankPageURL. We're flipping this boolean for the case where the new tab page is from an extension, so we don't want to put it in `isBlankPageURL`. Old behavior is "show search icon instead of identity if it's a blank page", but we only want that if it's a blank page provided by Firefox rather than an extension.
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/autoland/rev/f77d12a3fc03 Show extension identity when controlling newtab r=mixedpuppy
Keywords: checkin-needed
Comment 7•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/f77d12a3fc03
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
I can reproduce this issue on Firefox 56.0.2 (20171024165158) under Wind 7 64-bit. This issue is verified as fixed on Firefox 57.0b12 (20171026211016) and Firefox 58.0a1 (20171026221945) under Wind 7 64-bit and Mac OS X 10.13. The identity drop down has included information about the extension. Please see the attached video.
Updated•6 years ago
|
Product: Toolkit → WebExtensions
You need to log in
before you can comment on or make changes to this bug.
Description
•