Webrtc video inbound-rtp does not include framesDecoded

RESOLVED FIXED in Firefox 56

Status

()

P1
normal
Rank:
15
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: lindsey, Assigned: ng)

Tracking

56 Branch
mozilla56
Points:
---

Firefox Tracking Flags

(firefox56 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

a year ago
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.110 Safari/537.36

Steps to reproduce:

Viewing webrtc stats on https://webrtc.github.io/samples/src/content/peerconnection/constraints/ for example


Actual results:

Video inbound-rtp does not include framesDecoded
Component: Untriaged → WebRTC
Product: Firefox → Core
Status: UNCONFIRMED → NEW
Rank: 15
Ever confirmed: true
Priority: -- → P1
(Assignee)

Comment 1

a year ago
The framesDecoded field is not being populated. This shouldn't be hard to wire up.
Assignee: nobody → na-g
Flags: needinfo?(na-g)
Comment hidden (mozreview-request)

Comment 3

a year ago
mozreview-review
Comment on attachment 8883102 [details]
Bug 1374465 - add framesDecoded to vid inbound stream stats;

https://reviewboard.mozilla.org/r/154054/#review159634

Lgtm with nit.

::: media/webrtc/signaling/src/media-conduit/VideoConduit.h:398
(Diff revision 1)
>       * Returns the number of discarded packets
>       * @param aOutDiscPackets: number of discarded packets
>       */
>      void DiscardedPackets(uint32_t& aOutDiscPackets) const;
> +   /**
> +    * Returns the number of discarded packets
> +    * @param aOutDiscPackets: number of discarded packets

Copy, paste... then update. ;)
Attachment #8883102 - Flags: review?(jib) → review+
Comment hidden (mozreview-request)

Comment 5

a year ago
hg error in cmd: hg push -r tip ssh://hg.mozilla.org/integration/autoland: pushing to ssh://hg.mozilla.org/integration/autoland
searching for changes
remote: adding changesets
remote: adding manifests
remote: adding file changes
remote: added 1 changesets with 8 changes to 8 files
remote: 
remote: WebIDL file dom/webidl/RTCStatsReport.webidl altered in changeset bc54c166c484 without DOM peer review
remote: 
remote: 
remote: 
remote: ************************** ERROR ****************************
remote: 
remote: Changes to WebIDL files in this repo require review from a DOM peer in the form of r=...
remote: This is to ensure that we behave responsibly with exposing new Web APIs. We appreciate your understanding..
remote: 
remote: *************************************************************
remote: 
remote: 
remote: transaction abort!
remote: rollback completed
remote: pretxnchangegroup.d_webidl hook failed
abort: push failed on remote
(Assignee)

Comment 6

a year ago
WebIDL review information:
Stats object in spec: https://w3c.github.io/webrtc-stats/#dom-rtcinboundrtpstreamstats
Field added to stats object in spec: https://w3c.github.io/webrtc-stats/#dom-rtcinboundrtpstreamstats-framesdecoded
Flags: needinfo?(na-g)

Comment 8

a year ago
Pushed by na-g@nostrum.com:
https://hg.mozilla.org/integration/autoland/rev/1857295539b2
add framesDecoded to vid inbound stream stats;r=jib,smaug

Comment 9

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/1857295539b2
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.