filters.tests.js 'initials filter' test fails after bug 1367867

RESOLVED FIXED

Status

Tree Management
Treeherder
P1
normal
RESOLVED FIXED
8 months ago
8 months ago

People

(Reporter: emorley, Assigned: KWierso)

Tracking

Details

Attachments

(1 attachment)

(Reporter)

Description

8 months ago
Travis is currently reporting the JS job as passing, even though tests within are failing, soon to be fixed in bug 1364030.

As part of that, we need to green up currently failing tests, which includes filter.tests.js's 'initials filter' tests, which are failing due to the changes in bug 1367867:

```
Firefox 54.0.0 (Linux 0.0.0) initials filter initializes a one-word name FAILED
	Expected '<span class="user-push-icon"><i class="fa fa-user-o" aria-hidden="true"></i></span><div class="icon-superscript user-push-initials">S</div>' to equal '<span class="label label-initials">S</span>'.

Firefox 54.0.0 (Linux 0.0.0) initials filter initializes a two-word name FAILED
	Expected '<span class="user-push-icon"><i class="fa fa-user-o" aria-hidden="true"></i></span><div class="icon-superscript user-push-initials">OP</div>' to equal '<span class="label label-initials">OP</span>'.

Firefox 54.0.0 (Linux 0.0.0) initials filter initializes a three-word name FAILED
	Expected '<span class="user-push-icon"><i class="fa fa-user-o" aria-hidden="true"></i></span><div class="icon-superscript user-push-initials">ST</div>' to equal '<span class="label label-initials">ST</span>'.
```
(See: https://travis-ci.org/mozilla/treeherder/jobs/244709749#L431)

The test needs updating here:
https://github.com/mozilla/treeherder/blob/58186479d313d37fd5052e8416bfc35523f112b5/tests/ui/unit/filters.tests.js#L48-L69

I wonder as well whether it's worth factoring out the markup parts?

Comment 1

8 months ago
Created attachment 8879361 [details] [review]
[treeherder] KWierso:fixfiltertests > mozilla:master
(Assignee)

Comment 2

8 months ago
Comment on attachment 8879361 [details] [review]
[treeherder] KWierso:fixfiltertests > mozilla:master

Someone else can work on a refactor if that's actually needed, but this gets the tests passing.
Attachment #8879361 - Flags: review?(emorley)
Thanks for sleuthing this out Ed and Wes. I/we just saw Travis passing in bug 1367867 so it never occurred to me.
(Reporter)

Comment 4

8 months ago
Comment on attachment 8879361 [details] [review]
[treeherder] KWierso:fixfiltertests > mozilla:master

Many thanks Wes! 

(In reply to Jonathan French (:jfrench) from comment #3)
> Thanks for sleuthing this out Ed and Wes. I/we just saw Travis passing in
> bug 1367867 so it never occurred to me.

Yeah I wouldn't expect people to check a green Travis job, so not your fault :-)
Attachment #8879361 - Flags: review?(emorley) → review+

Comment 5

8 months ago
Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/71e8750fada92c47bd803e0a67eaf2916914ce1f
Bug 1374478 - Update initials filter tests (#2582)

Since they starting failing after bug 1367867.
(Reporter)

Updated

8 months ago
Assignee: nobody → wkocher
Status: NEW → RESOLVED
Last Resolved: 8 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.