1374492 - [Project Dawn] e10s gets disabled in DevEdition when a webextension is installed

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Blake Kaplan (:mrbkap) (inactive)]

See bug 1369399, comment 10.

This bug has two causes. One, that I'm going to fix here (there's another case of RELEASE_OR_BETA in firefox.js) and another that might require a followup bug. That is that XPIProvider.e10sBlocksEnabling returns *true* for webextensions (including the link cleaner). Felipe, is that intended?

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Bug 1374492 - Don't let extensions disable e10s in DevEdition.

Review commit: https://reviewboard.mozilla.org/r/150644/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/150644/

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Actually, my question in comment 0 is probably because I was stepping through the code in Nightly and DevEdition is on Aurora, neither of which has an ADDON_ROLLOUT_POLICY. This is working as intended – we should just skip the addon checks for DevEdition all together.

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 8879352 [details]
Bug 1374492 - Don't let extensions disable e10s in DevEdition.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/150644/diff/1-2/

Comment 4

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8879352 [details]
Bug 1374492 - Don't let extensions disable e10s in DevEdition.

https://reviewboard.mozilla.org/r/150644/#review156366

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5898d2436f40
Don't let extensions disable e10s in DevEdition. r=Felipe

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/5898d2436f40

Comment 7

[Kenny D]

So I looked at the patches and manually set `extensions.e10sBlocksEnabling` and `extensions.e10sMultiBlocksEnabling` to false so it has a `status: modified` attribute and that solved the restarting WebExtension issue for me. Thanks Blake! Hope this gets uplifted to DevEdition beta soon.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Please request Beta approval on this when you get a chance.

Comment 9

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 8879352 [details]
Bug 1374492 - Don't let extensions disable e10s in DevEdition.

Approval Request Comment
[Feature/Bug causing the regression]: Project dawn
[User impact if declined]: Webextensions (among others) will disable e10s on DevEdition.
[Is this code covered by automated tests?]: No :(
[Has the fix been verified in Nightly?]: Yes.
[Needs manual test from QE? If yes, steps to reproduce]: No.
[List of other uplifts needed for the feature/fix]: None.
[Is the change risky?]: No.
[Why is the change risky/not risky?]: It's restoring previous behavior.
[String changes made/needed]: n/a

Comment 10

[Julien Cristau [:jcristau]]

Comment on attachment 8879352 [details]
Bug 1374492 - Don't let extensions disable e10s in DevEdition.

enable e10s with webextensions in DevEdition builds, beta55+

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/5754e0bd12f5