If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

[Project Dawn] e10s gets disabled in DevEdition when a webextension is installed

RESOLVED FIXED in Firefox 55

Status

()

Firefox
General
RESOLVED FIXED
3 months ago
3 months ago

People

(Reporter: mrbkap, Assigned: mrbkap)

Tracking

({regression})

54 Branch
Firefox 56
Unspecified
Windows 10
regression
Points:
---

Firefox Tracking Flags

(firefox-esr52 unaffected, firefox54 wontfix, firefox55 fixed, firefox56 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

3 months ago
See bug 1369399, comment 10.

This bug has two causes. One, that I'm going to fix here (there's another case of RELEASE_OR_BETA in firefox.js) and another that might require a followup bug. That is that XPIProvider.e10sBlocksEnabling returns *true* for webextensions (including the link cleaner). Felipe, is that intended?
Flags: needinfo?(felipc)
(Assignee)

Updated

3 months ago
Assignee: nobody → mrbkap
Comment hidden (mozreview-request)
(Assignee)

Comment 2

3 months ago
Actually, my question in comment 0 is probably because I was stepping through the code in Nightly and DevEdition is on Aurora, neither of which has an ADDON_ROLLOUT_POLICY. This is working as intended – we should just skip the addon checks for DevEdition all together.
Flags: needinfo?(felipc)
Comment hidden (mozreview-request)
Comment on attachment 8879352 [details]
Bug 1374492 - Don't let extensions disable e10s in DevEdition.

https://reviewboard.mozilla.org/r/150644/#review156366
Attachment #8879352 - Flags: review?(felipc) → review+

Comment 5

3 months ago
Pushed by mrbkap@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5898d2436f40
Don't let extensions disable e10s in DevEdition. r=Felipe

Comment 6

3 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/5898d2436f40
Status: NEW → RESOLVED
Last Resolved: 3 months ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56

Comment 7

3 months ago
So I looked at the patches and manually set `extensions.e10sBlocksEnabling` and `extensions.e10sMultiBlocksEnabling` to false so it has a `status: modified` attribute and that solved the restarting WebExtension issue for me. Thanks Blake! Hope this gets uplifted to DevEdition beta soon.
Please request Beta approval on this when you get a chance.
status-firefox54: --- → wontfix
status-firefox55: --- → affected
status-firefox-esr52: --- → unaffected
Flags: needinfo?(mrbkap)
(Assignee)

Comment 9

3 months ago
Comment on attachment 8879352 [details]
Bug 1374492 - Don't let extensions disable e10s in DevEdition.

Approval Request Comment
[Feature/Bug causing the regression]: Project dawn
[User impact if declined]: Webextensions (among others) will disable e10s on DevEdition.
[Is this code covered by automated tests?]: No :(
[Has the fix been verified in Nightly?]: Yes.
[Needs manual test from QE? If yes, steps to reproduce]: No.
[List of other uplifts needed for the feature/fix]: None.
[Is the change risky?]: No.
[Why is the change risky/not risky?]: It's restoring previous behavior.
[String changes made/needed]: n/a
Flags: needinfo?(mrbkap)
Attachment #8879352 - Flags: approval-mozilla-beta?
Comment on attachment 8879352 [details]
Bug 1374492 - Don't let extensions disable e10s in DevEdition.

enable e10s with webextensions in DevEdition builds, beta55+
Attachment #8879352 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Comment 11

3 months ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-beta/rev/5754e0bd12f5
status-firefox55: affected → fixed
You need to log in before you can comment on or make changes to this bug.