[Project Dawn] e10s gets disabled in DevEdition when a webextension is installed

RESOLVED FIXED in Firefox 55



2 years ago
2 years ago


(Reporter: mrbkap, Assigned: mrbkap)



54 Branch
Firefox 56
Windows 10

Firefox Tracking Flags

(firefox-esr52 unaffected, firefox54 wontfix, firefox55 fixed, firefox56 fixed)



(1 attachment)

See bug 1369399, comment 10.

This bug has two causes. One, that I'm going to fix here (there's another case of RELEASE_OR_BETA in firefox.js) and another that might require a followup bug. That is that XPIProvider.e10sBlocksEnabling returns *true* for webextensions (including the link cleaner). Felipe, is that intended?
Flags: needinfo?(felipc)
Assignee: nobody → mrbkap
Comment hidden (mozreview-request)
Actually, my question in comment 0 is probably because I was stepping through the code in Nightly and DevEdition is on Aurora, neither of which has an ADDON_ROLLOUT_POLICY. This is working as intended – we should just skip the addon checks for DevEdition all together.
Flags: needinfo?(felipc)
Comment hidden (mozreview-request)

Comment 4

2 years ago
Comment on attachment 8879352 [details]
Bug 1374492 - Don't let extensions disable e10s in DevEdition.

Attachment #8879352 - Flags: review?(felipc) → review+

Comment 5

2 years ago
Pushed by mrbkap@mozilla.com:
Don't let extensions disable e10s in DevEdition. r=Felipe

Comment 6

2 years ago
Last Resolved: 2 years ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56

Comment 7

2 years ago
So I looked at the patches and manually set `extensions.e10sBlocksEnabling` and `extensions.e10sMultiBlocksEnabling` to false so it has a `status: modified` attribute and that solved the restarting WebExtension issue for me. Thanks Blake! Hope this gets uplifted to DevEdition beta soon.
Please request Beta approval on this when you get a chance.
status-firefox54: --- → wontfix
status-firefox55: --- → affected
status-firefox-esr52: --- → unaffected
Flags: needinfo?(mrbkap)
Comment on attachment 8879352 [details]
Bug 1374492 - Don't let extensions disable e10s in DevEdition.

Approval Request Comment
[Feature/Bug causing the regression]: Project dawn
[User impact if declined]: Webextensions (among others) will disable e10s on DevEdition.
[Is this code covered by automated tests?]: No :(
[Has the fix been verified in Nightly?]: Yes.
[Needs manual test from QE? If yes, steps to reproduce]: No.
[List of other uplifts needed for the feature/fix]: None.
[Is the change risky?]: No.
[Why is the change risky/not risky?]: It's restoring previous behavior.
[String changes made/needed]: n/a
Flags: needinfo?(mrbkap)
Attachment #8879352 - Flags: approval-mozilla-beta?
Comment on attachment 8879352 [details]
Bug 1374492 - Don't let extensions disable e10s in DevEdition.

enable e10s with webextensions in DevEdition builds, beta55+
Attachment #8879352 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Comment 11

2 years ago
status-firefox55: affected → fixed
You need to log in before you can comment on or make changes to this bug.