1374496 - Search suggestions tip overlaps the onboarding fox icon

Status: RESOLVED WONTFIX

(Firefox :: New Tab Page, defect, P1)

Description

[Dave Townsend [:mossop]]

Attachment: Screenshot

Discovered in a brand new profile, when I first opened a new tab I immediately saw the search suggestions tip which overlaps the fox icon making it less likely I'd see the onboarding flow.

Comment 1

[Francis Lee [:frlee]]

hi Michael, 

could you provide suggestion on this one?

thank you very much

Comment 2

[Verdi [:verdi] Best to slack me]

Attachment: Screen Shot 2017-06-20 at 3.28.01 PM.png

It looks like some of the time the page content is pushed down so it doesn't overlap. I'm not sure what causes it to not push down the page content. My guess is pushing the content down is the desired action and it should be fixed to happen all the time. That would solve our problem here.

Additionally, it might be better to either:
* Show this tip when we expand the address bar in the tour overlay instead of on the first new tab.
or 
* Show this tip in the overlay IN ADDITION to showing it on this first new tab.

Maybe this can be investigated if we have time.

Comment 3

[Francis Lee [:frlee]]

hi Michael,

1. which tour in the tour overlay you would like to associate with this tip?
2. could you please provide STR for your screen shot?
3. Per dev team's comment, changing tip showing timing could impact search bar team's feature. its high risk.

thank you very much

Comment 4

[Verdi [:verdi] Best to slack me]

(In reply to Francis Lee [:frlee] from comment #3)
> hi Michael,
> 
> 1. which tour in the tour overlay you would like to associate with this tip?

The 57 search tour.

> 2. could you please provide STR for your screen shot?

1. Install Nightly with a new profile
2. Open a new tab by clicking the + button

* A subsequent attempt resulted in the tip overlapping the fox icon.

> 3. Per dev team's comment, changing tip showing timing could impact search
> bar team's feature. its high risk.
> 

Yes. I'm investigating what the plans are for this feature and the intended UX to see what our options are.

Comment 5

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Attachment: pushup reason

By the Engineer team's triage, seems it's not the tooltip pushed down the viewport, but the global notification box, which is for showing some messages for about add-on. It happened that urlbar's tooltip covered it. If the notification dox doesn't shown or get closed, the fox icon got covered again. (Actually the notification box is not shown in mac version.)
The urlbar's tooltip is a popup panel which is designated to show over the original UI, so it may not be a trivial change to let it embed above the viewport to push down the webpage.

ni? Verdi for confirming this result. And if no additional possibilities we may just investigate the feasibility two suggestions in comment 2.

Comment 6

[[e-mail]]

Attachment: double the distance (30px -> 60px) to top

Since this issue block the QA signoff, we need to figure out the right UX ASAP.

If there's no final decision yet, does moving the icon far away from the top is an acceptable temp solution?


The screenshot moved fox icon double the distance (30px -> 60px) to the top and it won't be overlapped by search tips anymore.

Comment 7

[[e-mail]]

Attachment: ouble the distance (30px -> 48px) to top, without search tip pop

Here's another view after stretch the distance (30px -> 48px) to top, while search tip did not pop.

Comment 8

[[e-mail]]

Attachment: Bug 1374496 - move down the onboarding fox icon so Search suggestions tip wont overlaps the fox icon;

Review commit: https://reviewboard.mozilla.org/r/156460/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/156460/

Comment 9

[[e-mail]]

Attachment: move down the fox icon

I moved down the fox icon (30px -> 48px) so it won't be overlaped by search suggestions tip.

Comment 10

[[e-mail]]

From today's meeting, Peter(PM) said "just do it" so it wont block QA testing.
And we can still figure out other solution in the next version.

Comment 11

[Bryant Mao [:bryantmao]]

(In reply to Fred Lin [:gasolin] from comment #9)
> Created attachment 8885605 [details]
> move down the fox icon
> 
> I moved down the fox icon (30px -> 48px) so it won't be overlaped by search
> suggestions tip.

Personally, I think current position for the fox icon is fine. When two not-so-related messages are placed closely like that, at least one has to be in the foreground for the user to focus. It's also looking more visually balance by keeping the top and left padding the same for the icon.

Comment 12

[Dave Townsend [:mossop]]

Comment on attachment 8885601 [details]
Bug 1374496 - move down the onboarding fox icon so Search suggestions tip wont overlaps the fox icon;

https://reviewboard.mozilla.org/r/156460/#review162128

Comment 13

[[e-mail]]

(In reply to Bryant Mao [:bryantmao] from comment #11)
> (In reply to Fred Lin [:gasolin] from comment #9)
> > Created attachment 8885605 [details]
> > move down the fox icon
> > 
> > I moved down the fox icon (30px -> 48px) so it won't be overlaped by search
> > suggestions tip.
> 
> Personally, I think current position for the fox icon is fine. When two
> not-so-related messages are placed closely like that, at least one has to be
> in the foreground for the user to focus. It's also looking more visually
> balance by keeping the top and left padding the same for the icon.

Thanks for feedback, I'm fine to either land the patch or set this issue as won't fix.
let's wait Verdi's UI review.

Comment 14

[[e-mail]]

Verdi, how do you think about change the top distance?

Comment 15

[Verdi [:verdi] Best to slack me]

Peter and I talked this over and decided it would be best to leave the tour overlay icon at the top of the page as designed. I filed bug 1384050 to prevent the address bar from auto-expanding on focus so it doesn't overlay the tour icon.

Comment 16

[[e-mail]]

Thanks for making the decision, set this issue as WONTFIX