Closed
Bug 1374499
Opened 7 years ago
Closed 7 years ago
Increase number of shmems pre-allocated by PChromiumCDM.
Categories
(Core :: Audio/Video: GMP, enhancement)
Core
Audio/Video: GMP
Tracking
()
RESOLVED
FIXED
mozilla56
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | fixed |
People
(Reporter: cpearce, Assigned: cpearce)
Details
Attachments
(1 file)
I added telemetry to track the number of shmems used to ferry decoded video frames between the GMP and content process: https://mzl.la/2sQCN9O Currently we pre-allocate 4 shmems, which means about 88% of the time we've got enough shmems. We could pre-allocate more, and then we'd not have to take the slow path for transferring frames between the GMP and CDM process via non-shared memory while we recover from underestimating as often. Increasing our pre-allocation to 6 frames would get us to 97% coverage, and I think we can afford that; a 720p i420 frame has a size of about 1.15MB, and a 1080p frame is about 2.6MB.
| Comment hidden (mozreview-request) |
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8879362 [details] Bug 1374499 - Increase number of shmems pre-allocated by PChromiumCDM to 6. https://reviewboard.mozilla.org/r/150662/#review155390
Attachment #8879362 -
Flags: review?(gsquelart) → review+
Pushed by cpearce@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7abd82919be6 Increase number of shmems pre-allocated by PChromiumCDM to 6. r=gerald
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/7abd82919be6
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•