Closed
Bug 1374512
Opened 8 years ago
Closed 8 years ago
Reduce overhead of the profiler in builds that don't enable it
Categories
(Core :: Gecko Profiler, enhancement)
Core
Gecko Profiler
Tracking
()
RESOLVED
WONTFIX
People
(Reporter: n.nethercote, Assigned: n.nethercote)
Details
Attachments
(1 obsolete file)
There are some moderately hot profiler-related things that have a non-zero cost
(i.e. function calls) in builds that don't enable the profiler. This patch
makes them have a zero cost.
- It adds PROFILER_TRACING, which wraps AutoProfilerTracing.
- It adds PROFILER_THEAD_{SLEEP,WAKE}, which wrap
AutoProfilerThread{Sleep,Wake}.
- It defines those RAII classes only when MOZ_GECKO_PROFILER is defined.
- It wraps some code in layout/base/ with MOZ_GECKO_PROFILER guards.
|
Assignee | |
Comment 1•8 years ago
|
||
Attachment #8879399 -
Flags: review?(mstange)
|
|
Assignee | |
Comment 2•8 years ago
|
||
|
|
Assignee | |
Comment 3•8 years ago
|
||
Comment on attachment 8879399 [details] [diff] [review]
Reduce overhead of the profiler in builds that don't enable it
Actually, I have a plan to take this idea a lot further.
Attachment #8879399 -
Attachment is obsolete: true
Attachment #8879399 -
Flags: review?(mstange)
|
|
Assignee | |
Comment 4•8 years ago
|
||
mstange informed me that MOZ_GECKO_PROFILER is defined in all tier 1 builds, including release builds! I hadn't realised that. That fact makes this bug much less interesting.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•