1374550 - [Form Autofill] [non-e10s] The preview remains if click on other form's input while previewing

Status: NEW

(Toolkit :: Form Autofill, defect, P3)

Description

[Ray Lin[:ralin]]

STR:

0. add a profile for autofill feature
1. open https://luke-chang.github.io/autofill-demo/layout.html with [non-e10s]
2. focus on the organization input
3. press arrow down key to open popup
4. press arrow down key again to preview first profile
5. click on one of the input below "add new input" button

Expected result:
The preview should be dismissed once popup closed

Actual result:
The preview remains

Comment 1

[Ray Lin[:ralin]]

It's a timing issue for focused input. I think the focused input is changed before receiving the message can lead to this case, so we did clear the preview after popup closed, but for the wrong target(form).

http://searchfox.org/mozilla-central/rev/2bcd258281da848311769281daf735601685de2d/browser/extensions/formautofill/FormAutofillContent.jsm#260

Comment 2

[Luke Chang [:lchang] (inactive)]

Hi Joe,

This bug doesn't look like trivial and may need more time to investigate. Since Fx56 will be the last version that has non-e10s mode, I think Form Autofill probably doesn't need to be blocked by this issue. We can disable Form Autofill when detecting a user is using non-e10s mode. What do you think?

Comment 3

[Joe Cheng [:jcheng] (please needinfo)]

I believe we discussed this during one of our weekly meetings and decided to move forward as you suggested but deferring this to Cindy :)

Comment 4

[chsiang]

Agreed to this approach :)

Comment 5

[Luke Chang [:lchang] (inactive)]

Got it. Thanks.