Closed Bug 1374555 Opened 3 years ago Closed 2 years ago

Stop using <style scoped> in HTMLTooltip

Categories

(DevTools :: Framework, enhancement, P2)

enhancement

Tracking

(firefox56 fixed)

RESOLVED FIXED
Firefox 56
Tracking Status
firefox56 --- fixed

People

(Reporter: pbro, Assigned: jdescottes)

References

Details

Attachments

(2 files)

In bug 1291515, support for scoped stylesheets support is being removed for web content.
On the medium term, support for chrome content will also be removed.

See this thread: https://groups.google.com/forum/#!topic/mozilla.dev.platform/iBoROFkR9V8

DevTools uses a scoped stylesheet in its HTMLTooltip widget:
http://searchfox.org/mozilla-central/source/devtools/client/shared/widgets/tooltip/HTMLTooltip.js#643

We need to replace this with a normal, unscoped, stylesheet. One way is to use a unique ID to prefix all selectors in the stylesheet for example.
DevTools bug triage (filter on CLIMBING SHOES).
Priority: -- → P2
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Comment on attachment 8887675 [details]
Bug 1374555 - update HTMLTooltip stylesheets to use more specific selectors;

https://reviewboard.mozilla.org/r/158564/#review164664
Attachment #8887675 - Flags: review?(gl) → review+
Comment on attachment 8887676 [details]
Bug 1374555 - import all tooltip widgets stylesheets in tooltips.css;

https://reviewboard.mozilla.org/r/158566/#review164670
Attachment #8887676 - Flags: review?(gl) → review+
Thanks for the reviews! try was closed yesterday so just pushed now: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d6e39ccc6183f8a5d9a9a20bf13eeb7b6cc21773
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ef4584ec1fbf
update HTMLTooltip stylesheets to use more specific selectors;r=gl
https://hg.mozilla.org/integration/autoland/rev/9943df835008
import all tooltip widgets stylesheets in tooltips.css;r=gl
https://hg.mozilla.org/mozilla-central/rev/ef4584ec1fbf
https://hg.mozilla.org/mozilla-central/rev/9943df835008
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
Thanks for jumping on this Julian!
No longer blocks: 1345702
Blocks: 1444905
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.