1374572 - Crash in java.lang.NullPointerException: Attempt to invoke interface method ''android.os.IBinder org.mozilla.gecko.media.IMediaManager.asBinder()'' on a null object reference at org.mozilla.gecko.media.RemoteManager.release(RemoteManager.java)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Audio/Video, defect, P1)

Description

[Gerry Chang [:gchang]]

This bug was filed from the Socorro interface and is 
report bp-142fbe5e-be67-4254-a5f8-94e9d0170619.
=============================================================
Frame 	Module 	Signature 	Source
0 	libxul.so 	mozilla::java::CodecProxy::Release 	widget/android/jni/Accessors.h:59
1 	libxul.so 	mozilla::RemoteDataDecoder::ProcessShutdown 	dom/media/platforms/android/RemoteDataDecoder.cpp:568
2 	libxul.so 	mozilla::detail::ProxyRunnable<mozilla::MozPromise<bool, bool, false>, RefPtr<mozilla::MozPromise<bool, bool, false> > (mozilla::MediaDecoderReader::*)(), mozilla::MediaDecoderReader>::Run 	xpcom/threads/nsThreadUtils.h:855
3 	libxul.so 	mozilla::TaskQueue::Runner::Run 	xpcom/threads/TaskQueue.cpp:232
4 	libxul.so 	nsThreadPool::Run 	xpcom/threads/nsThreadPool.cpp:225
5 	libxul.so 	nsThread::ProcessNextEvent 	xpcom/threads/nsThread.cpp:1264
6 	libxul.so 	NS_ProcessNextEvent 	xpcom/threads/nsThreadUtils.cpp:389
7 	libxul.so 	mozilla::ipc::MessagePumpForNonMainThreads::Run 	ipc/glue/MessagePump.cpp:368
8 	libxul.so 	MessageLoop::Run 	ipc/chromium/src/base/message_loop.cc:231
9 	libxul.so 	nsThread::ThreadFunc 	xpcom/threads/nsThread.cpp:495
10 	libnss3.so 	_pt_root 	nsprpub/pr/src/pthreads/ptthread.c:216
Ø 11 	libc.so 	libc.so@0x40643 	
Ø 12 	libc.so 	libc.so@0x40623 	
Ø 13 	libc.so 	libc.so@0x40623 	
Ø 14 	libc.so 	libc.so@0x1a021 	
15 	libnss3.so 	_PR_CreateThread 	nsprpub/pr/src/pthreads/ptthread.c:541

This is #23 topcrash for firefox for android and there is a spike in the last 3 days.

Comment 1

[Julien Cristau [:jcristau]]

Sebastian can you help find someone to look at this?  It spiked after the 54 release and is still present in 55beta.

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

Setting triage flag for the mobile core browser team.

@alastor: It's in the media code - is this something you can look into?

Comment 3

[Blake Wu [:bwu][:blakewu]]

It looks like related to OOP decoding, so lets forward to jhlin.

Comment 4

[John Lin [:jhlin][:jolin]]

Attachment: Bug 1374572 - don't access disconnected remote binder.

Review commit: https://reviewboard.mozilla.org/r/158724/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/158724/

Comment 5

[John Lin [:jhlin][:jolin]]

It's caused by a bug that the remote link is not protected properly and when decoder shutting down at the same time remote process is dying, which is handled later will get NPE.

Comment 6

[Wesly Huang (EPM)]

[traige@0719] + as taken by Media team already with P1.

Comment 7

[Eugen Sawin [:esawin]]

Comment on attachment 8887814 [details]
Bug 1374572 - don't access disconnected remote binder.

https://reviewboard.mozilla.org/r/158724/#review164126

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1ec985416f30
don't access disconnected remote binder. r=esawin

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/1ec985416f30

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Please request Beta approval on this when you get a chance.

Comment 12

[John Lin [:jhlin][:jolin]]

Comment on attachment 8887814 [details]
Bug 1374572 - don't access disconnected remote binder.

Approval Request Comment
[Feature/Bug causing the regression]: bug 1257777
[User impact if declined]: browser crashes when remote process crash and decoder shutting down at the same time
[Is this code covered by automated tests?]:no
[Has the fix been verified in Nightly?]:yes
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]:none
[Is the change risky?]:low risk
[Why is the change risky/not risky?]:it protects data access from multiple threads
[String changes made/needed]:none

Comment 13

[Julien Cristau [:jcristau]]

Comment on attachment 8887814 [details]
Bug 1374572 - don't access disconnected remote binder.

fennec crash fix, beta55+

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/3d0ccc795265