Closed Bug 1374574 Opened 2 years ago Closed 2 years ago

Remove the Flyweb source from the tree

Categories

(Core Graveyard :: DOM: Flyweb, enhancement)

enhancement
Not set

Tracking

(firefox59 fixed)

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: jwatt, Assigned: johannh)

Details

Attachments

(3 files)

According to Kannan Flyweb is likely to be removed. Filing this bug to cover doing that.
The front-end code was implemented entirely as a System Add-on, so it can be removed very easily by getting rid of this line:

http://searchfox.org/mozilla-central/rev/1a4a26905f923458679a59a4be1e455ebc53c333/browser/extensions/moz.build#24

And then wiping out the flyweb subdirectory under browser/extensions.
Kannan, I removed the bare minimum of code that I could find is directly related to FlyWeb. It's very possible that I forgot to remove some interfaces that were only used by FlyWeb. If you can think of any I'd appreciate pointers.
Assignee: nobody → jhofmann
Status: NEW → ASSIGNED
Does this need an intent to unship?
Comment on attachment 8931105 [details]
Bug 1374574 - Remove the FlyWeb system add-on from Firefox.

https://reviewboard.mozilla.org/r/202186/#review207546

Thanks!
Attachment #8931105 - Flags: review?(mconley) → review+
Comment on attachment 8931107 [details]
Bug 1374574 - Remove the FlyWeb service and DOM interfaces.

https://reviewboard.mozilla.org/r/202190/#review207676
Attachment #8931107 - Flags: review?(bzbarsky) → review+
Comment on attachment 8931107 [details]
Bug 1374574 - Remove the FlyWeb service and DOM interfaces.

https://reviewboard.mozilla.org/r/202190/#review207890

Thank you for taking care of this.  Do you drink beer?  Are you coming to Austin?  Count me as owing you one beverage of your choice :)
Attachment #8931107 - Flags: review?(kvijayan) → review+
(In reply to Kannan Vijayan [:djvj] from comment #10)
> Comment on attachment 8931107 [details]
> Bug 1374574 - Remove the FlyWeb service and DOM interfaces.
> 
> https://reviewboard.mozilla.org/r/202190/#review207890
> 
> Thank you for taking care of this.  Do you drink beer?  Are you coming to
> Austin?  Count me as owing you one beverage of your choice :)

I'm coming to Austin and I will happily accept that offer! :D
Comment on attachment 8931106 [details]
Bug 1374574 - Remove the FlyWeb system add-on from Fennec.

https://reviewboard.mozilla.org/r/202188/#review208498

LGTM. Make sure to run on try before submitting : ).
Attachment #8931106 - Flags: review+
Comment on attachment 8931106 [details]
Bug 1374574 - Remove the FlyWeb system add-on from Fennec.

https://reviewboard.mozilla.org/r/202188/#review208498

Looks like I no longer have review powers, so you'll need to find another person. It might be worth trying maliu or nalexander.
Comment on attachment 8931106 [details]
Bug 1374574 - Remove the FlyWeb system add-on from Fennec.

https://reviewboard.mozilla.org/r/202188/#review208520
Attachment #8931106 - Flags: review?(s.kaspari) → review+
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 9f773aae403d -d 50ea7f713c35: rebasing 435957:9f773aae403d "Bug 1374574 - Remove the FlyWeb system add-on from Firefox. r=mconley"
merging testing/talos/talos/mtio-whitelist.json
merging testing/talos/talos/xtalos/xperf_whitelist.json
warning: conflicts while merging testing/talos/talos/mtio-whitelist.json! (edit, then use 'hg resolve --mark')
warning: conflicts while merging testing/talos/talos/xtalos/xperf_whitelist.json! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
Pushed by jhofmann@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/07ca590ac669
Remove the FlyWeb system add-on from Firefox. r=mconley
https://hg.mozilla.org/integration/autoland/rev/ff75ef015293
Remove the FlyWeb system add-on from Fennec. r=ahunt,sebastian
https://hg.mozilla.org/integration/autoland/rev/5a8a3d887e19
Remove the FlyWeb service and DOM interfaces. r=bz,djvj
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.