history toolbar button dropdown panel is too wide

VERIFIED FIXED in Firefox 56

Status

()

Firefox
Toolbars and Customization
P1
normal
VERIFIED FIXED
2 months ago
20 days ago

People

(Reporter: Alice0775 White, Assigned: Gijs)

Tracking

(Blocks: 2 bugs)

56 Branch
Firefox 56
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 unaffected, firefox56 verified)

Details

(Whiteboard: [photon-structure])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Reporter)

Description

2 months ago
Created attachment 8879504 [details]
screenshot

See attached screenshot.

STR:
1. Place History toolbar button on toolbar
2. Click it

AR:
The dropdown panel is too wide

ER:
It should be appropriate width
(Assignee)

Updated

2 months ago
Blocks: 1349210
No longer blocks: 1372309
Keywords: regression, uiwanted
Summary: history tookbar button dropdown panel is too wide → history toolbar button dropdown panel is too wide
Whiteboard: [photon-structure][triage]
Comment hidden (mozreview-request)
(Assignee)

Updated

2 months ago
Attachment #8880374 - Flags: review?(mdeboer)
Attachment #8880374 - Flags: review?(bbell)

Updated

2 months ago
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Iteration: --- → 56.1 - Jun 26
Flags: qe-verify+
Priority: -- → P1
QA Contact: gwimberly
Whiteboard: [photon-structure][triage] → [photon-structure]
(Assignee)

Comment 2

2 months ago
Pre-photon we're using 30em as the maximum width, so I'm assuming that just keeping that size is fine. Bryan, if you want builds to play with, they will appear here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=928df4818e2a

Comment 3

2 months ago
mozreview-review
Comment on attachment 8880374 [details]
Bug 1374603 - define a maximum width for panelviews, @mozilla.com,mikedeboer

https://reviewboard.mozilla.org/r/151742/#review156906

Looks good to me. 30em is a good place to start.

Comment 4

2 months ago
mozreview-review
Comment on attachment 8880374 [details]
Bug 1374603 - define a maximum width for panelviews, @mozilla.com,mikedeboer

https://reviewboard.mozilla.org/r/151744/#review157132

LGTM. Thanks!
Attachment #8880374 - Flags: review?(mdeboer) → review+

Comment 5

2 months ago
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/70fe3412c7db
define a maximum width for panelviews, r=bbell,mikedeboer

Comment 6

2 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/70fe3412c7db
Status: ASSIGNED → RESOLVED
Last Resolved: 2 months ago
status-firefox56: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
Verified on Windows, Mac, and Ubuntu.
Status: RESOLVED → VERIFIED
status-firefox56: fixed → verified
Flags: qe-verify+
Blocks: 1387512
You need to log in before you can comment on or make changes to this bug.