Closed Bug 1374603 Opened 4 years ago Closed 4 years ago

history toolbar button dropdown panel is too wide

Categories

(Firefox :: Toolbars and Customization, defect, P1)

Product:
Firefox
Component:
Toolbars and Customization
Version:
56 Branch
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 56
Iteration:
56.1 - Jun 26
Tracking Flags:
Tracking Status
firefox55 --- unaffected
firefox56 --- verified

People

(Reporter: alice0775, Assigned: Gijs)

References

(Blocks 1 open bug)

Details

(Whiteboard: [photon-structure])

Attachments

(2 files)

screenshot
88.80 KB, image/png
Details
Bug 1374603 - define a maximum width for panelviews, @mozilla.com,mikedeboer
59 bytes, text/x-review-board-request
bbell
: review+
mikedeboer
: review+
Details
Attached image screenshot — 
See attached screenshot.

STR:
1. Place History toolbar button on toolbar
2. Click it

AR:
The dropdown panel is too wide

ER:
It should be appropriate width
Blocks: photon-structure
No longer blocks: 1372309
Keywords: regression, uiwanted
Summary: history tookbar button dropdown panel is too wide → history toolbar button dropdown panel is too wide
Whiteboard: [photon-structure][triage]
Attachment #8880374 - Flags: review?(mdeboer)
Attachment #8880374 - Flags: review?(bbell)
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Iteration: --- → 56.1 - Jun 26
Flags: qe-verify+
Priority: -- → P1
QA Contact: gwimberly
Whiteboard: [photon-structure][triage] → [photon-structure]
Pre-photon we're using 30em as the maximum width, so I'm assuming that just keeping that size is fine. Bryan, if you want builds to play with, they will appear here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=928df4818e2a
Comment on attachment 8880374 [details]
Bug 1374603 - define a maximum width for panelviews, @mozilla.com,mikedeboer

https://reviewboard.mozilla.org/r/151742/#review156906

Looks good to me. 30em is a good place to start.
Comment on attachment 8880374 [details]
Bug 1374603 - define a maximum width for panelviews, @mozilla.com,mikedeboer

https://reviewboard.mozilla.org/r/151744/#review157132

LGTM. Thanks!
Attachment #8880374 - Flags: review?(mdeboer) → review+
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/70fe3412c7db
define a maximum width for panelviews, r=bbell,mikedeboer
https://hg.mozilla.org/mozilla-central/rev/70fe3412c7db
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox56: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
Verified on Windows, Mac, and Ubuntu.
Status: RESOLVED → VERIFIED
status-firefox56: fixed → verified
Flags: qe-verify+
Blocks: 1387512
Attachment #8880374 - Flags: review?(bbell) → review+
You need to log in before you can comment on or make changes to this bug.