Remove plural support from SentTab.* strings

RESOLVED FIXED

Status

()

Firefox for iOS
Localization
P1
normal
RESOLVED FIXED
6 months ago
6 months ago

People

(Reporter: st3fan, Assigned: jhugman)

Tracking

(Depends on: 1 bug)

unspecified
Other
iOS

Firefox Tracking Flags

(fxios8.0+)

Details

(Whiteboard: [MobileCore][AutoPush])

Attachments

(1 attachment)

(Reporter)

Description

6 months ago
From https://bugzilla.mozilla.org/show_bug.cgi?id=1373959#c4

We currently don't have support for proper plurals, and yet here we introduce strings with plurals
https://github.com/mozilla-l10n/firefoxios-l10n/blob/c7aadef3e227a23dc1a4b6c0779b24ab8536a7b3/it/firefox-ios.xliff#L1780-L1795

Even worse: code assumes that 1 vs 1+ works for all locales, using a completely different title if only one tab was received.

A proper solution would be to find a message that works without need for plural support.
(Reporter)

Comment 1

6 months ago
More discussion in https://bugzilla.mozilla.org/show_bug.cgi?id=1373959
(Assignee)

Comment 2

6 months ago
Created attachment 8880181 [details] [review]
Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/2855
Assignee: nobody → jhugman
Status: NEW → ASSIGNED
Attachment #8880181 - Flags: review?(sarentz)
Attachment #8880181 - Flags: review?(rfeeley)
(Reporter)

Updated

6 months ago
Attachment #8880181 - Flags: review?(sarentz) → review+
(Reporter)

Comment 3

6 months ago
Asking confirmation from Delphine and Francesco that this is good to go for the string export.
Flags: needinfo?(lebedel.delphine)
Flags: needinfo?(francesco.lodolo)
Answering on behalf of Delphine too: yes, this is good for string export.

Once that's done, we should try to figure out a way to prioritize the plural support, testing included.
Flags: needinfo?(lebedel.delphine)
Flags: needinfo?(francesco.lodolo)
thanks flod! Yes, LGTM too
Comment on attachment 8880181 [details] [review]
Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/2855

Not sure where to + this so I did it here and on GitHub.
Attachment #8880181 - Flags: review?(rfeeley) → review+
(Reporter)

Comment 7

6 months ago
Uplifted to v8.x
(Reporter)

Comment 8

6 months ago
Sorry, wrong bug, not uplifted yet.
(Reporter)

Updated

6 months ago
Whiteboard: [needsuplift]
(Reporter)

Comment 9

6 months ago
Landed on master, uplifted to v8.x
Status: ASSIGNED → RESOLVED
Last Resolved: 6 months ago
Resolution: --- → FIXED
Whiteboard: [needsuplift] → [MobileCore][AutoPush]
(Reporter)

Updated

6 months ago
Iteration: --- → 1.24
Priority: -- → P1
Depends on: 1181777
You need to log in before you can comment on or make changes to this bug.