[Spun off from bugscape 13692, so those people are cc'd] Currently, the component bar overlay for mail and addressbook (mailTasksOverlay.xul) uses absolute position numbers for the mail, composer, and addressbook icons. This is problematic if someone wishes to insert another icon between these from another overlay. My suggestion is to use insertafter for the composer and addressbook icons.
Comment on attachment 79216 [details] [diff] [review] patch sr=blake
Comment on attachment 79216 [details] [diff] [review] patch firstname.lastname@example.org
requesting adt approval for the branch -- please see bugscape bug 13692 for rationale.
Marking fixed since this is fixed on the trunk. This is still awaiting approval for branch checkin.
Will this still work if Mail isn't installed?
Yep, I actually built the installer and XPI's and tested with every combination I could think of, all worked as expected.
Comment on attachment 79216 [details] [diff] [review] patch a=asa (on behalf of drivers) for checkin to the 1.0 branch
adt1.0.0-/[ADT3 RTM]. Let's get this on the trunk, and we'll take it for MachV RTM.
It's already there on the trunk.
Would someone mind explaining why only the addressbook icon was changed to use insertafter, and not the mail icon?
The mail icon could be as well, I think. I was trying to make the least-risk change.
adt1.0.0-. This is an [adt3 RTM], and we are ramping down for beta right now.
Verified on trunk. The fix is transparent to end user. Verification is done by viewing the file through LXR: http://lxr.mozilla.org/seamonkey/source/mailnews/base/resources/content/mailTasksOverlay.xul#109
checked in on the 1.0 branch.
Verified on branch builds at 05-22,23-02 on Win2K, Linux, Mac OSX. On the component bar the icons are shown in the order: N, Mail, Composer, AB.
Oops, restoring original keyword. This is already checked in.