137468 - Mail component bar overlay should not use absolute position numbers

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Brian Ryner (not reading)]

[Spun off from bugscape 13692, so those people are cc'd]

Currently, the component bar overlay for mail and addressbook
(mailTasksOverlay.xul) uses absolute position numbers for the mail, composer,
and addressbook icons.  This is problematic if someone wishes to insert another
icon between these from another overlay.  My suggestion is to use insertafter
for the composer and addressbook icons.

Comment 1

[Brian Ryner (not reading)]

Attachment: patch

Comment 2

[Blake Ross]

Comment on attachment 79216 [details] [diff] [review]
patch

sr=blake

Comment 3

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 79216 [details] [diff] [review]
patch

r=[e-mail]

Comment 4

[Brian Ryner (not reading)]

requesting adt approval for the branch -- please see bugscape bug 13692 for
rationale.

Comment 5

[Brian Ryner (not reading)]

Marking fixed since this is fixed on the trunk.  This is still awaiting approval
for branch checkin.

Comment 6

[scottputterman]

Will this still work if Mail isn't installed?

Comment 7

[Brian Ryner (not reading)]

Yep, I actually built the installer and XPI's and tested with every combination
I could think of, all worked as expected.

Comment 8

[Asa Dotzler [:asa]]

Comment on attachment 79216 [details] [diff] [review]
patch

a=asa (on behalf of drivers) for checkin to the 1.0 branch

Comment 9

[Jaime Rodriguez, Jr.]

adt1.0.0-/[ADT3 RTM]. Let's get this on the trunk, and we'll take it for MachV RTM.

Comment 10

[Brian Ryner (not reading)]

It's already there on the trunk.

Comment 11

[[e-mail]]

Would someone mind explaining why only the addressbook icon was changed to use
insertafter, and not the mail icon?

Comment 12

[Brian Ryner (not reading)]

The mail icon could be as well, I think.  I was trying to make the least-risk
change.

Comment 13

[Jaime Rodriguez, Jr.]

adt1.0.0-. This is an [adt3 RTM], and we are ramping down for beta right now.

Comment 14

[Olga]

Verified on trunk.
The fix is transparent to end user.
Verification is done by viewing the file through LXR:
http://lxr.mozilla.org/seamonkey/source/mailnews/base/resources/content/mailTasksOverlay.xul#109

Comment 15

[chris hofmann]

re-a=chofmann,shaver

Comment 16

[Brian Ryner (not reading)]

checked in on the 1.0 branch.

Comment 17

[Olga]

Verified on branch builds at 05-22,23-02 on Win2K, Linux, Mac OSX.
On the component bar the icons are shown in the order: N, Mail, Composer, AB.

Comment 18

[Brian Ryner (not reading)]

Oops, restoring original keyword.  This is already checked in.