Mail component bar overlay should not use absolute position numbers

VERIFIED FIXED in mozilla1.0

Status

SeaMonkey
MailNews: Message Display
VERIFIED FIXED
16 years ago
13 years ago

People

(Reporter: Brian Ryner (not reading), Assigned: Brian Ryner (not reading))

Tracking

Trunk
mozilla1.0

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [adt3 RTM])

Attachments

(1 attachment)

954 bytes, patch
Ben Goodger (use ben at mozilla dot org for email)
: review+
Blake Ross
: superreview+
Details | Diff | Splinter Review
(Assignee)

Description

16 years ago
[Spun off from bugscape 13692, so those people are cc'd]

Currently, the component bar overlay for mail and addressbook
(mailTasksOverlay.xul) uses absolute position numbers for the mail, composer,
and addressbook icons.  This is problematic if someone wishes to insert another
icon between these from another overlay.  My suggestion is to use insertafter
for the composer and addressbook icons.
(Assignee)

Updated

16 years ago
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.0
(Assignee)

Comment 1

16 years ago
Created attachment 79216 [details] [diff] [review]
patch

Comment 2

16 years ago
Comment on attachment 79216 [details] [diff] [review]
patch

sr=blake
Attachment #79216 - Flags: superreview+
Comment on attachment 79216 [details] [diff] [review]
patch

r=ben@netscape.com
Attachment #79216 - Flags: review+
(Assignee)

Comment 4

16 years ago
requesting adt approval for the branch -- please see bugscape bug 13692 for
rationale.
Keywords: adt1.0.0
(Assignee)

Comment 5

16 years ago
Marking fixed since this is fixed on the trunk.  This is still awaiting approval
for branch checkin.
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED

Comment 6

16 years ago
Will this still work if Mail isn't installed?
(Assignee)

Comment 7

16 years ago
Yep, I actually built the installer and XPI's and tested with every combination
I could think of, all worked as expected.

Comment 8

16 years ago
Comment on attachment 79216 [details] [diff] [review]
patch

a=asa (on behalf of drivers) for checkin to the 1.0 branch
Attachment #79216 - Flags: approval+

Comment 9

16 years ago
adt1.0.0-/[ADT3 RTM]. Let's get this on the trunk, and we'll take it for MachV RTM.
Keywords: adt1.0.0 → adt1.0.0-, nsbeta1+
Whiteboard: [adt3 RTM]
(Assignee)

Comment 10

16 years ago
It's already there on the trunk.

Comment 11

16 years ago
Would someone mind explaining why only the addressbook icon was changed to use
insertafter, and not the mail icon?
(Assignee)

Comment 12

16 years ago
The mail icon could be as well, I think.  I was trying to make the least-risk
change.
Keywords: adt1.0.0- → adt1.0.0

Comment 13

16 years ago
adt1.0.0-. This is an [adt3 RTM], and we are ramping down for beta right now.
Keywords: adt1.0.0 → adt1.0.0-

Comment 14

16 years ago
Verified on trunk.
The fix is transparent to end user.
Verification is done by viewing the file through LXR:
http://lxr.mozilla.org/seamonkey/source/mailnews/base/resources/content/mailTasksOverlay.xul#109
Status: RESOLVED → VERIFIED
Keywords: adt1.0.0- → adt1.0.0

Updated

16 years ago
Keywords: adt1.0.0 → adt1.0.0-

Comment 15

16 years ago
re-a=chofmann,shaver
(Assignee)

Comment 16

16 years ago
checked in on the 1.0 branch.
Keywords: fixed1.0.0

Comment 17

16 years ago
Verified on branch builds at 05-22,23-02 on Win2K, Linux, Mac OSX.
On the component bar the icons are shown in the order: N, Mail, Composer, AB.
Keywords: fixed1.0.0 → verified1.0.0
(Assignee)

Updated

16 years ago
Keywords: adt1.0.0- → adt1.0.1
(Assignee)

Comment 18

16 years ago
Oops, restoring original keyword.  This is already checked in.
Keywords: adt1.0.1 → adt1.0.0-
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.