Retrieve indent property from the message in the Message component

RESOLVED FIXED in Firefox 56

Status

()

Firefox
Developer Tools: Console
P1
normal
RESOLVED FIXED
8 months ago
7 months ago

People

(Reporter: nchevobbe, Assigned: nchevobbe)

Tracking

unspecified
Firefox 56
Points:
---
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox56 fixed)

Details

(Whiteboard: [console-html])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

8 months ago
At the moment, we are passing `indent` as an explicit props to the MessageContainer component, and we then pipe it down to Message.
But, the indent is available in the message data directly, so we shouldn't need to do all this plumbing.
(Assignee)

Updated

8 months ago
Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
Flags: qe-verify-
Priority: -- → P1
Whiteboard: [console-html]

Updated

8 months ago
Iteration: --- → 56.1 - Jun 26

Updated

8 months ago
Iteration: 56.1 - Jun 26 → 56.2 - Jul 10

Updated

8 months ago
Iteration: 56.2 - Jul 10 → 56.3 - Jul 24
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 3

7 months ago
mozreview-review
Comment on attachment 8888304 [details]
Bug 1374680 - Retrieve indent property from the message in the messages types components;

https://reviewboard.mozilla.org/r/159250/#review164636
Attachment #8888304 - Flags: review?(bgrinstead) → review+
(Assignee)

Comment 4

7 months ago
TRY is green, let's push

Comment 6

7 months ago
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2774b700ace8
Retrieve indent property from the message in the messages types components; r=bgrins
https://hg.mozilla.org/mozilla-central/rev/2774b700ace8
Status: ASSIGNED → RESOLVED
Last Resolved: 7 months ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
You need to log in before you can comment on or make changes to this bug.