1374694 - "Restart to update Nightly" and its icon are randomly aligned

Status: VERIFIED FIXED

(Firefox :: Menus, defect, P1)

Description

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Attachment: Screenshot (8).png

See the screenshot, the icons and text should be aligned with the other entries in the menu, they appear to have their own bogus alignment.
Not sure if strictly related to the localized string length.

Comment 1

[Mike de Boer [:mikedeboer]]

Attachment: Bug 1374694 - Fix indentation and font used for multi-line labels inside panelviews.

Review commit: https://reviewboard.mozilla.org/r/150962/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/150962/

Comment 3

[:Gijs (he/him)]

Comment on attachment 8879618 [details]
Bug 1374694 - Fix indentation and font used for multi-line labels inside panelviews.

https://reviewboard.mozilla.org/r/150962/#review156154

r=me with the comment below addressed.

::: browser/themes/shared/customizableui/panelUI.inc.css:1266
(Diff revision 1)
>  photonpanelmultiview .subviewbutton-iconic:not(.subviewbutton-back) > .toolbarbutton-text,
>  photonpanelmultiview .cui-withicon > .toolbarbutton-text,
>  photonpanelmultiview .subviewbutton[image] > .toolbarbutton-text,
>  photonpanelmultiview .subviewbutton[checked="true"] > .toolbarbutton-text,
>  photonpanelmultiview .panel-banner-item > .toolbarbutton-multiline-text {
> +  padding: 0;

We already set this for .toolbarbutton-text, right above this rule.

I think we should remove the multiline-text selector padding-inline-start from the selector for this rule, and move the padding:0 and copy padding-inline-start: 8 to the new rule you're creating to set the font with.

Comment 4

[Mike de Boer [:mikedeboer]]

Comment on attachment 8879618 [details]
Bug 1374694 - Fix indentation and font used for multi-line labels inside panelviews.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/150962/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ef8aac47b513
Fix indentation and font used for multi-line labels inside panelviews. r=Gijs

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ef8aac47b513

Comment 7

[Azmina]

I have reproduced this bug with Nightly 56.0a1 (2017-06-20) on Windows 8.1 (64 bit).

This bug's fix is verified with Latest Nightly 56.0a1.

Build ID : 20170622030208
User Agent : Mozilla/5.0 (Windows NT 6.3; WOW64; rv:56.0) Gecko/20100101 Firefox/56.0

Comment 9

[u554753]

Verified on Windows and Ubuntu, but can't test on Mac since the update channel is broken (or so I was told yesterday).

Comment 10

[u554753]

Looks like there's a message that appears on Mac that says to "Download a Fresh Copy of Nightly" and that looks to be properly aligned. 

Marking as Verified.