1374778 - BugFiler: If we end up with a file path starting with "TEST-", use the next piece of the error summary when attempting to find the filename.

Status: RESOLVED FIXED

(Tree Management :: Treeherder, enhancement)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Since we only strip out "TEST-UNEXPECTED-FAIL", "PROCESS-CRASH", "TEST-UNEXPECTED-ERROR", and "REFTEST ERROR" from bug summaries, we can end up passing a string like "TEST-UNEXPECTED-PASS" or "TEST-UNEXPECTED-TIMEOUT" (maybe others, I don't remember all of the TEST-foo things we use) to findFilename(), which understandably returns the wrong thing.


I kinda put a fix for this into the patch for bug 1364033, but it only covered the UNEXPECTED-PASS case. I think the PR I'm about to file will deal with this better.

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Attachment: PR 2584

Comment 2

[Ed Morley [:emorley]]

Comment on attachment 8879691 [details] [review]
PR 2584

Could you add a test? :-)

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Comment on attachment 8879691 [details] [review]
PR 2584

Test added. :)

Comment 4

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/7d2cd54f30a8f3372da93d9230c026c90d880266
Bug 1374778 - Bug filer: Improve the filename extraction logic (#2584)

Comment 5

[Ed Morley [:emorley]]

Comment on attachment 8879691 [details] [review]
PR 2584

Awesome - many thanks!