Sidebar switcher menu items need updated hover styling

VERIFIED FIXED in Firefox 57

Status

()

P1
normal
VERIFIED FIXED
2 years ago
2 years ago

People

(Reporter: abenson, Assigned: Gijs)

Tracking

(Depends on: 1 bug, Blocks: 2 bugs)

unspecified
Firefox 57
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox57 fixed)

Details

(Whiteboard: [photon-structure])

Attachments

(2 attachments)

(Reporter)

Description

2 years ago
Posted image menu_hovers.png
The hover states for the menu items in the sidebar switcher menu (popout) need to be updated to match other Photon menu styles. Reference here: https://mozilla.invisionapp.com/share/PYC5LJJXG#/229940647_Toolbars
Flags: qe-verify?
Whiteboard: [photon-structure] → [photon-structure] [triage]
Priority: -- → P2
Whiteboard: [photon-structure] [triage] → [photon-structure]
(Assignee)

Updated

2 years ago
Flags: qe-verify? → qe-verify+
QA Contact: gwimberly

Updated

2 years ago
Blocks: 1387512
(Assignee)

Updated

2 years ago
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Iteration: --- → 57.2 - Aug 29
Priority: P2 → P1
Comment hidden (mozreview-request)
(Assignee)

Updated

2 years ago
Attachment #8900235 - Flags: review?(dao+bmo) → review?(nhnt11)
(Assignee)

Updated

2 years ago
Depends on: 1373961
(Assignee)

Comment 2

2 years ago
(Switched reviewers because it looks like Dão's queue is quite full)

Comment 3

2 years ago
mozreview-review
Comment on attachment 8900235 [details]
Bug 1374815 - fix sidebar hover styling and unify photon styling with the default,

https://reviewboard.mozilla.org/r/171614/#review178296
Attachment #8900235 - Flags: review?(nhnt11) → review+

Comment 4

2 years ago
mozreview-review
Comment on attachment 8900235 [details]
Bug 1374815 - fix sidebar hover styling and unify photon styling with the default,

https://reviewboard.mozilla.org/r/171614/#review178298

Changes look alright to me. Obviously we can file follow-ups if we missed anything.

I tested the patch locally too and thing seem good.
Iteration: 57.2 - Aug 29 → 57.3 - Sep 19

Comment 5

2 years ago
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s a6970bd2f1b5 -d 5558134ce16b: rebasing 416554:a6970bd2f1b5 "Bug 1374815 - fix sidebar hover styling and unify photon styling with the default, r=nhnt11" (tip)
merging browser/themes/linux/customizableui/panelUI.css
merging browser/themes/shared/customizableui/panelUI.inc.css
warning: conflicts while merging browser/themes/linux/customizableui/panelUI.css! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
Comment hidden (mozreview-request)

Comment 7

2 years ago
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/4fb65ac5a587
fix sidebar hover styling and unify photon styling with the default, r=nhnt11
https://hg.mozilla.org/mozilla-central/rev/4fb65ac5a587
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57

Comment 9

2 years ago
This bug fix is verified on the latest nightly.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
(Assignee)

Updated

2 years ago
No longer depends on: 1397086
(Assignee)

Updated

2 years ago
Depends on: 1397754

Updated

2 years ago
Depends on: 1399145
You need to log in before you can comment on or make changes to this bug.