Closed
Bug 1374832
Opened 7 years ago
Closed 7 years ago
Don't depend on com.google.android.gms:play-services-ads in Gradle configuration when MMA/Leanplum is enabled
Categories
(Firefox Build System :: Android Studio and Gradle Integration, enhancement)
Firefox Build System
Android Studio and Gradle Integration
Tracking
(firefox56 fixed)
RESOLVED
FIXED
mozilla56
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | fixed |
People
(Reporter: nalexander, Assigned: nalexander)
References
Details
Attachments
(1 file)
|
Bug 1374832 - Don't depend on com.google.android.gms:play-services-ads when MMA/Leanplum is enabled.
59 bytes,
text/x-review-board-request
|
maliu
:
review+
|
Details |
Bug 1351585 added a dependency on com.google.android.gms:play-services-ads in the Gradle configuration when MMA/Leanplum is enabled. I remember making a note somewhere about this, but I can't find it in my ~/org or Bugzilla, so I must not have communicated it. AFAIK, we don't actually require play-services-ads for the MMA integration -- it just _looks_ like we do. (The ads/identity looking symbols really come from basement or base, I can't remember which.) I found this while digging into APK differences as part of Bug 1355625. It doesn't block that ticket, but we should unify the included sources as part of the larger "Gradle in automation" effort.
| Comment hidden (mozreview-request) |
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8879740 [details] Bug 1374832 - Don't depend on com.google.android.gms:play-services-ads when MMA/Leanplum is enabled. https://reviewboard.mozilla.org/r/151080/#review155978 LGTM
Attachment #8879740 -
Flags: review?(max) → review+
Pushed by nalexander@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/867702253c48 Don't depend on com.google.android.gms:play-services-ads when MMA/Leanplum is enabled. r=maliu
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/867702253c48
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
|
||
Updated•6 years ago
|
Assignee: nobody → nalexander
|
||
Updated•5 years ago
|
Product: Firefox for Android → Firefox Build System
Target Milestone: Firefox 56 → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•