Closed Bug 1374832 Opened 4 years ago Closed 4 years ago

Don't depend on com.google.android.gms:play-services-ads in Gradle configuration when MMA/Leanplum is enabled

Categories

(Firefox Build System :: Android Studio and Gradle Integration, enhancement)

enhancement
Not set
normal

Tracking

(firefox56 fixed)

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: nalexander, Assigned: nalexander)

References

Details

Attachments

(1 file)

Bug 1351585 added a dependency on com.google.android.gms:play-services-ads in the Gradle configuration when MMA/Leanplum is enabled.  I remember making a note somewhere about this, but I can't find it in my ~/org or Bugzilla, so I must not have communicated it.  AFAIK, we don't actually require play-services-ads for the MMA integration -- it just _looks_ like we do.  (The ads/identity looking symbols really come from basement or base, I can't remember which.)

I found this while digging into APK differences as part of Bug 1355625.  It doesn't block that ticket, but we should unify the included sources as part of the larger "Gradle in automation" effort.
Comment on attachment 8879740 [details]
Bug 1374832 - Don't depend on com.google.android.gms:play-services-ads when MMA/Leanplum is enabled.

https://reviewboard.mozilla.org/r/151080/#review155978

LGTM
Attachment #8879740 - Flags: review?(max) → review+
Pushed by nalexander@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/867702253c48
Don't depend on com.google.android.gms:play-services-ads when MMA/Leanplum is enabled. r=maliu
https://hg.mozilla.org/mozilla-central/rev/867702253c48
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
Assignee: nobody → nalexander
Product: Firefox for Android → Firefox Build System
Target Milestone: Firefox 56 → mozilla56
You need to log in before you can comment on or make changes to this bug.