Don't depend on com.google.android.gms:play-services-ads in Gradle configuration when MMA/Leanplum is enabled

RESOLVED FIXED in Firefox 56

Status

()

Firefox for Android
Build Config & IDE Support
RESOLVED FIXED
5 months ago
5 months ago

People

(Reporter: nalexander, Unassigned)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 56
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox56 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

5 months ago
Bug 1351585 added a dependency on com.google.android.gms:play-services-ads in the Gradle configuration when MMA/Leanplum is enabled.  I remember making a note somewhere about this, but I can't find it in my ~/org or Bugzilla, so I must not have communicated it.  AFAIK, we don't actually require play-services-ads for the MMA integration -- it just _looks_ like we do.  (The ads/identity looking symbols really come from basement or base, I can't remember which.)

I found this while digging into APK differences as part of Bug 1355625.  It doesn't block that ticket, but we should unify the included sources as part of the larger "Gradle in automation" effort.
Comment hidden (mozreview-request)

Comment 2

5 months ago
mozreview-review
Comment on attachment 8879740 [details]
Bug 1374832 - Don't depend on com.google.android.gms:play-services-ads when MMA/Leanplum is enabled.

https://reviewboard.mozilla.org/r/151080/#review155978

LGTM
Attachment #8879740 - Flags: review?(max) → review+

Comment 3

5 months ago
Pushed by nalexander@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/867702253c48
Don't depend on com.google.android.gms:play-services-ads when MMA/Leanplum is enabled. r=maliu

Comment 4

5 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/867702253c48
Status: NEW → RESOLVED
Last Resolved: 5 months ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
You need to log in before you can comment on or make changes to this bug.