Closed
Bug 1374836
Opened 8 years ago
Closed 1 year ago
Hoist setDenseInitializedLength() out of a loop.
Categories
(Core :: JavaScript Engine, enhancement, P3)
Core
JavaScript Engine
Tracking
()
RESOLVED
INCOMPLETE
People
(Reporter: sstangl, Unassigned)
Details
(Keywords: triage-deferred)
Attachments
(1 file)
js::CreateRegExpMatchResult() calls setDenseInitializedLength() for each element at the time of insertion. Instead, it could just set the length before entering the insertion loop, resulting in tighter loops.
Attachment #8879739 -
Flags: review?(evilpies)
|
||
Comment 1•8 years ago
|
||
I am not sure this is okay, if NewDependentString fails the memory might not get initialized.
|
|
||
Updated•8 years ago
|
Attachment #8879739 -
Flags: review?(evilpies)
|
||
Updated•8 years ago
|
Keywords: triage-deferred
Priority: -- → P3
|
||
Updated•3 years ago
|
Severity: normal → S3
|
||
Updated•1 year ago
|
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → INCOMPLETE
You need to log in
before you can comment on or make changes to this bug.
Description
•