Closed
Bug 1374891
Opened 7 years ago
Closed 7 years ago
Use CreateSimiliarDrawTarget for Filters instead of CreateOffscreenTarget
Categories
(Core :: Graphics: WebRender, defect, P1)
Core
Graphics: WebRender
Tracking
()
RESOLVED
FIXED
mozilla58
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | unaffected |
| firefox57 | --- | unaffected |
| firefox58 | --- | fixed |
People
(Reporter: jrmuizel, Assigned: jrmuizel)
References
Details
(Keywords: stale-bug, Whiteboard: [wr-mvp])
Attachments
(1 file)
|
3.11 KB,
patch
|
mstange
:
review+
|
Details | Diff | Splinter Review |
This lets us use DrawTargetRecording/Capture for the filter source.
|
Assignee | |
Comment 1•7 years ago
|
||
Assignee: nobody → jmuizelaar
Attachment #8879781 -
Flags: review?(mstange)
|
||
Comment 2•7 years ago
|
||
Is this going to create a dual draw target when you draw the filter into a component alpha layer? I think it is.
|
|
Assignee | |
Comment 3•7 years ago
|
||
True. I also switched another place recently in bug 1371855 without considering this consequence.
|
|
||
Comment 4•7 years ago
|
||
I remember reviewing at least two patches that switched us away from CreateSimilarDrawTarget because of this issue.
|
|
||
Updated•7 years ago
|
Attachment #8879781 -
Flags: review?(mstange) → review+
|
||
Updated•7 years ago
|
Blocks: stage-wr-nightly
|
|
||
Updated•7 years ago
|
Priority: -- → P3
|
||
Updated•7 years ago
|
Status: NEW → ASSIGNED
Priority: P3 → P1
Whiteboard: [wr-mvp]
Target Milestone: --- → mozilla57
|
|
||
Updated•7 years ago
|
status-firefox56:
--- → unaffected
status-firefox57:
--- → unaffected
Keywords: stale-bug
|
||
Comment 7•7 years ago
|
||
The patch for this bug landed with the number of the dupe bug.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: mozilla57 → mozilla58
You need to log in
before you can comment on or make changes to this bug.
Description
•