Closed
Bug 1374894
Opened 7 years ago
Closed 1 year ago
Don't attempt to control an input when we're already controlling it
Categories
(Toolkit :: Form Manager, enhancement, P5)
Toolkit
Form Manager
Tracking
()
RESOLVED
WONTFIX
People
(Reporter: ehsan.akhgari, Unassigned)
Details
Attachments
(1 file)
990 bytes,
patch
|
MattN
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Reporter | ||
Comment 1•7 years ago
|
||
Attachment #8879783 -
Flags: review?(MattN+bmo)
Reporter | ||
Comment 2•7 years ago
|
||
Note that this doesn't improve anything in Speedometer but is nice to have regardless.
Assignee: nobody → ehsan
Comment 3•7 years ago
|
||
Comment on attachment 8879783 [details] [diff] [review] Don't attempt to control an input when we're already controlling it Review of attachment 8879783 [details] [diff] [review]: ----------------------------------------------------------------- Thanks. Please make sure this passes on Try since it's possible that the old (seemingly wasteful) behaviour is somehow useful or avoids some other issue. Since there is a lot of attention on satchel now related to Form Autofill I think it's safe to land this as broken edge cases are more likely to get noticed now.
Attachment #8879783 -
Flags: review?(MattN+bmo) → review+
Reporter | ||
Comment 4•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=35fc5073b0969f021acb070b6bc27e68edb5cf89
Reporter | ||
Comment 5•7 years ago
|
||
Well, this indeed turns out to break a whole bunch of tests... :-/ Do you think this is worth spending time on to figure out, Matt? I'm not quite sure how much this patch buys us TBH but if you want I can spend some time to look into the test failures? Or close the bug? Up to you.
Flags: needinfo?(MattN+bmo)
Updated•7 years ago
|
Priority: -- → P5
Comment 7•5 years ago
|
||
There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:Ehsan, could you have a look please?
Flags: needinfo?(ehsan)
Reporter | ||
Comment 8•5 years ago
|
||
(In reply to Release mgmt bot [:sylvestre / :calixte] from comment #7)
There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:Ehsan, could you have a look please?
See comment 6.
Assignee: ehsan → nobody
Flags: needinfo?(ehsan)
Updated•2 years ago
|
Severity: normal → S3
Updated•1 year ago
|
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•