Don't attempt to control an input when we're already controlling it

NEW
Assigned to

Status

()

Toolkit
Form Manager
P5
normal
10 months ago
5 months ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

10 months ago
Created attachment 8879783 [details] [diff] [review]
Don't attempt to control an input when we're already controlling it
Attachment #8879783 - Flags: review?(MattN+bmo)
(Assignee)

Comment 2

10 months ago
Note that this doesn't improve anything in Speedometer but is nice to have regardless.
Assignee: nobody → ehsan
Comment on attachment 8879783 [details] [diff] [review]
Don't attempt to control an input when we're already controlling it

Review of attachment 8879783 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks. Please make sure this passes on Try since it's possible that the old (seemingly wasteful) behaviour is somehow useful or avoids some other issue. Since there is a lot of attention on satchel now related to Form Autofill I think it's safe to land this as broken edge cases are more likely to get noticed now.
Attachment #8879783 - Flags: review?(MattN+bmo) → review+
(Assignee)

Comment 5

10 months ago
Well, this indeed turns out to break a whole bunch of tests...  :-/

Do you think this is worth spending time on to figure out, Matt?  I'm not quite sure how much this patch buys us TBH but if you want I can spend some time to look into the test failures?  Or close the bug?  Up to you.
Flags: needinfo?(MattN+bmo)
I think we can leave it open as a P5.
Flags: needinfo?(MattN+bmo)
You need to log in before you can comment on or make changes to this bug.