Closed Bug 1374894 Opened 7 years ago Closed 1 year ago

Don't attempt to control an input when we're already controlling it

Categories

(Toolkit :: Form Manager, enhancement, P5)

enhancement

Tracking

()

RESOLVED WONTFIX

People

(Reporter: ehsan.akhgari, Unassigned)

Details

Attachments

(1 file)

      No description provided.
Note that this doesn't improve anything in Speedometer but is nice to have regardless.
Assignee: nobody → ehsan
Comment on attachment 8879783 [details] [diff] [review]
Don't attempt to control an input when we're already controlling it

Review of attachment 8879783 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks. Please make sure this passes on Try since it's possible that the old (seemingly wasteful) behaviour is somehow useful or avoids some other issue. Since there is a lot of attention on satchel now related to Form Autofill I think it's safe to land this as broken edge cases are more likely to get noticed now.
Attachment #8879783 - Flags: review?(MattN+bmo) → review+
Well, this indeed turns out to break a whole bunch of tests...  :-/

Do you think this is worth spending time on to figure out, Matt?  I'm not quite sure how much this patch buys us TBH but if you want I can spend some time to look into the test failures?  Or close the bug?  Up to you.
Flags: needinfo?(MattN+bmo)
Priority: -- → P5
I think we can leave it open as a P5.
Flags: needinfo?(MattN+bmo)

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:Ehsan, could you have a look please?

Flags: needinfo?(ehsan)

(In reply to Release mgmt bot [:sylvestre / :calixte] from comment #7)

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:Ehsan, could you have a look please?

See comment 6.

Assignee: ehsan → nobody
Flags: needinfo?(ehsan)
Severity: normal → S3
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: