Closed Bug 1374908 Opened 3 years ago Closed 3 years ago

Remove --enable-systrace

Categories

(Core :: Gecko Profiler, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: njn, Assigned: njn)

Details

Attachments

(1 file)

This option causes MOZ_USE_SYSTRACE to be defined. The only use of that is in
GeckoProfiler.h where it causes the PROFILER_PLATFORM_TRACING macro to set
android::ScopedTrace. But android::ScopedTrace was defined in widget/gonk/
which was recently removed, so this won't work any more.

Furthermore, all that android::ScopedTrace did was to do a pair of
atrace_{begin,end}() calls, which doesn't seem that useful.
Attachment #8879801 - Flags: review?(snorp)
Attachment #8879801 - Flags: review?(mh+mozilla)
Attachment #8879801 - Flags: review?(mh+mozilla) → review+
Comment on attachment 8879801 [details] [diff] [review]
Remove --enable-systrace

Review of attachment 8879801 [details] [diff] [review]:
-----------------------------------------------------------------

This is blocking some other stuff and I think glandium's r+ suffices. snorp, let me know if there's a problem with this removal and I can fix it up afterwards.
Attachment #8879801 - Flags: review?(snorp)
https://hg.mozilla.org/mozilla-central/rev/8835401006a6
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.