Closed Bug 1374936 Opened 3 years ago Closed 3 years ago

Invalid output format in D3D11SharedHandIemage::GetAsSourceFormat

Categories

(Core :: Audio/Video: Playback, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox55 - fixed
firefox56 --- fixed

People

(Reporter: jya, Assigned: jya)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Reported by Matt in bug 1372874.

The transform use to convert NV12 to BGRA uses NV12 as output format, instead of BGRA.
How come this wasn't causing problems with reftest or anything using canvas?
Comment on attachment 8879835 [details]
Bug 1374936: P1. Properly output ARGB32 with transform.

https://reviewboard.mozilla.org/r/151232/#review156168
Attachment #8879835 - Flags: review?(matt.woodrow) → review+
Comment on attachment 8879836 [details]
Bug 1374936: P2. Check for error.

https://reviewboard.mozilla.org/r/151234/#review156172
Attachment #8879836 - Flags: review?(matt.woodrow) → review+
Pushed by jyavenard@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/86510ad18b92
P1. Properly output ARGB32 with transform. r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/3d2952de26c3
P2. Check for error. r=mattwoodrow
https://hg.mozilla.org/mozilla-central/rev/86510ad18b92
https://hg.mozilla.org/mozilla-central/rev/3d2952de26c3
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Jean-Yves, you requested tracking for 55, I assume you'll want to request uplift to beta?  Was this fix verified on nightly?
Flags: needinfo?(jyavenard)
Comment on attachment 8879835 [details]
Bug 1374936: P1. Properly output ARGB32 with transform.

Approval Request Comment
[Feature/Bug causing the regression]: 1340398
[User impact if declined]: Bad content drawn on canvas.
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Unsure
[Needs manual test from QE? If yes, steps to reproduce]: It needs to write some code to verify it.
[List of other uplifts needed for the feature/fix]: the two of this bug
[Is the change risky?]: No
[Why is the change risky/not risky?]: We set the proper data type on output
[String changes made/needed]: none
Flags: needinfo?(jyavenard)
Attachment #8879835 - Flags: approval-mozilla-beta?
So if we have no automated test and no manual test how can we be confident in this fix here?  "Unsure" isn't really a great answer...
Flags: needinfo?(jyavenard)
because the bug in the code was so obvious, it jumped at you looking at the code.

Having said that, in bug 1372874 they may have the answer on how to test it.
Flags: needinfo?(jyavenard)
Comment on attachment 8879835 [details]
Bug 1374936: P1. Properly output ARGB32 with transform.

video format fix, beta55+
Attachment #8879835 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.