1374936 - Invalid output format in D3D11SharedHandIemage::GetAsSourceFormat

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Jean-Yves Avenard [:jya]]

Reported by Matt in bug 1372874.

The transform use to convert NV12 to BGRA uses NV12 as output format, instead of BGRA.

Comment 1

[Jean-Yves Avenard [:jya]]

How come this wasn't causing problems with reftest or anything using canvas?

Comment 2

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1374936: P1. Properly output ARGB32 with transform.

Review commit: https://reviewboard.mozilla.org/r/151232/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/151232/

Comment 3

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1374936: P2. Check for error.

Review commit: https://reviewboard.mozilla.org/r/151234/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/151234/

Comment 4

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8879835 [details]
Bug 1374936: P1. Properly output ARGB32 with transform.

https://reviewboard.mozilla.org/r/151232/#review156168

Comment 5

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8879836 [details]
Bug 1374936: P2. Check for error.

https://reviewboard.mozilla.org/r/151234/#review156172

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/86510ad18b92
P1. Properly output ARGB32 with transform. r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/3d2952de26c3
P2. Check for error. r=mattwoodrow

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/86510ad18b92
https://hg.mozilla.org/mozilla-central/rev/3d2952de26c3

Comment 8

[Julien Cristau [:jcristau]]

Jean-Yves, you requested tracking for 55, I assume you'll want to request uplift to beta?  Was this fix verified on nightly?

Comment 9

[Jean-Yves Avenard [:jya]]

Comment on attachment 8879835 [details]
Bug 1374936: P1. Properly output ARGB32 with transform.

Approval Request Comment
[Feature/Bug causing the regression]: 1340398
[User impact if declined]: Bad content drawn on canvas.
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Unsure
[Needs manual test from QE? If yes, steps to reproduce]: It needs to write some code to verify it.
[List of other uplifts needed for the feature/fix]: the two of this bug
[Is the change risky?]: No
[Why is the change risky/not risky?]: We set the proper data type on output
[String changes made/needed]: none

Comment 10

[Julien Cristau [:jcristau]]

So if we have no automated test and no manual test how can we be confident in this fix here?  "Unsure" isn't really a great answer...

Comment 11

[Jean-Yves Avenard [:jya]]

because the bug in the code was so obvious, it jumped at you looking at the code.

Having said that, in bug 1372874 they may have the answer on how to test it.

Comment 12

[Julien Cristau [:jcristau]]

Comment on attachment 8879835 [details]
Bug 1374936: P1. Properly output ARGB32 with transform.

video format fix, beta55+

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/2b893184b932
https://hg.mozilla.org/releases/mozilla-beta/rev/2ab76e7f2244