Fix weird capitalization of "Restore all Windows and Tabs" in about:welcomeback

VERIFIED FIXED in Firefox 56

Status

()

enhancement
VERIFIED FIXED
2 years ago
2 years ago

People

(Reporter: dao, Assigned: mboros04, Mentored)

Tracking

({good-first-bug})

Trunk
Firefox 56
Points:
---

Firefox Tracking Flags

(firefox56 verified)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

2 years ago
The radio buttons in about:welcomeback are labeled "Restore all Windows and Tabs" and "Restore only the ones you want". The former uses some kind of partial title capitalization which makes no sense. It should read "Restore all windows and tabs" instead.

Also, according to attachment 8497821 [details], we should use "&" instead of "and".

http://searchfox.org/mozilla-central/rev/714606a8145636d93b116943d3a65a6a49d2acf8/browser/locales/en-US/chrome/browser/aboutSessionRestore.dtd#37
(Assignee)

Comment 1

2 years ago
Hello, I'd like to fix this bug, this would be my first time contributing. Looks like a nice and easy introduction, I've already fixed it would just need to know how to submit the changes.
(Reporter)

Comment 2

2 years ago
(In reply to Martin Boros from comment #1)
> Hello, I'd like to fix this bug, this would be my first time contributing.
> Looks like a nice and easy introduction, I've already fixed it would just
> need to know how to submit the changes.

Have you made the change in a Mercurial clone of mozilla-central? If so, you can create a patch using hg diff > ~/maypatch.diff and then upload it on this page (see Attach File link).
(Assignee)

Comment 3

2 years ago
Edited the line to fit the formatting suggested in the bug report.
(Reporter)

Updated

2 years ago
Assignee: nobody → mboros04
Status: NEW → ASSIGNED
(Reporter)

Comment 4

2 years ago
Comment on attachment 8880970 [details] [diff] [review]
Patch replacing the line in question

>diff --git a/browser/locales/en-US/chrome/browser/aboutSessionRestore.dtd b/browser/locales/en-US/chrome/browser/aboutSessionRestore.dtd
>--- a/browser/locales/en-US/chrome/browser/aboutSessionRestore.dtd
>+++ b/browser/locales/en-US/chrome/browser/aboutSessionRestore.dtd
>@@ -34,7 +34,7 @@
> <!ENTITY welcomeback2.pageTitle     "Success!">
> <!ENTITY welcomeback2.pageInfo1     "&brandShortName; is ready to go.">
> 
>-<!ENTITY welcomeback2.label.restoreAll  "Restore all Windows and Tabs">
>+<!ENTITY welcomeback2.label.restoreAll  "Restore all windows & tabs">
> <!ENTITY welcomeback2.label.restoreSome "Restore only the ones you want">

& is invalid syntax, you need to use &amp; instead.

Could you also please rename welcomeback2.label.restoreAll to welcomeback2.restoreAll.label and welcomeback2.label.restoreSome to welcomeback2.restoreSome.label? You'll have to update browser/components/migration/content/aboutWelcomeBack.xhtml for that too.
(Assignee)

Updated

2 years ago
Attachment #8880970 - Attachment is obsolete: true
(Assignee)

Comment 5

2 years ago
Fixed illegal character from first patch.

Changed naming convention on labels as requested in both files.
(Reporter)

Comment 6

2 years ago
Comment on attachment 8881314 [details] [diff] [review]
Patch for the bug

Looks good. Thanks!
Attachment #8881314 - Flags: review+

Comment 7

2 years ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8d9b536289c2
Remove half-baked title capitalization from "Restore all Windows and Tabs". r=dao

Comment 8

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/8d9b536289c2
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
I have reproduced this bug with Nightly 56.0a1 (2017-06-21) on Windows 7, 64 Bit!

This bug's fix is verified with latest Beta!


Build  ID  : 20170818035007 
User Agent : Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:56.0) Gecko/20100101 Firefox/56.0
QA Whiteboard: [testday-20170818]
Marking this as verified fixed, based on comment 9. 
Thank you Mohammad for your testing efforts!
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.