1375002 - Nightly: omnibox.onInputChanged.addListener fails

Status: VERIFIED FIXED

(WebExtensions :: Frontend, defect, P2)

Description

[bucklereed]

Attachment: background.js

User Agent: Mozilla/5.0 (X11; Linux i686; rv:56.0) Gecko/20100101 Firefox/56.0
Build ID: 20170620100236

Steps to reproduce:

Open the addon debugger and load the attached WebExtension. Try using it: type 'example foo' in the location bar, and you should get a dummy suggestion.


Actual results:

No suggestions are provided. in the addon debugger, the error is 'TypeError: handler is undefined', in ExtensionParent.jsm, line 681.

Comment 1

[bucklereed]

Attachment: manifest.json

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

I ran into this the other day. I found that if I call setDefaultSuggestion before adding the listener, then everything works fine.

Comment 3

[Blake Winton (:bwinton) (:☕️)]

Daniela is looking into getting the regression window…

Comment 4

[Daniela Arcese [:daniela]]

Found it: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=38894655c89e68bcd8f45d31a0d3005f2c2b53db&tochange=b5d8b27a753725c1de41ffae2e338798f3b5cacd

Comment 5

[Daniela Arcese [:daniela]]

I tracked it down further: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=f2d18607854251fc668b6e156c24282888858680&tochange=31dd0a3e931a22133fe3d4e21abfc1c2e1fb891f

Comment 6

[Blake Winton (:bwinton) (:☕️)]

Looks like bug 1350522 was the culprit, perhaps because the API isn't loaded until we call setDefaultSuggestion?  :)

Comment 7

[Kris Maglione [:kmag]]

This is happening because, for some reason, the parent side of this API has an "omnibox_internal" namespace that the child-side onInputChanged event uses, and it isn't setup for lazy loading.

Comment 8

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2cb8b8e9d1e978c4824c4daa5ca44d533e2eac4f
Bug 1375002: Get rid of the omnibox_internal namespace. r=me

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2cb8b8e9d1e9

Comment 10

[Kris Maglione [:kmag]]

Attachment: Get rid of the omnibox_internal namespace

This namespace has schema definitions which spuriously expose it to extension
callers, and does not support lazy loading correctly, which breaks certain
usage patterns.

Comment 11

[Kris Maglione [:kmag]]

Comment on attachment 8883668 [details] [diff] [review]
Get rid of the omnibox_internal namespace

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1350522
[User impact if declined]: This causes certain add-ons which use the omnibox API to fail.
[Is this code covered by automated tests?]: Yes, though the specific bug is not, since it depends on the ordering of API calls during the entire length of the browsers session, and we can't reasonably test variations on that.
[Has the fix been verified in Nightly?]: No
[Needs manual test from QE? If yes, steps to reproduce]: Described in comment 0
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: It's a trivial change to merge an unnecessary internal namespace into the normal namespace for this API.
[String changes made/needed]: None

Comment 12

[Julien Cristau [:jcristau]]

Comment on attachment 8883668 [details] [diff] [review]
Get rid of the omnibox_internal namespace

fix regression affecting webextensions in beta55

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Needs a rebased patch for Beta.

Comment 14

[Kris Maglione [:kmag]]

https://hg.mozilla.org/releases/mozilla-beta/rev/0ad29e7311f85835a2329bacf0eecbd1ce193ccc

Comment 15

[Vasilica Tamas, QA [:vtamas]]

I was able to reproduce the initial error on Firefox 56.0a1 (2017-06-21) under Windows 10 64-bit.

Verified fixed on Firefox 56.0a1 (2017-07-25) under Windows 10 64-bit and Ubuntu 16.04 32-bit. 'TypeError: handler is undefined' error is no longer thrown in Browser Console. See screenshot: https://www.screencast.com/t/0zgQhgUMFg