Closed Bug 1375013 Opened 7 years ago Closed 7 years ago

Stub installer footer text is on top of footer image

Categories

(Firefox :: Installer, defect, P2)

defect

Tracking

()

VERIFIED FIXED
Firefox 56
Tracking Status
firefox55 --- verified
firefox56 --- verified

People

(Reporter: robert.strong.bugs, Assigned: molly)

References

Details

Attachments

(3 files)

Spinoff of bug 1372521comment #9

I've tested on Windows 7 x64 and Windows 10 x86 using latest Nightly 56.0a1 (2017-06-20) and Firefox 55 Beta 3(buildID: 20170619071723), several builds: ar, de, es-AR, es-ES, fa, fr, he, it, ru, ur and I have the following mentions: 

- the footer in the stub installer is no longer cut off
- the text overlap the Firefox icon on several localized builds, please see attachment "issue.png": 
           - on Firefox 55 Beta 3, I saw this issue on RTL builds: ar, fa, he, ur;
           - on latest Nightly 56.0a1, I saw this issue on sseveral localized builds: ar, es-AR, es-ES, fa, fr, he, nl, ru, ur 

Any thoughts about this issue?
It should be possible to resolve the issue shown in attachment #8879873 [details] in the same way as the blurbs were displayed in the previous stub installer's download and install page. It basically took into account the width of the area to display the image and the text, subtracted the image's width along with additional space between the image and the text, and then calculated the width of the text's containing box and the placement of the text's containing box.

The screenshot of the previous stub installer shows an example of the above.
Assignee: nobody → mhowell
Status: NEW → ASSIGNED
Priority: -- → P2
(In reply to Robert Strong [:rstrong] (use needinfo to contact me) from comment #1)
> It should be possible to resolve the issue shown in attachment #8879873 [details]
> [details] in the same way as the blurbs were displayed in the previous stub
> installer's download and install page. It basically took into account the
> width of the area to display the image and the text, subtracted the image's
> width along with additional space between the image and the text, and then
> calculated the width of the text's containing box and the placement of the
> text's containing box.

This is kind of like what we had, except the logo image is baked into the background, it's not a separate bitmap, so the calculations didn't have to be dynamic and were done by hand (that is, imprecisely and incompletely) and the results hard-coded. The patch I put up here will adjust the values so that they actually work, and also fix the RTL situation.
Comment on attachment 8880617 [details]
Bug 1375013 - Fix stub footer text for RTL locales, and adjust width to prevent running over logo image.

https://reviewboard.mozilla.org/r/151956/#review156954

Bummer about that being part of the background image. r+ on the code. Would be a good thing to verify this with different dpi settings as well as dpi settings and rtl.
Attachment #8880617 - Flags: review?(robert.strong.bugs) → review+
Pushed by mhowell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6eb2d4fe2ffc
Fix stub footer text for RTL locales, and adjust width to prevent running over logo image. r=rstrong
Comment on attachment 8880617 [details]
Bug 1375013 - Fix stub footer text for RTL locales, and adjust width to prevent running over logo image.

This is a follow up to bug 1372521, which was an incomplete fix. The approval request form in bug 1372521 comment 4 applies here.

As with that bug, QA should run the stub installer, look at the footer text (the text to the right of the logo), verify that it is entirely visible/legible, and then just immediately close the installer again. This should be done for all locales if possible, and at different DPI scaling settings.
Attachment #8880617 - Flags: approval-mozilla-beta?
Flags: qe-verify?
https://hg.mozilla.org/mozilla-central/rev/6eb2d4fe2ffc
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
Camelia, it would be good to verify this fix for the stub installer, see comment 6.
Flags: qe-verify?
Flags: qe-verify+
Flags: needinfo?(camelia.badau)
I've tested on Windows 7 x64 and Windows 10 x86 using latest Nightly 56.0a1, all locales, DPI 100% and DPI 150% and there still are issues on he, hu, hy-AM, dsb, fi, mr builds. 

Please see here the testing report: https://public.etherpad-mozilla.org/p/bug1375013
Flags: needinfo?(camelia.badau)
(In reply to Camelia Badau, QA [:cbadau] from comment #9)
> I've tested on Windows 7 x64 and Windows 10 x86 using latest Nightly 56.0a1,
> all locales, DPI 100% and DPI 150% and there still are issues on he, hu,
> hy-AM, dsb, fi, mr builds. 
> 
> Please see here the testing report:
> https://public.etherpad-mozilla.org/p/bug1375013

Matt, can you take a look?
Flags: needinfo?(mhowell)
Yeah, this is a separate issue and I'll file a new bug for it.
Flags: needinfo?(mhowell)
See Also: → 1376489
Comment on attachment 8880617 [details]
Bug 1375013 - Fix stub footer text for RTL locales, and adjust width to prevent running over logo image.

sounds like this improves the situation for the stub installer so let's land it for 55.0b6
Attachment #8880617 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
I've tested on Windows 7 x64 and Windows 10 x64 using Firefox 55 Beta 11, all locales, DPI 100% and DPI 150% and there still is one issue on da build: the title of the Stub Installer is "Installering af &BrandShortName". 

Please see here the testing report: https://public.etherpad-mozilla.org/p/bug1375013
Please file a bug against the da locale. They need to change &BrandShortName to $BrandShortName

Specifically
https://dxr.mozilla.org/l10n-mozilla-beta/source/da/browser/installer/nsisstrings.properties#21

INSTALLER_WIN_CAPTION=Installering af &BrandShortName

and it should be $BrandShortName such as here
https://dxr.mozilla.org/mozilla-beta/source/browser/locales/en-US/installer/nsisstrings.properties#21

NSTALLER_WIN_CAPTION=$BrandShortName Installer
(In reply to Robert Strong [:rstrong] (use needinfo to contact me) from comment #15)
> Please file a bug against the da locale. They need to change &BrandShortName
> to $BrandShortName
> 
> Specifically
> https://dxr.mozilla.org/l10n-mozilla-beta/source/da/browser/installer/
> nsisstrings.properties#21
> 
> INSTALLER_WIN_CAPTION=Installering af &BrandShortName
> 
> and it should be $BrandShortName such as here
> https://dxr.mozilla.org/mozilla-beta/source/browser/locales/en-US/installer/
> nsisstrings.properties#21
> 
> NSTALLER_WIN_CAPTION=$BrandShortName Installer

Done: 
https://hg.mozilla.org/releases/l10n/mozilla-beta/da/rev/9d40bd4ccb073f95af473dbcc3fbce78f4e5340e
https://hg.mozilla.org/l10n-central/da/rev/e17711bb81ccf6d07ced3d8eaa08324776f72612
Verified the "da" build on Windows 7 x86 and Windows 10 x86 using Firefox 56 Beta 11 and the title of the Stub Installer is the correct one: "Installering af Firefox". 

Marking the issue as VERIFIED FIXED.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.