1375070 - 5.08 - 6.21% damp (linux64, windows7-32) regression on push 72a0af4b7041879f651f2222838e41acc5ff60b5 (Tue Jun 20 2017)

Status: RESOLVED WONTFIX

(DevTools :: Inspector, defect)

Description

[Ionuț Goldan [:igoldan]]

Talos has detected a Firefox performance regression from push:

https://hg.mozilla.org/integration/autoland/pushloghtml?changeset=72a0af4b7041879f651f2222838e41acc5ff60b5

As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

  6%  damp summary windows7-32 opt e10s     260.97 -> 277.17
  5%  damp summary linux64 opt e10s         232.76 -> 244.59


You can find links to graphs and comparison views for each of the above tests at: https://treeherder.mozilla.org/perf.html#/alerts?id=7444

On the page above you can see an alert for each affected platform as well as a link to a graph showing the history of scores for this test. There is also a link to a treeherder page showing the Talos jobs in a pushlog format.

To learn more about the regressing test(s), please see: https://wiki.mozilla.org/Buildbot/Talos/Tests

For information on reproducing and debugging the regression, either on try or locally, see: https://wiki.mozilla.org/Buildbot/Talos/Running

*** Please let us know your plans within 3 business days, or the offending patch(es) will be backed out! ***

Our wiki page outlines the common responses and expectations: https://wiki.mozilla.org/Buildbot/Talos/RegressionBugsHandling

Comment 1

[Ionuț Goldan [:igoldan]]

:gl Could you take a look over this developer tools perf regression and estimate a fix time for it?

Comment 2

[Brian Grinstead [:bgrins]]

This looks like it's entirely getting hit on inspector.close [0] - went from  85ms to 2,250ms! Maybe the panel is waiting for something async on destroy?

[0]: https://treeherder.mozilla.org/perf.html#/comparesubtest?originalProject=autoland&originalRevision=25fe56e55e611f8b6747c9378ec492b538c8ce29&newProject=autoland&newRevision=72a0af4b7041879f651f2222838e41acc5ff60b5&originalSignature=63c652b34bd8fcf3623be048bdd3104906f70f02&newSignature=63c652b34bd8fcf3623be048bdd3104906f70f02&framework=1

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

this seems to be fixed:
== Change summary for alert #7480 (as of June 22 2017 01:14 UTC) ==

Improvements:

  6%  damp summary windows7-32 opt e10s     277.41 -> 260.53
  4%  damp summary linux64 opt e10s         244.25 -> 234.75

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=7480

this looks to be a merge in, but the merge from inbound has no data which shows the regression- is it possible this was fixed on mozilla-central somehow?

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

I would like to close this bug, please comment if you would like this to remain open