Closed
Bug 1375077
Opened 7 years ago
Closed 7 years ago
App update timer should watch for profile-before-change instead of xpcom-shutdown
Categories
(Toolkit :: Application Update, enhancement, P3)
Toolkit
Application Update
Tracking
()
RESOLVED
FIXED
mozilla56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: benjamin, Assigned: benjamin)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
The app update timer watches for xpcom-shutdown to stop its services. However this is too late for several reasons: 1) networking shuts down before this 2) prefs don't save properly The patch I will attach shuts down the app udpate timer in profile-before-change which gives you much more leeway to do stuff. Short-term this blocks landing bug 1327988.
Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
(In reply to Benjamin Smedberg [:bsmedberg] from comment #0) > The app update timer watches for xpcom-shutdown to stop its services. > However this is too late for several reasons: > > 1) networking shuts down before this > 2) prefs don't save properly > > The patch I will attach shuts down the app udpate timer in > profile-before-change which gives you much more leeway to do stuff. > Short-term this blocks landing bug 1327988. Talked with bsmedberg on irc and this blocks bug 1372988.
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8880013 [details] Bug 1375077 - Change app update timer to shut down at profile-before-change instead of xpcom-shutdown, https://reviewboard.mozilla.org/r/151350/#review156324
Attachment #8880013 -
Flags: review?(robert.strong.bugs) → review+
Pushed by bsmedberg@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/5856f1c45a92 Change app update timer to shut down at profile-before-change instead of xpcom-shutdown, r=rstrong
Comment 5•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/5856f1c45a92
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Backout by philringnalda@gmail.com: https://hg.mozilla.org/mozilla-central/rev/7fb0f878a23b Backed out changeset 5856f1c45a92 for Windows opt permaorange in test_worker_basic.html
Comment 7•7 years ago
|
||
Backed out in https://hg.mozilla.org/mozilla-central/rev/7fb0f878a23b54cb069c28836f347f9baf077c06 because something in that push made "dom/filesystem/tests/test_worker_basic.html | Something when wrong" permaorange on Windows opt, e.g. https://treeherder.mozilla.org/logviewer.html#?job_id=109432905&repo=mozilla-inbound
Status: RESOLVED → REOPENED
status-firefox56:
fixed → ---
Resolution: FIXED → ---
Target Milestone: mozilla56 → ---
Pushed by bsmedberg@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/913a0f2ce37f Change app update timer to shut down at profile-before-change instead of xpcom-shutdown, r=rstrong
Comment 9•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/913a0f2ce37f
Status: REOPENED → RESOLVED
Closed: 7 years ago → 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•