allow well formed manually crafted servo merge commits to bypass scm_servo_vendor commit hook check

RESOLVED FIXED

Status

Developer Services
Mercurial: hg.mozilla.org
RESOLVED FIXED
8 months ago
8 months ago

People

(Reporter: glob, Assigned: glob)

Tracking

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

8 months ago
allow well formed manually crafted servo merge commits to bypass scm_servo_vendor commit hook check.

where "well formed" means:
- commit desc must start with "servo: Merge #"
- mercurial extra data exists for subtree_revision and subtree_source
- no files outside of the /servo directory are modified
(Assignee)

Updated

8 months ago
Assignee: nobody → glob
No longer blocks: 1374534
Depends on: 1374534
Comment hidden (mozreview-request)

Comment 2

8 months ago
mozreview-review
Comment on attachment 8880274 [details]
hghooks: allow well formed manually crafted servo merge commits to bypass scm_servo_vendor commit hook check (bug 1375092)

https://reviewboard.mozilla.org/r/151632/#review156956

::: hghooks/tests/commitextras.py:17
(Diff revision 1)
> +    extensions,
> +)
> +
> +cmdtable = {}
> +command = cmdutil.command(cmdtable)
> +testedwith = 'ships-with-fb-hgext'

Please nuke this line.
Attachment #8880274 - Flags: review?(gps) → review+
Comment hidden (mozreview-request)

Comment 4

8 months ago
Pushed by bjones@mozilla.com:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/7205da759cad
hghooks: allow well formed manually crafted servo merge commits to bypass scm_servo_vendor commit hook check r=gps
Status: NEW → RESOLVED
Last Resolved: 8 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.