1375096 - Make tpaint use TalosContentProfiler

Status: RESOLVED FIXED

(Testing :: Talos, enhancement)

Description

[Mike Conley (:mconley) (:⚙️)]

This is necessary in order to get nice profiles from automation for the tpaint test.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1375096 - Make it so that TalosContentProfiler beginTest and finishTest can be called without the profiler being enabled.

Review commit: https://reviewboard.mozilla.org/r/151354/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/151354/

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1375096 - Make tpaint use TalosContentProfiler so that we can get full profiles from automation.

Review commit: https://reviewboard.mozilla.org/r/151356/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/151356/

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8880023 [details]
Bug 1375096 - Make it so that TalosContentProfiler beginTest and finishTest can be called without the profiler being enabled.

https://reviewboard.mozilla.org/r/151354/#review156306

thanks for updating the comments

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8880024 [details]
Bug 1375096 - Make tpaint use TalosContentProfiler so that we can get full profiles from automation.

https://reviewboard.mozilla.org/r/151356/#review156308

this patch is good!  Do we need to adjust other tests so this works?

Comment 5

[Mike Conley (:mconley) (:⚙️)]

(In reply to Joel Maher ( :jmaher) from comment #4)
> 
> this patch is good!  Do we need to adjust other tests so this works?

Thanks for the review!

Yeah - there are still some tests that don't use TalosContentProfiler properly. Most of them are pageloader tests, and I plan on fixing that in bug 1374333.

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8880023 [details]
Bug 1375096 - Make it so that TalosContentProfiler beginTest and finishTest can be called without the profiler being enabled.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/151354/diff/1-2/

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8880024 [details]
Bug 1375096 - Make tpaint use TalosContentProfiler so that we can get full profiles from automation.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/151356/diff/1-2/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4ed072806971
Make it so that TalosContentProfiler beginTest and finishTest can be called without the profiler being enabled. r=jmaher
https://hg.mozilla.org/integration/autoland/rev/e880eb3794ec
Make tpaint use TalosContentProfiler so that we can get full profiles from automation. r=jmaher

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4ed072806971
https://hg.mozilla.org/mozilla-central/rev/e880eb3794ec