Make tpaint use TalosContentProfiler

RESOLVED FIXED in Firefox 56

Status

Testing
Talos
RESOLVED FIXED
4 months ago
4 months ago

People

(Reporter: mconley, Assigned: mconley)

Tracking

unspecified
mozilla56
Points:
---

Firefox Tracking Flags

(firefox56 fixed)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

This is necessary in order to get nice profiles from automation for the tpaint test.
Assignee: nobody → mconley
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 3

4 months ago
mozreview-review
Comment on attachment 8880023 [details]
Bug 1375096 - Make it so that TalosContentProfiler beginTest and finishTest can be called without the profiler being enabled.

https://reviewboard.mozilla.org/r/151354/#review156306

thanks for updating the comments
Attachment #8880023 - Flags: review?(jmaher) → review+

Comment 4

4 months ago
mozreview-review
Comment on attachment 8880024 [details]
Bug 1375096 - Make tpaint use TalosContentProfiler so that we can get full profiles from automation.

https://reviewboard.mozilla.org/r/151356/#review156308

this patch is good!  Do we need to adjust other tests so this works?
Attachment #8880024 - Flags: review?(jmaher) → review+
(In reply to Joel Maher ( :jmaher) from comment #4)
> 
> this patch is good!  Do we need to adjust other tests so this works?

Thanks for the review!

Yeah - there are still some tests that don't use TalosContentProfiler properly. Most of them are pageloader tests, and I plan on fixing that in bug 1374333.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 8

4 months ago
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4ed072806971
Make it so that TalosContentProfiler beginTest and finishTest can be called without the profiler being enabled. r=jmaher
https://hg.mozilla.org/integration/autoland/rev/e880eb3794ec
Make tpaint use TalosContentProfiler so that we can get full profiles from automation. r=jmaher

Comment 9

4 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/4ed072806971
https://hg.mozilla.org/mozilla-central/rev/e880eb3794ec
Status: NEW → RESOLVED
Last Resolved: 4 months ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.