Closed Bug 1375153 Opened 2 years ago Closed 2 years ago

Move nsStyleContext::mComputingStruct and AutoCheckDependency to GeckoStyleContext

Categories

(Core :: CSS Parsing and Computation, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: manishearth, Assigned: jyc)

Details

Attachments

(1 file)

nsStyleContext has a field "mComputingStruct"[1]. It's only used by the AUTO_CHECK_DEPENDENCY stuff[2] which is only used as a debug check when we're sure we're in Gecko mode[3].

We should move mComputingStruct and to GeckoStyleContext, move all of the AUTO_CHECK_DEPENDENCY stuff to the inlines file, and have AUTO_CHECK_DEPENDENCY take an argument that is a pointer to `gecko` and use that instead.



 [1]: https://dxr.mozilla.org/mozilla-central/rev/e1e4a481b7e88dce163b9cccc2fb72032023befa/layout/style/nsStyleContext.h#494
 [2]: https://dxr.mozilla.org/mozilla-central/rev/e1e4a481b7e88dce163b9cccc2fb72032023befa/layout/style/nsStyleContext.h#428-455
 [3]: https://dxr.mozilla.org/mozilla-central/rev/e1e4a481b7e88dce163b9cccc2fb72032023befa/layout/style/nsStyleContextInlines.h#62-85
Try run just in case (though I can run the debug build with no problems): https://hg.mozilla.org/try/rev/5d63de3170d83028d7e9356387bdf35164a80d19
Assignee: nobody → jyc
Status: NEW → ASSIGNED
Comment on attachment 8880115 [details]
Bug 1375153 - Move nsStyleContext::mComputingStruct and AutoCheckDependency to GeckoStyleContext.

https://reviewboard.mozilla.org/r/151502/#review157248
Attachment #8880115 - Flags: review?(manishearth) → review+
hg error in cmd: hg push -r tip ssh://hg.mozilla.org/integration/autoland: pushing to ssh://hg.mozilla.org/integration/autoland
searching for changes
remote: adding changesets
remote: adding manifests
remote: adding file changes
remote: added 1 changesets with 5 changes to 5 files
remote: 
remote: 
remote: ************************** ERROR ****************************
remote: Rev 589fab451c7e needs "Bug N" or "No bug" in the commit message.
remote: Jonathan Chan <jyc@eqv.io>
remote: Bug #1375153 - Move nsStyleContext::mComputingStruct and AutoCheckDependency to GeckoStyleContext. r=manishearth
remote: 
remote: These are only used in Gecko mode.
remote: 
remote: MozReview-Commit-ID: DKQBwatbu62
remote: *************************************************************
remote: 
remote: 
remote: transaction abort!
remote: rollback completed
remote: pretxnchangegroup.c_commitmessage hook failed
abort: push failed on remote
Pushed by dholbert@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7475bd8bee6e
Move nsStyleContext::mComputingStruct and AutoCheckDependency to GeckoStyleContext. r=manishearth
https://hg.mozilla.org/mozilla-central/rev/7475bd8bee6e
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.