Closed Bug 1375162 Opened 7 years ago Closed 7 years ago

Fixes to Paste & Go Patch

Categories

(Focus-iOS :: General, enhancement)

Other
iOS
enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: sdaswani, Unassigned, Mentored)

References

Details

Attachments

(1 file)

47 bytes, text/x-github-pull-request
farhan
: review+
Details | Review
A few comments from Stefan:

1) "`UIPasteboard.general.string!` is used .. that is not a good idea. That should most certainly be turned into an `if let text = UIPasteboard.generalstring ...`"

2) "There may be another issue .. for FIrefox we discovered that the applications locks up when you access UIPasteboard when you have copied something on your Mac .. via clipboard sharing"
Stefan can you give more information the 2nd item?
Blocks: 1372616
Flags: needinfo?(sarentz)
Attached file Pull Request
Attachment #8880468 - Flags: review?(sarentz)
Attachment #8880468 - Flags: review?(sarentz) → review?(fpatel)
Attachment #8880468 - Flags: review?(fpatel) → review+
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Flags: needinfo?(sarentz)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: