1375164 - [wasm] Debugger fails on large wasm binary files

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Description

[Yury Delendik (:yury)]

After bug 1364535, (old) debugger cannot display large wasm sources. Source text panel displays "Loading..." and the following error can be found in the console:

"onPacket threw an exception: Error: Server did not specify an actor, dropping packet: {"error":"unknownError","message":"error occurred while processing 'slice: RangeError: too many arguments provided for a function call\nStack: onSlice@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/server/actors/object.js:2186:21\nonPacket@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/server/main.js:1799:15\nreceiveMessage@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/transport/transport.js:761:7\nLine: 2186, column: 21"}

Comment 1

[Yury Delendik (:yury)]

Attachment: Bug 1375164 - Add arguments to the ArrayBufferClient.slice method.

Review commit: https://reviewboard.mozilla.org/r/151396/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/151396/

Comment 2

[Yury Delendik (:yury)]

The slice call of the ArrayBufferActor always was returning entire buffer (for our purpose). There is a code to protect String.fromCharCodea.apply from providing insane amount of arguments, see https://dxr.mozilla.org/mozilla-central/source/devtools/server/actors/object.js#2186. However it was not used since we forgot to pass the start and count arguments to the slice method.

Comment 3

[Jason Laster [:jlast]]

Comment on attachment 8880061 [details]
Bug 1375164 - Add arguments to the ArrayBufferClient.slice method.

https://reviewboard.mozilla.org/r/151396/#review156864

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bb709c071712
Add arguments to the ArrayBufferClient.slice method. r=jlast

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/bb709c071712